From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Prashant Malani <pmalani@chromium.org>, linux-kernel@vger.kernel.org
Cc: heikki.krogerus@linux.intel.com,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Mark Brown <broonie@kernel.org>,
Tzung-Bi Shih <tzungbi@google.com>,
Yicheng Li <yichengli@chromium.org>
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_typec: Add TBT pd_ctrl fields
Date: Fri, 26 Jun 2020 11:10:58 +0200 [thread overview]
Message-ID: <26f8dac0-36a0-65ba-a219-8c1d65f1799f@collabora.com> (raw)
In-Reply-To: <20200624080926.165107-1-pmalani@chromium.org>
Hi Prashant,
On 24/6/20 10:09, Prashant Malani wrote:
> To support Thunderbolt compatibility mode, synchronize
> ec_response_usb_pd_control_v2 with the Chrome EC version, so that
> we get the Thunderbolt related control fields and macros.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Applied both patches for 5.9
> ---
> .../linux/platform_data/cros_ec_commands.h | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index a7b0fc440c35..b808570bdd04 100644
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -4917,15 +4917,26 @@ struct ec_response_usb_pd_control_v1 {
> #define USBC_PD_CC_UFP_ATTACHED 4 /* UFP attached to usbc */
> #define USBC_PD_CC_DFP_ATTACHED 5 /* DPF attached to usbc */
>
> +/* Active/Passive Cable */
> +#define USB_PD_CTRL_ACTIVE_CABLE BIT(0)
> +/* Optical/Non-optical cable */
> +#define USB_PD_CTRL_OPTICAL_CABLE BIT(1)
> +/* 3rd Gen TBT device (or AMA)/2nd gen tbt Adapter */
> +#define USB_PD_CTRL_TBT_LEGACY_ADAPTER BIT(2)
> +/* Active Link Uni-Direction */
> +#define USB_PD_CTRL_ACTIVE_LINK_UNIDIR BIT(3)
> +
> struct ec_response_usb_pd_control_v2 {
> uint8_t enabled;
> uint8_t role;
> uint8_t polarity;
> char state[32];
> - uint8_t cc_state; /* USBC_PD_CC_*Encoded cc state */
> - uint8_t dp_mode; /* Current DP pin mode (MODE_DP_PIN_[A-E]) */
> - /* CL:1500994 Current cable type */
> - uint8_t reserved_cable_type;
> + uint8_t cc_state; /* enum pd_cc_states representing cc state */
> + uint8_t dp_mode; /* Current DP pin mode (MODE_DP_PIN_[A-E]) */
> + uint8_t reserved; /* Reserved for future use */
> + uint8_t control_flags; /* USB_PD_CTRL_*flags */
> + uint8_t cable_speed; /* TBT_SS_* cable speed */
> + uint8_t cable_gen; /* TBT_GEN3_* cable rounded support */
> } __ec_align1;
>
> #define EC_CMD_USB_PD_PORTS 0x0102
>
next prev parent reply other threads:[~2020-06-26 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 8:09 [PATCH 1/2] platform/chrome: cros_ec_typec: Add TBT pd_ctrl fields Prashant Malani
2020-06-24 8:09 ` [PATCH 2/2] platform/chrome: cros_ec_typec: Add TBT compat support Prashant Malani
2020-06-24 9:15 ` Heikki Krogerus
2020-06-24 9:20 ` Heikki Krogerus
2020-06-24 17:42 ` Prashant Malani
2020-06-25 7:45 ` Heikki Krogerus
2020-06-26 9:10 ` Enric Balletbo i Serra [this message]
2020-06-26 19:04 ` [PATCH 1/2] platform/chrome: cros_ec_typec: Add TBT pd_ctrl fields Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26f8dac0-36a0-65ba-a219-8c1d65f1799f@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=tzungbi@google.com \
--cc=yichengli@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).