* [RESEND PATCH] drm/msm/a6xx: fix frequency not always being restored on GMU resume
@ 2020-08-13 18:54 Jonathan Marek
2020-08-17 12:51 ` Akhil P Oommen
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Marek @ 2020-08-13 18:54 UTC (permalink / raw)
To: freedreno
Cc: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Jordan Crouse,
Sharat Masetty, Akhil P Oommen, Christophe JAILLET,
open list:DRM DRIVER FOR MSM ADRENO GPU,
open list:DRM DRIVER FOR MSM ADRENO GPU, open list
The patch reorganizing the set_freq function made it so the gmu resume
doesn't always set the frequency, because a6xx_gmu_set_freq() exits early
when the frequency hasn't been changed. Note this always happens when
resuming GMU after recovering from a hang.
Use a simple workaround to prevent this from happening.
Fixes: 1f60d11423db ("drm: msm: a6xx: send opp instead of a frequency")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index b67b38c8fadf..bbbd00020f92 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -845,6 +845,7 @@ static void a6xx_gmu_set_initial_freq(struct msm_gpu *gpu, struct a6xx_gmu *gmu)
if (IS_ERR_OR_NULL(gpu_opp))
return;
+ gmu->freq = 0; /* so a6xx_gmu_set_freq() doesn't exit early */
a6xx_gmu_set_freq(gpu, gpu_opp);
dev_pm_opp_put(gpu_opp);
}
--
2.26.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] drm/msm/a6xx: fix frequency not always being restored on GMU resume
2020-08-13 18:54 [RESEND PATCH] drm/msm/a6xx: fix frequency not always being restored on GMU resume Jonathan Marek
@ 2020-08-17 12:51 ` Akhil P Oommen
0 siblings, 0 replies; 2+ messages in thread
From: Akhil P Oommen @ 2020-08-17 12:51 UTC (permalink / raw)
To: Jonathan Marek, freedreno
Cc: David Airlie, open list:DRM DRIVER FOR MSM ADRENO GPU,
Sharat Masetty, open list:DRM DRIVER FOR MSM ADRENO GPU,
Christophe JAILLET, Sean Paul, open list
Why don't we move the early return in a6xx_gmu_set_freq() to
msm_devfreq_target() instead?
-Akhil.
On 8/14/2020 12:24 AM, Jonathan Marek wrote:
> The patch reorganizing the set_freq function made it so the gmu resume
> doesn't always set the frequency, because a6xx_gmu_set_freq() exits early
> when the frequency hasn't been changed. Note this always happens when
> resuming GMU after recovering from a hang.
>
> Use a simple workaround to prevent this from happening.
>
> Fixes: 1f60d11423db ("drm: msm: a6xx: send opp instead of a frequency")
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index b67b38c8fadf..bbbd00020f92 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -845,6 +845,7 @@ static void a6xx_gmu_set_initial_freq(struct msm_gpu *gpu, struct a6xx_gmu *gmu)
> if (IS_ERR_OR_NULL(gpu_opp))
> return;
>
> + gmu->freq = 0; /* so a6xx_gmu_set_freq() doesn't exit early */
> a6xx_gmu_set_freq(gpu, gpu_opp);
> dev_pm_opp_put(gpu_opp);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-17 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-13 18:54 [RESEND PATCH] drm/msm/a6xx: fix frequency not always being restored on GMU resume Jonathan Marek
2020-08-17 12:51 ` Akhil P Oommen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).