[PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

[PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

[Jonghwan Choi]

Frequency lock should be considered in suspend/hibernation.

Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
 drivers/devfreq/exynos/exynos5_bus.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/devfreq/exynos/exynos5_bus.c b/drivers/devfreq/exynos/exynos5_bus.c
index a60da3c..bd672de0 100644
--- a/drivers/devfreq/exynos/exynos5_bus.c
+++ b/drivers/devfreq/exynos/exynos5_bus.c
@@ -268,6 +268,7 @@ static int exynos5_busfreq_int_pm_notifier_event(struct notifier_block *this,
 	int err = 0;
 
 	switch (event) {
+	case PM_HIBERNATION_PREPARE:
 	case PM_SUSPEND_PREPARE:
 		/* Set Fastest and Deactivate DVFS */
 		mutex_lock(&data->lock);
@@ -300,6 +301,7 @@ unlock:
 		if (err)
 			return NOTIFY_BAD;
 		return NOTIFY_OK;
+	case PM_POST_HIBERNATION:
 	case PM_POST_RESTORE:
 	case PM_POST_SUSPEND:
 		/* Reactivate */
-- 
1.8.1.2

Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

[Bartlomiej Zolnierkiewicz]

Hi,

Are you planning to add hibernation support to ARM?

If so then this should be stated somewhere in the patch description.

OTOH if you are not going to add hibernation support to ARM I see
a little sense in adding hibernation support to ARM-only drivers..

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

On Tuesday, November 19, 2013 10:30:31 PM Jonghwan Choi wrote:
> Frequency lock should be considered in suspend/hibernation.
> 
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
>  drivers/devfreq/exynos/exynos5_bus.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/devfreq/exynos/exynos5_bus.c b/drivers/devfreq/exynos/exynos5_bus.c
> index a60da3c..bd672de0 100644
> --- a/drivers/devfreq/exynos/exynos5_bus.c
> +++ b/drivers/devfreq/exynos/exynos5_bus.c
> @@ -268,6 +268,7 @@ static int exynos5_busfreq_int_pm_notifier_event(struct notifier_block *this,
>  	int err = 0;
>  
>  	switch (event) {
> +	case PM_HIBERNATION_PREPARE:
>  	case PM_SUSPEND_PREPARE:
>  		/* Set Fastest and Deactivate DVFS */
>  		mutex_lock(&data->lock);
> @@ -300,6 +301,7 @@ unlock:
>  		if (err)
>  			return NOTIFY_BAD;
>  		return NOTIFY_OK;
> +	case PM_POST_HIBERNATION:
>  	case PM_POST_RESTORE:
>  	case PM_POST_SUSPEND:
>  		/* Reactivate */

Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

[Sebastian Capella]

Quoting Bartlomiej Zolnierkiewicz (2013-11-19 06:50:05)
> Hi,
> 
> Are you planning to add hibernation support to ARM?
> 
> If so then this should be stated somewhere in the patch description.
> 
> OTOH if you are not going to add hibernation support to ARM I see
> a little sense in adding hibernation support to ARM-only drivers..

FYI, we at Linaro and a few others have been working on adding
hibernation support for ARM.  I have not coordinated with Jonghwan
however.

Apoligies for the earlier toppost.

Thanks,

Sebastian Capella

Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

[MyungJoo Ham]

On Tue, Nov 19, 2013 at 10:30 PM, Jonghwan Choi <jhbird.choi@gmail.com> wrote:
> Frequency lock should be considered in suspend/hibernation.
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>




Cheers,
MyungJoo.

> ---
>  drivers/devfreq/exynos/exynos5_bus.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/devfreq/exynos/exynos5_bus.c b/drivers/devfreq/exynos/exynos5_bus.c
> index a60da3c..bd672de0 100644
> --- a/drivers/devfreq/exynos/exynos5_bus.c
> +++ b/drivers/devfreq/exynos/exynos5_bus.c
> @@ -268,6 +268,7 @@ static int exynos5_busfreq_int_pm_notifier_event(struct notifier_block *this,
>         int err = 0;
>
>         switch (event) {
> +       case PM_HIBERNATION_PREPARE:
>         case PM_SUSPEND_PREPARE:
>                 /* Set Fastest and Deactivate DVFS */
>                 mutex_lock(&data->lock);
> @@ -300,6 +301,7 @@ unlock:
>                 if (err)
>                         return NOTIFY_BAD;
>                 return NOTIFY_OK;
> +       case PM_POST_HIBERNATION:
>         case PM_POST_RESTORE:
>         case PM_POST_SUSPEND:
>                 /* Reactivate */
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
MyungJoo Ham, Ph.D.
System S/W Lab, S/W Center, Samsung Electronics

Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier

[MyungJoo Ham]

On Wed, Nov 20, 2013 at 7:08 AM, Sebastian Capella
<sebastian.capella@linaro.org> wrote:
> Quoting Bartlomiej Zolnierkiewicz (2013-11-19 06:50:05)
>> Hi,
>>
>> Are you planning to add hibernation support to ARM?
>>
>> If so then this should be stated somewhere in the patch description.
>>
>> OTOH if you are not going to add hibernation support to ARM I see
>> a little sense in adding hibernation support to ARM-only drivers..
>
> FYI, we at Linaro and a few others have been working on adding
> hibernation support for ARM.  I have not coordinated with Jonghwan
> however.

That is great.

We once tried to upstream hibernation support and forgot it for a while, too.
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-December/036101.html

I have not coordinated with Jonghwan Choi, either.
However, it appears that some others are trying now, too.


Cheers,
MyungJoo

>
> Apoligies for the earlier toppost.
>
> Thanks,
>
> Sebastian Capella
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
MyungJoo Ham, Ph.D.
System S/W Lab, S/W Center, Samsung Electronics