From: Maxim Levitsky <mlevitsk@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sean Christopherson <seanjc@google.com>,
Marc Zyngier <maz@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
open list <linux-kernel@vger.kernel.org>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Jonathan Corbet <corbet@lwn.net>, Jessica Yu <jeyu@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Will Deacon <will@kernel.org>,
"open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)"
<kvmarm@lists.cs.columbia.edu>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Vasily Gorbik <gor@linux.ibm.com>, Joerg Roedel <joro@8bytes.org>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Jim Mattson <jmattson@google.com>,
Cornelia Huck <cohuck@redhat.com>,
David Hildenbrand <david@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Janosch Frank <frankja@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"open list:S390" <linux-s390@vger.kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Kieran Bingham <kbingham@kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)"
<linux-arm-kernel@lists.infradead.org>,
James Morse <james.morse@arm.com>
Subject: Re: [PATCH v2 0/9] KVM: my debug patch queue
Date: Tue, 06 Apr 2021 14:59:14 +0300 [thread overview]
Message-ID: <27193ea74081023b67ab9c98d7050b1e22655e79.camel@redhat.com> (raw)
In-Reply-To: <cb7f918c-932f-d558-76ec-801ed8ed1f62@redhat.com>
On Fri, 2021-04-02 at 19:38 +0200, Paolo Bonzini wrote:
> On 01/04/21 15:54, Maxim Levitsky wrote:
> > Hi!
> >
> > I would like to publish two debug features which were needed for other stuff
> > I work on.
> >
> > One is the reworked lx-symbols script which now actually works on at least
> > gdb 9.1 (gdb 9.2 was reported to fail to load the debug symbols from the kernel
> > for some reason, not related to this patch) and upstream qemu.
>
> Queued patches 2-5 for now. 6 is okay but it needs a selftest. (e.g.
> using KVM_VCPU_SET_EVENTS) and the correct name for the constant.
Thanks!
I will do this very soon.
Best regards,
Maxim Levitsky
>
> Paolo
>
> > The other feature is the ability to trap all guest exceptions (on SVM for now)
> > and see them in kvmtrace prior to potential merge to double/triple fault.
> >
> > This can be very useful and I already had to manually patch KVM a few
> > times for this.
> > I will, once time permits, implement this feature on Intel as well.
> >
> > V2:
> >
> > * Some more refactoring and workarounds for lx-symbols script
> >
> > * added KVM_GUESTDBG_BLOCKEVENTS flag to enable 'block interrupts on
> > single step' together with KVM_CAP_SET_GUEST_DEBUG2 capability
> > to indicate which guest debug flags are supported.
> >
> > This is a replacement for unconditional block of interrupts on single
> > step that was done in previous version of this patch set.
> > Patches to qemu to use that feature will be sent soon.
> >
> > * Reworked the the 'intercept all exceptions for debug' feature according
> > to the review feedback:
> >
> > - renamed the parameter that enables the feature and
> > moved it to common kvm module.
> > (only SVM part is currently implemented though)
> >
> > - disable the feature for SEV guests as was suggested during the review
> > - made the vmexit table const again, as was suggested in the review as well.
> >
> > Best regards,
> > Maxim Levitsky
> >
> > Maxim Levitsky (9):
> > scripts/gdb: rework lx-symbols gdb script
> > KVM: introduce KVM_CAP_SET_GUEST_DEBUG2
> > KVM: x86: implement KVM_CAP_SET_GUEST_DEBUG2
> > KVM: aarch64: implement KVM_CAP_SET_GUEST_DEBUG2
> > KVM: s390x: implement KVM_CAP_SET_GUEST_DEBUG2
> > KVM: x86: implement KVM_GUESTDBG_BLOCKEVENTS
> > KVM: SVM: split svm_handle_invalid_exit
> > KVM: x86: add force_intercept_exceptions_mask
> > KVM: SVM: implement force_intercept_exceptions_mask
> >
> > Documentation/virt/kvm/api.rst | 4 +
> > arch/arm64/include/asm/kvm_host.h | 4 +
> > arch/arm64/kvm/arm.c | 2 +
> > arch/arm64/kvm/guest.c | 5 -
> > arch/s390/include/asm/kvm_host.h | 4 +
> > arch/s390/kvm/kvm-s390.c | 3 +
> > arch/x86/include/asm/kvm_host.h | 12 ++
> > arch/x86/include/uapi/asm/kvm.h | 1 +
> > arch/x86/kvm/svm/svm.c | 87 +++++++++++--
> > arch/x86/kvm/svm/svm.h | 6 +-
> > arch/x86/kvm/x86.c | 14 ++-
> > arch/x86/kvm/x86.h | 2 +
> > include/uapi/linux/kvm.h | 1 +
> > kernel/module.c | 8 +-
> > scripts/gdb/linux/symbols.py | 203 ++++++++++++++++++++----------
> > 15 files changed, 272 insertions(+), 84 deletions(-)
> >
next prev parent reply other threads:[~2021-04-06 11:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 13:54 [PATCH v2 0/9] KVM: my debug patch queue Maxim Levitsky
2021-04-01 13:54 ` [PATCH v2 1/9] scripts/gdb: rework lx-symbols gdb script Maxim Levitsky
2021-04-01 13:54 ` [PATCH v2 2/9] KVM: introduce KVM_CAP_SET_GUEST_DEBUG2 Maxim Levitsky
2021-04-01 13:54 ` [PATCH v2 3/9] KVM: x86: implement KVM_CAP_SET_GUEST_DEBUG2 Maxim Levitsky
2021-04-01 13:54 ` [PATCH v2 4/9] KVM: aarch64: " Maxim Levitsky
2021-04-01 13:54 ` [PATCH v2 5/9] KVM: s390x: " Maxim Levitsky
2021-04-01 13:54 ` [PATCH v2 6/9] KVM: x86: implement KVM_GUESTDBG_BLOCKEVENTS Maxim Levitsky
2021-04-02 17:07 ` Paolo Bonzini
2021-04-01 13:54 ` [PATCH v2 7/9] KVM: SVM: split svm_handle_invalid_exit Maxim Levitsky
2021-04-01 13:54 ` [PATCH v2 8/9] KVM: x86: add force_intercept_exceptions_mask Maxim Levitsky
2021-04-27 11:38 ` Borislav Petkov
2021-04-01 13:54 ` [PATCH v2 9/9] KVM: SVM: implement force_intercept_exceptions_mask Maxim Levitsky
2021-04-02 17:38 ` [PATCH v2 0/9] KVM: my debug patch queue Paolo Bonzini
2021-04-06 11:59 ` Maxim Levitsky [this message]
2021-04-26 12:43 ` Maxim Levitsky
2021-04-26 12:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27193ea74081023b67ab9c98d7050b1e22655e79.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=imbrenda@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jan.kiszka@siemens.com \
--cc=jeyu@kernel.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=julien.thierry.kdev@gmail.com \
--cc=kbingham@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=sgarzare@redhat.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).