From: Jie Deng <jie.deng@intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-i2c@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, wsa@kernel.org,
wsa+renesas@sang-engineering.com, mst@redhat.com, arnd@arndb.de,
jasowang@redhat.com, andriy.shevchenko@linux.intel.com,
yu1.wang@intel.com, shuo.a.liu@intel.com, conghui.chen@intel.com,
stefanha@redhat.com
Subject: Re: [PATCH v12] i2c: virtio: add a virtio i2c frontend driver
Date: Mon, 5 Jul 2021 15:13:25 +0800 [thread overview]
Message-ID: <273be5a6-c45f-8f12-361f-65caf0c3d08b@intel.com> (raw)
In-Reply-To: <20210705063003.a45ic3wn74nre6xe@vireshk-i7>
On 2021/7/5 14:30, Viresh Kumar wrote:
>>
>> This is still not enough to convince me. So I won't change them for now
>> until I see it
>>
>> is the consensus of the majority.
> Do you see reqs[i] to ever be NULL here ? If not, then if (req) is like if
> (true).
>
> Why would you want to have something like that ?
No. Currently, virtio_i2c_complete_reqs is only called by
virtio_i2c_xfer, thus we don't
have reqs[i] to be NULL. But I think "virtio_i2c_complete_reqs" as an
independent function
should consider this from a callee perspective.
Anyway, if you really think it should be changed, it can be fixed
incrementally as Wolfram said.
prev parent reply other threads:[~2021-07-05 7:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 8:46 [PATCH v12] i2c: virtio: add a virtio i2c frontend driver Jie Deng
2021-07-02 9:58 ` Andy Shevchenko
2021-07-02 23:01 ` Wolfram Sang
2021-07-05 2:43 ` Viresh Kumar
2021-07-05 3:01 ` Jie Deng
2021-07-05 6:21 ` Jie Deng
2021-07-05 6:31 ` Viresh Kumar
2021-07-05 3:46 ` Jie Deng
2021-07-05 2:40 ` Viresh Kumar
2021-07-05 3:45 ` Jie Deng
2021-07-05 4:38 ` Viresh Kumar
2021-07-05 6:22 ` Jie Deng
2021-07-05 6:30 ` Viresh Kumar
2021-07-05 7:13 ` Jie Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=273be5a6-c45f-8f12-361f-65caf0c3d08b@intel.com \
--to=jie.deng@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=conghui.chen@intel.com \
--cc=jasowang@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=shuo.a.liu@intel.com \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).