reiserfs problem on SMP

reiserfs problem on SMP

[Jeff Chua]

Got the following journaling error on 2.4.5 SMP during shutdown ...

....

Unmounting local file systems.
journal_begin called without kernel lock held
kernel BUG at journal.c:423!
invalid operand: 0000
CPU1:   1
EIP:    0010:[<f8854140>]
EFLAGS: 00010286
eax: 0000001d   ebx: f0951f2c   ecx: 00000001   edx: 00000001
esi: c3d26000   edi: f0951f2c   ebp: 0000000a   esp: f0951ec4
ds: 0018    es: 0018  ss: 0018
Process umount (pid: 265, stackpage=f0951000)

...

This bug only shows up on my SMP (2CPU) machine. It's been running fine on
1CPU non-smp machines.


Here's the difference for compiling ...

boston:root:/u2/src/linux> diff .config /root/src2/.config-2.4.5
54,55c54,55
< # CONFIG_NOHIGHMEM is not set
< CONFIG_HIGHMEM4G=y
---
> CONFIG_NOHIGHMEM=y
> # CONFIG_HIGHMEM4G is not set
57d56
< CONFIG_HIGHMEM=y
60,61c59,60
< CONFIG_SMP=y
< CONFIG_HAVE_DEC_LOCK=y
---
> # CONFIG_SMP is not set
> # CONFIG_X86_UP_IOAPIC is not set
68,69d66
< CONFIG_X86_IO_APIC=y
< CONFIG_X86_LOCAL_APIC=y



Thanks,
Jeff
[ jchua@fedex.com ]

Re: reiserfs problem on SMP

[Chris Mason]

On Tuesday, June 12, 2001 05:25:46 PM +0800 Jeff Chua <jeffchua@silk.corp.fedex.com> wrote:

> 
> Got the following journaling error on 2.4.5 SMP during shutdown ...
> 

Known 2.4.5 problem.  Fix below is from Al Viro:

-chris

diff -Nru a/fs/super.c b/fs/super.c
--- a/fs/super.c	Sat Jun  2 13:27:07 2001
+++ b/fs/super.c	Sat Jun  2 13:27:07 2001
@@ -873,6 +873,7 @@
 	}
 	spin_unlock(&dcache_lock);
 	down_write(&sb->s_umount);
+	lock_kernel();
 	sb->s_root = NULL;
 	/* Need to clean after the sucker */
 	if (fs->fs_flags & FS_LITTER)
@@ -901,6 +902,7 @@
 	put_filesystem(fs);
 	sb->s_type = NULL;
 	unlock_super(sb);
+	unlock_kernel();
 	up_write(&sb->s_umount);
 	if (bdev) {
 		blkdev_put(bdev, BDEV_FS);