* [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings
@ 2015-02-05 13:16 Lad Prabhakar
2015-02-05 15:06 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Lad Prabhakar @ 2015-02-05 13:16 UTC (permalink / raw)
To: Laurent Pinchart, Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warnings:
uvc_v4l2.c:264:29: warning: symbol 'uvc_v4l2_ioctl_ops' was not declared. Should it be static?
uvc_v4l2.c:355:29: warning: symbol 'uvc_v4l2_fops' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/usb/gadget/function/uvc_v4l2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/uvc_v4l2.c b/drivers/usb/gadget/function/uvc_v4l2.c
index 5aad7fe..8b818fd 100644
--- a/drivers/usb/gadget/function/uvc_v4l2.c
+++ b/drivers/usb/gadget/function/uvc_v4l2.c
@@ -27,6 +27,7 @@
#include "uvc.h"
#include "uvc_queue.h"
#include "uvc_video.h"
+#include "uvc_v4l2.h"
/* --------------------------------------------------------------------------
* Requests handling
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings
2015-02-05 13:16 [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings Lad Prabhakar
@ 2015-02-05 15:06 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2015-02-05 15:06 UTC (permalink / raw)
To: Lad Prabhakar; +Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel
Hi Prabhakar,
Thank you for the patch.
On Thursday 05 February 2015 13:16:26 Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warnings:
>
> uvc_v4l2.c:264:29: warning: symbol 'uvc_v4l2_ioctl_ops' was not declared.
> Should it be static? uvc_v4l2.c:355:29: warning: symbol 'uvc_v4l2_fops' was
> not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Felipe, could you please take this in your tree ?
> ---
> drivers/usb/gadget/function/uvc_v4l2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/gadget/function/uvc_v4l2.c
> b/drivers/usb/gadget/function/uvc_v4l2.c index 5aad7fe..8b818fd 100644
> --- a/drivers/usb/gadget/function/uvc_v4l2.c
> +++ b/drivers/usb/gadget/function/uvc_v4l2.c
> @@ -27,6 +27,7 @@
> #include "uvc.h"
> #include "uvc_queue.h"
> #include "uvc_video.h"
> +#include "uvc_v4l2.h"
>
> /* -------------------------------------------------------------------------
> * Requests handling
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-05 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 13:16 [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings Lad Prabhakar
2015-02-05 15:06 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).