linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, kishon@ti.com, vkoul@kernel.org
Cc: robh+dt@kernel.org, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188
Date: Sun, 17 Oct 2021 23:45:57 +0200	[thread overview]
Message-ID: <2801784.XqmsWqfj7A@phil> (raw)
In-Reply-To: <20210828111218.10026-1-jbx6244@gmail.com>

Hi Vinod, Kishon,

Am Samstag, 28. August 2021, 13:12:17 CEST schrieb Johan Jonker:
> With the conversion of rockchip-usb-phy.yaml a long time used fallback
> string for rk3066a/rk3188 was added. The linux driver doesn't do much with
> the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c
> does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example
> don't match. Remove the usb-phy fallback string for rk3066a/rk3188
> to prevent possible strange side effects.
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

are you picking up this patch or can I get an Ack to just apply it
together with the dts patch2?

Thanks
Heiko

> ---
>  .../devicetree/bindings/phy/rockchip-usb-phy.yaml     | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml
> index f0fc8275d..499d55131 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml
> @@ -11,13 +11,10 @@ maintainers:
>  
>  properties:
>    compatible:
> -    oneOf:
> -      - const: rockchip,rk3288-usb-phy
> -      - items:
> -          - enum:
> -              - rockchip,rk3066a-usb-phy
> -              - rockchip,rk3188-usb-phy
> -          - const: rockchip,rk3288-usb-phy
> +    enum:
> +      - rockchip,rk3066a-usb-phy
> +      - rockchip,rk3188-usb-phy
> +      - rockchip,rk3288-usb-phy
>  
>    "#address-cells":
>      const: 1
> 





  parent reply	other threads:[~2021-10-17 21:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28 11:12 [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188 Johan Jonker
2021-08-28 11:12 ` [PATCH 2/2] ARM: dts: " Johan Jonker
2021-08-31 21:33 ` [PATCH 1/2] dt-bindings: phy: " Rob Herring
2021-10-17 21:45 ` Heiko Stuebner [this message]
2021-10-19 18:02 ` Vinod Koul
2021-10-20  7:45 ` (subset) " Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2801784.XqmsWqfj7A@phil \
    --to=heiko@sntech.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jbx6244@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).