* [PATCH 2/2] ARM: dts: rockchip: remove usb-phy fallback string for rk3066a/rk3188
2021-08-28 11:12 [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188 Johan Jonker
@ 2021-08-28 11:12 ` Johan Jonker
2021-08-31 21:33 ` [PATCH 1/2] dt-bindings: phy: " Rob Herring
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Johan Jonker @ 2021-08-28 11:12 UTC (permalink / raw)
To: heiko
Cc: robh+dt, kishon, vkoul, linux-phy, linux-arm-kernel,
linux-rockchip, devicetree, linux-kernel
With the conversion of rockchip-usb-phy.yaml a long time used fallback
string for rk3066a/rk3188 was added. The linux driver doesn't do much with
the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c
does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example
don't match. Remove the usb-phy fallback string for rk3066a/rk3188
to prevent possible strange side effects.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
arch/arm/boot/dts/rk3066a.dtsi | 3 +--
arch/arm/boot/dts/rk3188.dtsi | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi
index cc701a4e0..10392e096 100644
--- a/arch/arm/boot/dts/rk3066a.dtsi
+++ b/arch/arm/boot/dts/rk3066a.dtsi
@@ -681,8 +681,7 @@
compatible = "rockchip,rk3066-grf", "syscon", "simple-mfd";
usbphy: usbphy {
- compatible = "rockchip,rk3066a-usb-phy",
- "rockchip,rk3288-usb-phy";
+ compatible = "rockchip,rk3066a-usb-phy";
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts/rk3188.dtsi
index d6a946a2a..922290892 100644
--- a/arch/arm/boot/dts/rk3188.dtsi
+++ b/arch/arm/boot/dts/rk3188.dtsi
@@ -647,8 +647,7 @@
};
usbphy: usbphy {
- compatible = "rockchip,rk3188-usb-phy",
- "rockchip,rk3288-usb-phy";
+ compatible = "rockchip,rk3188-usb-phy";
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188
2021-08-28 11:12 [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188 Johan Jonker
2021-08-28 11:12 ` [PATCH 2/2] ARM: dts: " Johan Jonker
@ 2021-08-31 21:33 ` Rob Herring
2021-10-17 21:45 ` Heiko Stuebner
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-08-31 21:33 UTC (permalink / raw)
To: Johan Jonker
Cc: linux-phy, heiko, linux-kernel, linux-arm-kernel, robh+dt,
devicetree, vkoul, kishon, linux-rockchip
On Sat, 28 Aug 2021 13:12:17 +0200, Johan Jonker wrote:
> With the conversion of rockchip-usb-phy.yaml a long time used fallback
> string for rk3066a/rk3188 was added. The linux driver doesn't do much with
> the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c
> does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example
> don't match. Remove the usb-phy fallback string for rk3066a/rk3188
> to prevent possible strange side effects.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188
2021-08-28 11:12 [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188 Johan Jonker
2021-08-28 11:12 ` [PATCH 2/2] ARM: dts: " Johan Jonker
2021-08-31 21:33 ` [PATCH 1/2] dt-bindings: phy: " Rob Herring
@ 2021-10-17 21:45 ` Heiko Stuebner
2021-10-19 18:02 ` Vinod Koul
2021-10-20 7:45 ` (subset) " Heiko Stuebner
4 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-10-17 21:45 UTC (permalink / raw)
To: Johan Jonker, kishon, vkoul
Cc: robh+dt, linux-phy, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Hi Vinod, Kishon,
Am Samstag, 28. August 2021, 13:12:17 CEST schrieb Johan Jonker:
> With the conversion of rockchip-usb-phy.yaml a long time used fallback
> string for rk3066a/rk3188 was added. The linux driver doesn't do much with
> the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c
> does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example
> don't match. Remove the usb-phy fallback string for rk3066a/rk3188
> to prevent possible strange side effects.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
are you picking up this patch or can I get an Ack to just apply it
together with the dts patch2?
Thanks
Heiko
> ---
> .../devicetree/bindings/phy/rockchip-usb-phy.yaml | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml
> index f0fc8275d..499d55131 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip-usb-phy.yaml
> @@ -11,13 +11,10 @@ maintainers:
>
> properties:
> compatible:
> - oneOf:
> - - const: rockchip,rk3288-usb-phy
> - - items:
> - - enum:
> - - rockchip,rk3066a-usb-phy
> - - rockchip,rk3188-usb-phy
> - - const: rockchip,rk3288-usb-phy
> + enum:
> + - rockchip,rk3066a-usb-phy
> + - rockchip,rk3188-usb-phy
> + - rockchip,rk3288-usb-phy
>
> "#address-cells":
> const: 1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188
2021-08-28 11:12 [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188 Johan Jonker
` (2 preceding siblings ...)
2021-10-17 21:45 ` Heiko Stuebner
@ 2021-10-19 18:02 ` Vinod Koul
2021-10-20 7:45 ` (subset) " Heiko Stuebner
4 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2021-10-19 18:02 UTC (permalink / raw)
To: Johan Jonker
Cc: heiko, robh+dt, kishon, linux-phy, linux-arm-kernel,
linux-rockchip, devicetree, linux-kernel
On 28-08-21, 13:12, Johan Jonker wrote:
> With the conversion of rockchip-usb-phy.yaml a long time used fallback
> string for rk3066a/rk3188 was added. The linux driver doesn't do much with
> the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c
> does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example
> don't match. Remove the usb-phy fallback string for rk3066a/rk3188
> to prevent possible strange side effects.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188
2021-08-28 11:12 [PATCH 1/2] dt-bindings: phy: rockchip: remove usb-phy fallback string for rk3066a/rk3188 Johan Jonker
` (3 preceding siblings ...)
2021-10-19 18:02 ` Vinod Koul
@ 2021-10-20 7:45 ` Heiko Stuebner
4 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-10-20 7:45 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, linux-arm-kernel, linux-phy, devicetree,
linux-rockchip, linux-kernel, robh+dt, vkoul, kishon
On Sat, 28 Aug 2021 13:12:17 +0200, Johan Jonker wrote:
> With the conversion of rockchip-usb-phy.yaml a long time used fallback
> string for rk3066a/rk3188 was added. The linux driver doesn't do much with
> the GRF phy address range, however the u-boot driver rockchip_usb2_phy.c
> does. The bits in GRF_UOC0_CON2 for rk3066a/rk3188 and rk3288 for example
> don't match. Remove the usb-phy fallback string for rk3066a/rk3188
> to prevent possible strange side effects.
Applied, thanks!
[2/2] ARM: dts: rockchip: remove usb-phy fallback string for rk3066a/rk3188
commit: 97ef6931208f7ab09f52dd291320aa53878aaa53
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread