* [PATCH] kernel/trace/trace_kprobe.c - fix comment format
@ 2019-03-12 8:58 Valdis Klētnieks
2019-03-12 15:01 ` Steven Rostedt
[not found] ` <3692.1552381710@turing-police>
0 siblings, 2 replies; 5+ messages in thread
From: Valdis Klētnieks @ 2019-03-12 8:58 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar; +Cc: linux-kernel
CC kernel/trace/trace_kprobe.o
kernel/trace/trace_kprobe.c:41: warning: cannot understand function prototype: 'struct trace_kprobe '
The real problem is that a comment looked like kerneldoc when it shouldn't be...
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 9eaf07f99212..c825c591553a 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -35,7 +35,7 @@ static struct dyn_event_operations trace_kprobe_ops = {
.match = trace_kprobe_match,
};
-/**
+/*
* Kprobe event core functions
*/
struct trace_kprobe {
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format
2019-03-12 8:58 [PATCH] kernel/trace/trace_kprobe.c - fix comment format Valdis Klētnieks
@ 2019-03-12 15:01 ` Steven Rostedt
2019-03-12 15:14 ` Randy Dunlap
[not found] ` <3692.1552381710@turing-police>
1 sibling, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2019-03-12 15:01 UTC (permalink / raw)
To: Valdis Klētnieks; +Cc: Ingo Molnar, linux-kernel
On Tue, 12 Mar 2019 04:58:32 -0400
"Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:
> CC kernel/trace/trace_kprobe.o
> kernel/trace/trace_kprobe.c:41: warning: cannot understand function prototype: 'struct trace_kprobe '
>
> The real problem is that a comment looked like kerneldoc when it shouldn't be...
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index 9eaf07f99212..c825c591553a 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -35,7 +35,7 @@ static struct dyn_event_operations trace_kprobe_ops = {
> .match = trace_kprobe_match,
> };
>
> -/**
> +/*
NACK.
This isn't a kernel doc comment, and I don't want to make it one when
it is not. Just ignore that warning.
-- Steve
> * Kprobe event core functions
> */
> struct trace_kprobe {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format
2019-03-12 15:01 ` Steven Rostedt
@ 2019-03-12 15:14 ` Randy Dunlap
2019-03-12 15:22 ` Steven Rostedt
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2019-03-12 15:14 UTC (permalink / raw)
To: Steven Rostedt, Valdis Klētnieks; +Cc: Ingo Molnar, linux-kernel
On 3/12/19 8:01 AM, Steven Rostedt wrote:
> On Tue, 12 Mar 2019 04:58:32 -0400
> "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:
>
>> CC kernel/trace/trace_kprobe.o
>> kernel/trace/trace_kprobe.c:41: warning: cannot understand function prototype: 'struct trace_kprobe '
>>
>> The real problem is that a comment looked like kerneldoc when it shouldn't be...
>>
>> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>>
>> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
>> index 9eaf07f99212..c825c591553a 100644
>> --- a/kernel/trace/trace_kprobe.c
>> +++ b/kernel/trace/trace_kprobe.c
>> @@ -35,7 +35,7 @@ static struct dyn_event_operations trace_kprobe_ops = {
>> .match = trace_kprobe_match,
>> };
>>
>> -/**
>> +/*
>
> NACK.
>
> This isn't a kernel doc comment, and I don't want to make it one when
> it is not. Just ignore that warning.
>
> -- Steve
Huh? The patch doesn't do that -- it does the opposite of that.
I.e., begin a non-kernel-doc comment with /* instead of /**.
>
>> * Kprobe event core functions
>> */
>> struct trace_kprobe {
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format
2019-03-12 15:14 ` Randy Dunlap
@ 2019-03-12 15:22 ` Steven Rostedt
0 siblings, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2019-03-12 15:22 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Valdis Klētnieks, Ingo Molnar, linux-kernel
On Tue, 12 Mar 2019 08:14:52 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> > NACK.
> >
> > This isn't a kernel doc comment, and I don't want to make it one when
> > it is not. Just ignore that warning.
> >
> > -- Steve
>
> Huh? The patch doesn't do that -- it does the opposite of that.
> I.e., begin a non-kernel-doc comment with /* instead of /**.
Ah, my head swapped the "-" to the "+". I thought the patch
was adding the extra '*'. Nevermind, I'll take it.
Thanks for pointing that out.
Also, I'll change the subject to:
trace/probes: Remove kernel doc style from non kernel doc comment
-- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/trace/trace_kprobe.c - fix comment format
[not found] ` <3692.1552381710@turing-police>
@ 2019-03-12 15:23 ` Steven Rostedt
0 siblings, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2019-03-12 15:23 UTC (permalink / raw)
To: valdis.kletnieks; +Cc: Ingo Molnar, linux-kernel
On Tue, 12 Mar 2019 05:08:30 -0400
valdis.kletnieks@vt.edu wrote:
> On Tue, 12 Mar 2019 04:58:32 -0400, "Valdis Klētnieks" said:
> >
> > CC kernel/trace/trace_kprobe.o
> > kernel/trace/trace_kprobe.c:41: warning: cannot understand function prototype: 'struct trace_kprobe '
> >
> > The real problem is that a comment looked like kerneldoc when it shouldn't be...
>
> After finding another case of this, it's debatable whether the *REAL* real
> problem is that gcc is buggy/incomplete and doesn't know that kerneldoc
> comments can be applied to structure definitions as well....
>
> What's the consensus? Should I go yell at the gcc people instead, or?
Nevermind, I mistook your patch as adding a kernel doc comment.
It's fine, I'll take it.
Thanks!
-- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-12 15:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 8:58 [PATCH] kernel/trace/trace_kprobe.c - fix comment format Valdis Klētnieks
2019-03-12 15:01 ` Steven Rostedt
2019-03-12 15:14 ` Randy Dunlap
2019-03-12 15:22 ` Steven Rostedt
[not found] ` <3692.1552381710@turing-police>
2019-03-12 15:23 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).