linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org
Subject: Re: [PATCH 2/5] regulator: fan53555: set regulator name from constraints name
Date: Tue, 16 Sep 2014 00:08:12 +0200	[thread overview]
Message-ID: <2905334.044J8r4kOu@diego> (raw)
In-Reply-To: <20140915165923.GX7960@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Am Montag, 15. September 2014, 09:59:23 schrieb Mark Brown:
> On Sun, Sep 14, 2014 at 09:23:02PM +0200, Heiko Stuebner wrote:
> > There is a high potential of more than one of those regulators existing
> > on a board, so name the regulator according to the name provided in the
> > initdata instead of statically.
> 
> No, this is pointless and broken.  The core will already use the
> board-specific name to identify the regulator in diagnostics and so on,
> the name being supplied here is supposed to describe the regulator
> within the device.

ok, sorry for the mess-up

I've just tested, patches 3-5 apply and work correctly without this one, so do 
you want to apply them like this or a resend of last 3?


Heiko

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2014-09-15 22:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-14 19:23 [PATCH 0/5] regulator: add support for syr82x to fan53555 Heiko Stuebner
2014-09-14 19:23 ` [PATCH 1/5] regulator: fan53555: enable vin supply Heiko Stuebner
2014-09-15 21:49   ` Mark Brown
2014-09-14 19:23 ` [PATCH 2/5] regulator: fan53555: set regulator name from constraints name Heiko Stuebner
2014-09-15 16:59   ` Mark Brown
2014-09-15 22:08     ` Heiko Stübner [this message]
2014-09-15 22:36       ` Mark Brown
2014-09-14 19:23 ` [PATCH 3/5] dt-bindings: add devicetree bindings for Fairchild FAN53555 regulators Heiko Stuebner
2014-09-15 21:54   ` Mark Brown
2014-09-15 22:14     ` Heiko Stübner
2014-09-15 22:25       ` Mark Brown
2014-09-14 19:23 ` [PATCH 4/5] regulator: fan53555: add devicetree support Heiko Stuebner
2014-09-14 19:23 ` [PATCH 5/5] regulator: fan53555: add support for Silergy SYR82x regulators Heiko Stuebner
2014-09-15 22:27   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2905334.044J8r4kOu@diego \
    --to=heiko@sntech.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).