* [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel
2016-06-28 4:48 [PATCH v1 0/5] Enable graphic support on RK3288 EVB boards Yakir Yang
@ 2016-06-28 4:51 ` Yakir Yang
2016-06-28 20:59 ` Rob Herring
2016-07-07 21:52 ` Thierry Reding
2016-06-28 4:51 ` [PATCH v1 2/5] drm/panel: simple: " Yakir Yang
` (3 subsequent siblings)
4 siblings, 2 replies; 13+ messages in thread
From: Yakir Yang @ 2016-06-28 4:51 UTC (permalink / raw)
To: Thierry Reding, Heiko Stuebner, Rob Herring
Cc: Kumar Gala, Ian Campbell, David Airlie, Russell King, devicetree,
dri-devel, linux-kernel, linux-arm-kernel, linux-rockchip,
Yakir Yang
The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and
32 pins eDP interface. This module supports 1536x2048 mode.
Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
.../devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt | 7 +++++++
1 file changed, 7 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt
diff --git a/Documentation/devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt b/Documentation/devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt
new file mode 100644
index 0000000..b9877ac
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt
@@ -0,0 +1,7 @@
+LG LP079QX1-SP0V 7.9" (1536x2048 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "lg,lp079qx1-sp0v"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel
2016-06-28 4:51 ` [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel Yakir Yang
@ 2016-06-28 20:59 ` Rob Herring
2016-06-29 3:31 ` Yakir Yang
2016-07-07 21:52 ` Thierry Reding
1 sibling, 1 reply; 13+ messages in thread
From: Rob Herring @ 2016-06-28 20:59 UTC (permalink / raw)
To: Yakir Yang
Cc: Thierry Reding, Heiko Stuebner, Kumar Gala, Ian Campbell,
David Airlie, Russell King, devicetree, dri-devel, linux-kernel,
linux-arm-kernel, linux-rockchip
On Tue, Jun 28, 2016 at 12:51:12PM +0800, Yakir Yang wrote:
> The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and
> 32 pins eDP interface. This module supports 1536x2048 mode.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> .../devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel
2016-06-28 20:59 ` Rob Herring
@ 2016-06-29 3:31 ` Yakir Yang
0 siblings, 0 replies; 13+ messages in thread
From: Yakir Yang @ 2016-06-29 3:31 UTC (permalink / raw)
To: Rob Herring
Cc: Thierry Reding, Heiko Stuebner, Kumar Gala, Ian Campbell,
David Airlie, Russell King, devicetree, dri-devel, linux-kernel,
linux-arm-kernel, linux-rockchip
Rob,
On 06/29/2016 04:59 AM, Rob Herring wrote:
> On Tue, Jun 28, 2016 at 12:51:12PM +0800, Yakir Yang wrote:
>> The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and
>> 32 pins eDP interface. This module supports 1536x2048 mode.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> .../devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt | 7 +++++++
>> 1 file changed, 7 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt
> Acked-by: Rob Herring <robh@kernel.org>
>
Thanks for your fast respond ;)
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel
2016-06-28 4:51 ` [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel Yakir Yang
2016-06-28 20:59 ` Rob Herring
@ 2016-07-07 21:52 ` Thierry Reding
1 sibling, 0 replies; 13+ messages in thread
From: Thierry Reding @ 2016-07-07 21:52 UTC (permalink / raw)
To: Yakir Yang
Cc: Heiko Stuebner, Rob Herring, Kumar Gala, Ian Campbell,
David Airlie, Russell King, devicetree, dri-devel, linux-kernel,
linux-arm-kernel, linux-rockchip
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On Tue, Jun 28, 2016 at 12:51:12PM +0800, Yakir Yang wrote:
> The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and
> 32 pins eDP interface. This module supports 1536x2048 mode.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> .../devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp079qx1-sp0v.txt
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 2/5] drm/panel: simple: Add support for LG LP079QX1-SP0V 1536x2048 panel
2016-06-28 4:48 [PATCH v1 0/5] Enable graphic support on RK3288 EVB boards Yakir Yang
2016-06-28 4:51 ` [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel Yakir Yang
@ 2016-06-28 4:51 ` Yakir Yang
2016-07-07 21:52 ` Thierry Reding
2016-06-28 4:51 ` [PATCH v1 3/5] ARM: dts: rockchip: add eDP/panel display device nodes for rk3288-evb Yakir Yang
` (2 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Yakir Yang @ 2016-06-28 4:51 UTC (permalink / raw)
To: Thierry Reding, Heiko Stuebner, Rob Herring
Cc: Kumar Gala, Ian Campbell, David Airlie, Russell King, devicetree,
dri-devel, linux-kernel, linux-arm-kernel, linux-rockchip,
Yakir Yang
The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and
32 pins eDP interface. This module supports 1536x2048 mode.
Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3a7bdf1..072c994 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1017,6 +1017,29 @@ static const struct panel_desc lg_lb070wv8 = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
};
+static const struct drm_display_mode lg_lp079qx1_sp0v_mode = {
+ .clock = 200000,
+ .hdisplay = 1536,
+ .hsync_start = 1536 + 12,
+ .hsync_end = 1536 + 12 + 16,
+ .htotal = 1536 + 12 + 16 + 48,
+ .vdisplay = 2048,
+ .vsync_start = 2048 + 8,
+ .vsync_end = 2048 + 8 + 4,
+ .vtotal = 2048 + 8 + 4 + 8,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc lg_lp079qx1_sp0v = {
+ .modes = &lg_lp079qx1_sp0v_mode,
+ .num_modes = 1,
+ .size = {
+ .width = 129,
+ .height = 171,
+ },
+};
+
static const struct drm_display_mode lg_lp120up1_mode = {
.clock = 162300,
.hdisplay = 1920,
@@ -1457,6 +1480,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "lg,lb070wv8",
.data = &lg_lb070wv8,
}, {
+ .compatible = "lg,lp079qx1-sp0v",
+ .data = &lg_lp079qx1_sp0v,
+ }, {
.compatible = "lg,lp120up1",
.data = &lg_lp120up1,
}, {
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v1 2/5] drm/panel: simple: Add support for LG LP079QX1-SP0V 1536x2048 panel
2016-06-28 4:51 ` [PATCH v1 2/5] drm/panel: simple: " Yakir Yang
@ 2016-07-07 21:52 ` Thierry Reding
0 siblings, 0 replies; 13+ messages in thread
From: Thierry Reding @ 2016-07-07 21:52 UTC (permalink / raw)
To: Yakir Yang
Cc: Heiko Stuebner, Rob Herring, Kumar Gala, Ian Campbell,
David Airlie, Russell King, devicetree, dri-devel, linux-kernel,
linux-arm-kernel, linux-rockchip
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Tue, Jun 28, 2016 at 12:51:15PM +0800, Yakir Yang wrote:
> The LG LP079QX1-SP0V is an 7.9" QXGA TFT with LED Backlight unit and
> 32 pins eDP interface. This module supports 1536x2048 mode.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 3/5] ARM: dts: rockchip: add eDP/panel display device nodes for rk3288-evb
2016-06-28 4:48 [PATCH v1 0/5] Enable graphic support on RK3288 EVB boards Yakir Yang
2016-06-28 4:51 ` [PATCH v1 1/5] dt-bindings: Add support for LG LP079QX1-SP0V 1536x2048 panel Yakir Yang
2016-06-28 4:51 ` [PATCH v1 2/5] drm/panel: simple: " Yakir Yang
@ 2016-06-28 4:51 ` Yakir Yang
2016-07-07 22:31 ` Heiko Stuebner
2016-06-28 4:51 ` [PATCH v1 4/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with act8846 pmu Yakir Yang
2016-06-28 4:51 ` [PATCH v1 5/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with rk808 pmu Yakir Yang
4 siblings, 1 reply; 13+ messages in thread
From: Yakir Yang @ 2016-06-28 4:51 UTC (permalink / raw)
To: Thierry Reding, Heiko Stuebner, Rob Herring
Cc: Kumar Gala, Ian Campbell, David Airlie, Russell King, devicetree,
dri-devel, linux-kernel, linux-arm-kernel, linux-rockchip,
Yakir Yang
The default eDP panel on RK3288 EVB board is LG LP079QX1-SP0V TFT LCD,
we haven't declared the panel regulator in the 'panel-simple' device
node here, so the specific board like ACT8846 / RK8080 need to support
the panel power supply.
Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
arch/arm/boot/dts/rk3288-evb.dtsi | 43 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi
index 963365d..f293c44 100644
--- a/arch/arm/boot/dts/rk3288-evb.dtsi
+++ b/arch/arm/boot/dts/rk3288-evb.dtsi
@@ -48,7 +48,7 @@
reg = <0x0 0x80000000>;
};
- backlight {
+ backlight: backlight {
compatible = "pwm-backlight";
brightness-levels = <
0 1 2 3 4 5 6 7
@@ -97,6 +97,20 @@
#clock-cells = <0>;
};
+ panel: panel {
+ compatible ="lg,lp079qx1-sp0v", "simple-panel";
+ backlight = <&backlight>;
+ enable-gpios = <&gpio7 4 GPIO_ACTIVE_HIGH>;
+ pinctrl-0 = <&lcd_cs>;
+ ports {
+ panel_in: port {
+ panel_in_edp: endpoint {
+ remote-endpoint = <&edp_out_panel>;
+ };
+ };
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";
autorepeat;
@@ -216,6 +230,27 @@
status = "okay";
};
+&edp_phy {
+ status = "okay";
+};
+
+&edp {
+ force-hpd;
+ status = "okay";
+
+ ports {
+ edp_out: port@1 {
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ edp_out_panel: endpoint {
+ reg = <0>;
+ remote-endpoint = <&panel_in_edp>;
+ };
+ };
+ };
+};
+
&i2c0 {
status = "okay";
};
@@ -322,6 +357,12 @@
rockchip,pins = <0 6 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
+
+ lcd {
+ lcd_cs: lcd-cs {
+ rockchip,pins = <7 4 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
};
&usbphy {
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v1 3/5] ARM: dts: rockchip: add eDP/panel display device nodes for rk3288-evb
2016-06-28 4:51 ` [PATCH v1 3/5] ARM: dts: rockchip: add eDP/panel display device nodes for rk3288-evb Yakir Yang
@ 2016-07-07 22:31 ` Heiko Stuebner
0 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2016-07-07 22:31 UTC (permalink / raw)
To: Yakir Yang
Cc: Thierry Reding, Rob Herring, Kumar Gala, Ian Campbell,
David Airlie, Russell King, devicetree, dri-devel, linux-kernel,
linux-arm-kernel, linux-rockchip
Am Dienstag, 28. Juni 2016, 12:51:18 schrieb Yakir Yang:
> The default eDP panel on RK3288 EVB board is LG LP079QX1-SP0V TFT LCD,
> we haven't declared the panel regulator in the 'panel-simple' device
> node here, so the specific board like ACT8846 / RK8080 need to support
> the panel power supply.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
applied, after reordering the entries to keep our alphabetical sorting.
Heiko
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 4/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with act8846 pmu
2016-06-28 4:48 [PATCH v1 0/5] Enable graphic support on RK3288 EVB boards Yakir Yang
` (2 preceding siblings ...)
2016-06-28 4:51 ` [PATCH v1 3/5] ARM: dts: rockchip: add eDP/panel display device nodes for rk3288-evb Yakir Yang
@ 2016-06-28 4:51 ` Yakir Yang
2016-07-07 22:31 ` Heiko Stuebner
2016-06-28 4:51 ` [PATCH v1 5/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with rk808 pmu Yakir Yang
4 siblings, 1 reply; 13+ messages in thread
From: Yakir Yang @ 2016-06-28 4:51 UTC (permalink / raw)
To: Thierry Reding, Heiko Stuebner, Rob Herring
Cc: Kumar Gala, Ian Campbell, David Airlie, Russell King, devicetree,
dri-devel, linux-kernel, linux-arm-kernel, linux-rockchip,
Yakir Yang
Panel regulator is controller by a normal GPIO, so we need to
write a regulator-fixed node for it.
Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
arch/arm/boot/dts/rk3288-evb-act8846.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts b/arch/arm/boot/dts/rk3288-evb-act8846.dts
index 452ca24..041dd5d 100644
--- a/arch/arm/boot/dts/rk3288-evb-act8846.dts
+++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts
@@ -206,6 +206,10 @@
};
};
+&panel {
+ power-supply = <&vcc_lcd>;
+};
+
&pinctrl {
lcd {
lcd_en: lcd-en {
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v1 4/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with act8846 pmu
2016-06-28 4:51 ` [PATCH v1 4/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with act8846 pmu Yakir Yang
@ 2016-07-07 22:31 ` Heiko Stuebner
0 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2016-07-07 22:31 UTC (permalink / raw)
To: Yakir Yang
Cc: Thierry Reding, Rob Herring, Kumar Gala, Ian Campbell,
David Airlie, Russell King, devicetree, dri-devel, linux-kernel,
linux-arm-kernel, linux-rockchip
Am Dienstag, 28. Juni 2016, 12:51:21 schrieb Yakir Yang:
> Panel regulator is controller by a normal GPIO, so we need to
> write a regulator-fixed node for it.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
applied, thanks.
Heiko
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 5/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with rk808 pmu
2016-06-28 4:48 [PATCH v1 0/5] Enable graphic support on RK3288 EVB boards Yakir Yang
` (3 preceding siblings ...)
2016-06-28 4:51 ` [PATCH v1 4/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with act8846 pmu Yakir Yang
@ 2016-06-28 4:51 ` Yakir Yang
2016-07-07 22:35 ` Heiko Stuebner
4 siblings, 1 reply; 13+ messages in thread
From: Yakir Yang @ 2016-06-28 4:51 UTC (permalink / raw)
To: Thierry Reding, Heiko Stuebner, Rob Herring
Cc: Kumar Gala, Ian Campbell, David Airlie, Russell King, devicetree,
dri-devel, linux-kernel, linux-arm-kernel, linux-rockchip,
Yakir Yang
Panel regulator is controller by a normal GPIO, so we need to
write a regulator-fixed node for it.
Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
arch/arm/boot/dts/rk3288-evb-rk808.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts
index 736b08b..44ebc6e 100644
--- a/arch/arm/boot/dts/rk3288-evb-rk808.dts
+++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts
@@ -233,3 +233,7 @@
};
};
};
+
+&panel {
+ power-supply = <&vcc_lcd>;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v1 5/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with rk808 pmu
2016-06-28 4:51 ` [PATCH v1 5/5] ARM: dts: rockchip: add the panel power supply for rk3288-evb board with rk808 pmu Yakir Yang
@ 2016-07-07 22:35 ` Heiko Stuebner
0 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2016-07-07 22:35 UTC (permalink / raw)
To: Yakir Yang
Cc: Thierry Reding, Rob Herring, Kumar Gala, Ian Campbell,
David Airlie, Russell King, devicetree, dri-devel, linux-kernel,
linux-arm-kernel, linux-rockchip
Am Dienstag, 28. Juni 2016, 12:51:24 schrieb Yakir Yang:
> Panel regulator is controller by a normal GPIO, so we need to
> write a regulator-fixed node for it.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
applied after rewording the commit message a bit.
On the rk808-evb vcc_lcd comes from the rk808 directly and not through some
gpio regulator :-) .
Heiko
^ permalink raw reply [flat|nested] 13+ messages in thread