From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: seanjc@google.com
Subject: Re: [PATCH v3 00/22] https://www.spinics.net/lists/kvm/msg267878.html
Date: Thu, 14 Apr 2022 09:47:31 +0200 [thread overview]
Message-ID: <2939c0cb-8e0c-7de4-7143-2df303bbb542@redhat.com> (raw)
In-Reply-To: <20220414074000.31438-1-pbonzini@redhat.com>
Uh-oh, wrong subject. Should be "KVM MMU refactoring part 2: role changes".
Supersedes: <20220221162243.683208-1-pbonzini@redhat.com>
Paolo
On 4/14/22 09:39, Paolo Bonzini wrote:
> Right now the "MMU role" is a messy mix of the shadow page table format
> and the CPU paging mode (CR0/CR4/EFER, SMM, guest mode, etc). Whenever
> something is different between the MMU and the CPU, it is stored as an
> extra field in struct kvm_mmu; for extra bonus complication, sometimes
> the same thing is stored in both the role and an extra field.
>
> This series cleans up things by putting the two in separate fields,
> so that the "MMU role" represents exactly the role of the root page.
> This in turn makes it possible to eliminate various fields that are
> now redundant with either the CPU or te MMU role.
>
> These patches have mostly been posted and reviewed already[1], and I
> have now retested them on top of kvm/next.
>
> Paolo
>
> [1] https://patchew.org/linux/20220221162243.683208-1-pbonzini@redhat.com/
>
> Paolo Bonzini (21):
> KVM: x86/mmu: nested EPT cannot be used in SMM
> KVM: x86/mmu: constify uses of struct kvm_mmu_role_regs
> KVM: x86/mmu: pull computation of kvm_mmu_role_regs to kvm_init_mmu
> KVM: x86/mmu: rephrase unclear comment
> KVM: x86/mmu: remove "bool base_only" arguments
> KVM: x86/mmu: split cpu_role from mmu_role
> KVM: x86/mmu: do not recompute root level from kvm_mmu_role_regs
> KVM: x86/mmu: remove ept_ad field
> KVM: x86/mmu: remove kvm_calc_shadow_root_page_role_common
> KVM: x86/mmu: cleanup computation of MMU roles for two-dimensional
> paging
> KVM: x86/mmu: cleanup computation of MMU roles for shadow paging
> KVM: x86/mmu: store shadow EFER.NX in the MMU role
> KVM: x86/mmu: remove extended bits from mmu_role, rename field
> KVM: x86/mmu: rename kvm_mmu_role union
> KVM: x86/mmu: remove redundant bits from extended role
> KVM: x86/mmu: remove valid from extended role
> KVM: x86/mmu: simplify and/or inline computation of shadow MMU roles
> KVM: x86/mmu: pull CPU mode computation to kvm_init_mmu
> KVM: x86/mmu: replace shadow_root_level with root_role.level
> KVM: x86/mmu: replace root_level with cpu_role.base.level
> KVM: x86/mmu: replace direct_map with root_role.direct
>
> Sean Christopherson (1):
> KVM: x86: Clean up and document nested #PF workaround
>
> arch/x86/include/asm/kvm_host.h | 19 +-
> arch/x86/kvm/mmu.h | 2 +-
> arch/x86/kvm/mmu/mmu.c | 376 ++++++++++++++------------------
> arch/x86/kvm/mmu/paging_tmpl.h | 14 +-
> arch/x86/kvm/mmu/tdp_mmu.c | 4 +-
> arch/x86/kvm/svm/nested.c | 18 +-
> arch/x86/kvm/svm/svm.c | 2 +-
> arch/x86/kvm/vmx/nested.c | 15 +-
> arch/x86/kvm/vmx/vmx.c | 2 +-
> arch/x86/kvm/x86.c | 33 ++-
> 10 files changed, 219 insertions(+), 266 deletions(-)
>
next prev parent reply other threads:[~2022-04-14 7:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 7:39 [PATCH v3 00/22] https://www.spinics.net/lists/kvm/msg267878.html Paolo Bonzini
2022-04-14 7:39 ` [PATCH 01/22] KVM: x86/mmu: nested EPT cannot be used in SMM Paolo Bonzini
2022-04-14 7:39 ` [PATCH 02/22] KVM: x86/mmu: constify uses of struct kvm_mmu_role_regs Paolo Bonzini
2022-04-14 7:39 ` [PATCH 03/22] KVM: x86/mmu: pull computation of kvm_mmu_role_regs to kvm_init_mmu Paolo Bonzini
2022-04-14 7:39 ` [PATCH 04/22] KVM: x86/mmu: rephrase unclear comment Paolo Bonzini
2022-04-14 7:39 ` [PATCH 05/22] KVM: x86: Clean up and document nested #PF workaround Paolo Bonzini
2022-04-14 7:39 ` [PATCH 06/22] KVM: x86/mmu: remove "bool base_only" arguments Paolo Bonzini
2022-04-14 7:39 ` [PATCH 07/22] KVM: x86/mmu: split cpu_role from mmu_role Paolo Bonzini
2022-04-15 4:16 ` Like Xu
2022-04-14 7:39 ` [PATCH 08/22] KVM: x86/mmu: do not recompute root level from kvm_mmu_role_regs Paolo Bonzini
2022-04-14 7:39 ` [PATCH 09/22] KVM: x86/mmu: remove ept_ad field Paolo Bonzini
2022-04-14 7:39 ` [PATCH 10/22] KVM: x86/mmu: remove kvm_calc_shadow_root_page_role_common Paolo Bonzini
2022-04-14 7:39 ` [PATCH 11/22] KVM: x86/mmu: cleanup computation of MMU roles for two-dimensional paging Paolo Bonzini
2022-04-14 7:39 ` [PATCH 12/22] KVM: x86/mmu: cleanup computation of MMU roles for shadow paging Paolo Bonzini
2022-04-14 7:39 ` [PATCH 13/22] KVM: x86/mmu: store shadow EFER.NX in the MMU role Paolo Bonzini
2022-04-14 7:39 ` [PATCH 14/22] KVM: x86/mmu: remove extended bits from mmu_role, rename field Paolo Bonzini
2022-04-14 7:39 ` [PATCH 15/22] KVM: x86/mmu: rename kvm_mmu_role union Paolo Bonzini
2022-04-14 7:39 ` [PATCH 16/22] KVM: x86/mmu: remove redundant bits from extended role Paolo Bonzini
2022-04-14 8:27 ` Paolo Bonzini
2022-05-10 0:20 ` Sean Christopherson
2022-05-11 13:53 ` Paolo Bonzini
2022-05-12 13:59 ` Paolo Bonzini
2022-05-12 14:18 ` Sean Christopherson
2022-05-12 16:09 ` Paolo Bonzini
2022-05-12 21:34 ` Sean Christopherson
2022-04-14 7:39 ` [PATCH 17/22] KVM: x86/mmu: remove valid " Paolo Bonzini
2022-04-14 7:39 ` [PATCH 18/22] KVM: x86/mmu: simplify and/or inline computation of shadow MMU roles Paolo Bonzini
2022-04-14 7:39 ` [PATCH 19/22] KVM: x86/mmu: pull CPU mode computation to kvm_init_mmu Paolo Bonzini
2022-04-14 7:39 ` [PATCH 20/22] KVM: x86/mmu: replace shadow_root_level with root_role.level Paolo Bonzini
2022-04-14 7:39 ` [PATCH 21/22] KVM: x86/mmu: replace root_level with cpu_role.base.level Paolo Bonzini
2022-04-14 7:40 ` [PATCH 22/22] KVM: x86/mmu: replace direct_map with root_role.direct Paolo Bonzini
2022-04-14 7:47 ` Paolo Bonzini [this message]
2022-04-14 15:02 ` [PATCH v3 00/22] https://www.spinics.net/lists/kvm/msg267878.html Sean Christopherson
2022-04-14 15:09 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2939c0cb-8e0c-7de4-7143-2df303bbb542@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).