LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] arm64: dts: rockchip: Fix override mode for rk3399-kevin panel
@ 2019-10-08 19:49 Douglas Anderson
  2019-10-10 21:42 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Douglas Anderson @ 2019-10-08 19:49 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Douglas Anderson, Sean Paul, devicetree, Enric Balletbo i Serra,
	linux-kernel, linux-rockchip, Robin Murphy, Rob Herring,
	Mark Rutland, Viresh Kumar, linux-arm-kernel

When I re-posted Sean's original commit to add the override mode for
the kevin panel, for some reason I didn't notice that the pixel clock
wasn't quite right.  Looking at /sys/kernel/debug/clk/clk_summary on
downstream kernels it can be seen that the VOP clock is supposed to be
266,666,667 Hz achieved by dividing the 800 MHz PLL by 3.

Looking at history, it seems that even Sean's first patch [1] had this
funny clock rate.  I'm not sure where it came from since the commit
message specifically mentioned 26666 kHz and the Chrome OS tree [2]
can be seen to request 266667 kHz.

In any case, let's fix it up.  This together with my patch [3] to do
the proper rounding when setting the clock rate makes the VOP clock
more proper as seen in /sys/kernel/debug/clk/clk_summary.

[1] https://lore.kernel.org/r/20180206165626.37692-4-seanpaul@chromium.org
[2] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4/drivers/gpu/drm/panel/panel-simple.c#1172
[3] https://lkml.kernel.org/r/20191003114726.v2.1.Ib233b3e706cf6317858384264d5b0ed35657456e@changeid

Fixes: 84ebd2da6d04 ("arm64: dts: rockchip: Specify override mode for kevin panel")
Cc: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
index e152b0ca0290..b8066868a3fe 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
@@ -44,7 +44,7 @@
 		power-supply = <&pp3300_disp>;
 
 		panel-timing {
-			clock-frequency = <266604720>;
+			clock-frequency = <266666667>;
 			hactive = <2400>;
 			hfront-porch = <48>;
 			hback-porch = <84>;
-- 
2.23.0.581.g78d2f28ef7-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Fix override mode for rk3399-kevin panel
  2019-10-08 19:49 [PATCH] arm64: dts: rockchip: Fix override mode for rk3399-kevin panel Douglas Anderson
@ 2019-10-10 21:42 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2019-10-10 21:42 UTC (permalink / raw)
  To: Douglas Anderson
  Cc: Sean Paul, devicetree, Enric Balletbo i Serra, linux-kernel,
	linux-rockchip, Robin Murphy, Rob Herring, Mark Rutland,
	Viresh Kumar, linux-arm-kernel

Am Dienstag, 8. Oktober 2019, 21:49:54 CEST schrieb Douglas Anderson:
> When I re-posted Sean's original commit to add the override mode for
> the kevin panel, for some reason I didn't notice that the pixel clock
> wasn't quite right.  Looking at /sys/kernel/debug/clk/clk_summary on
> downstream kernels it can be seen that the VOP clock is supposed to be
> 266,666,667 Hz achieved by dividing the 800 MHz PLL by 3.
> 
> Looking at history, it seems that even Sean's first patch [1] had this
> funny clock rate.  I'm not sure where it came from since the commit
> message specifically mentioned 26666 kHz and the Chrome OS tree [2]
> can be seen to request 266667 kHz.
> 
> In any case, let's fix it up.  This together with my patch [3] to do
> the proper rounding when setting the clock rate makes the VOP clock
> more proper as seen in /sys/kernel/debug/clk/clk_summary.
> 
> [1] https://lore.kernel.org/r/20180206165626.37692-4-seanpaul@chromium.org
> [2] https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4/drivers/gpu/drm/panel/panel-simple.c#1172
> [3] https://lkml.kernel.org/r/20191003114726.v2.1.Ib233b3e706cf6317858384264d5b0ed35657456e@changeid
> 
> Fixes: 84ebd2da6d04 ("arm64: dts: rockchip: Specify override mode for kevin panel")
> Cc: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

applied as fix for 5.4

Thanks
Heiko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 19:49 [PATCH] arm64: dts: rockchip: Fix override mode for rk3399-kevin panel Douglas Anderson
2019-10-10 21:42 ` Heiko Stuebner

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox