linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Wei Ni <wni@nvidia.com>,
	thierry.reding@gmail.com, linux-tegra@vger.kernel.org
Cc: rui.zhang@intel.com, edubezval@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails
Date: Thu, 22 Nov 2018 14:07:31 +0100	[thread overview]
Message-ID: <299fc8a0-39e4-1bd9-821b-4712a7f25028@linaro.org> (raw)
In-Reply-To: <5e09bc13-7880-40f2-3f90-01d2cc3510ba@nvidia.com>

On 22/11/2018 08:10, Wei Ni wrote:
> 
> 
> On 21/11/2018 8:51 PM, Daniel Lezcano wrote:
>> On 21/11/2018 11:23, Wei Ni wrote:
>>>
>>>
>>> On 21/11/2018 4:55 PM, Daniel Lezcano wrote:
>>>> On 13/11/2018 11:06, Wei Ni wrote:
>>>>> Don't bail when a sensor fails to register with the
>>>>> thermal zone and allow other sensors to register.
>>>>> This allows other sensors to register with thermal
>>>>> framework even if one sensor fails registration.
>>>>
>>>> I'm not sure if ignoring the error is really safe. Can you describe the
>>>> real situation you want to overcome ? How do you differentiate critical
>>>> sensors ?
>>>
>>> The driver will always try to register 4 thermal zones, including cpu,
>>> gpu, mem and pll, but if the dts file doesn't set the corresponding
>>> sensors, then the register will be failed.
>>> Normally, the dts file will set all 4 sensors, but there may have some
>>> platform doesn't support them all. So we post this patch.
>>
>> Ignoring errors is not the way to go to support different platforms. Fix
>> the DT.
> 
> The issue isn't in DT file. The Tegra soc thermal include 4 sensors:
> cpu, gpu, mem, pll. But in some platforms, for example, we may only need
> to support 2 sensors, such as cpu and gpu, so we only configure these
> two senors in DT file. But the driver will always try to register 4
> sensors, cpu/gpu/mem/pll, so mem and pll will be registered failed. So
> in this case we need to ignoring the failure, and continue to enable the
> driver.

You can fix this by changing the driver to support the platform and
register the sensor you are interested in.

Ignoring errors is not a good idea.


>>> BTW, what do you mean "critical sensors"? We will set critical trip temp
>>> for all sensors.
>>
>> I meant sensor for thermal zone getting really high temperature.
> 
> We doesn't have the critical sensors. We set the critical trip temp for
> all registered sensors. And these trip temp is set to the Tegra
> hardware. So it mean if the temperature reached the critical trip point,
> then the system will be shutdown directly.
> 
>>
>>
>>>>> Signed-off-by: Wei Ni <wni@nvidia.com>
>>>>> ---
>>>>>  drivers/thermal/tegra/soctherm.c | 8 +++++---
>>>>>  1 file changed, 5 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
>>>>> index ed28110a3535..a824d2e63af3 100644
>>>>> --- a/drivers/thermal/tegra/soctherm.c
>>>>> +++ b/drivers/thermal/tegra/soctherm.c
>>>>> @@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
>>>>>  							 &tegra_of_thermal_ops);
>>>>>  		if (IS_ERR(z)) {
>>>>>  			err = PTR_ERR(z);
>>>>> -			dev_err(&pdev->dev, "failed to register sensor: %d\n",
>>>>> -				err);
>>>>> -			goto disable_clocks;
>>>>> +			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
>>>>> +				 soc->ttgs[i]->name, err);
>>>>> +			continue;
>>>>>  		}
>>>>>  
>>>>>  		zone->tz = z;
>>>>> @@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
>>>>>  		struct thermal_zone_device *tz;
>>>>>  
>>>>>  		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
>>>>> +		if (!tz)
>>>>> +			continue;
>>>>>  		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
>>>>>  		if (err) {
>>>>>  			dev_err(&pdev->dev,
>>>>>
>>>>
>>>>
>>
>>


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2018-11-22 13:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 10:06 [PATCH v2 0/3] Fixes for Tegra soctherm Wei Ni
2018-11-13 10:06 ` [PATCH v2 1/3] thermal: tegra: continue if sensor register fails Wei Ni
2018-11-21  8:55   ` Daniel Lezcano
2018-11-21 10:23     ` Wei Ni
2018-11-21 12:51       ` Daniel Lezcano
2018-11-22  7:10         ` Wei Ni
2018-11-22 13:07           ` Daniel Lezcano [this message]
2018-11-23  6:15             ` Wei Ni
2018-11-23  6:51               ` Daniel Lezcano
2018-11-23  8:28                 ` Wei Ni
2018-11-13 10:06 ` [PATCH v2 2/3] thermal: tegra: remove unnecessary warnings Wei Ni
2018-11-13 10:06 ` [PATCH v2 3/3] thermal: tegra: fix memory allocation Wei Ni
2018-11-20  7:06 ` [PATCH v2 0/3] Fixes for Tegra soctherm Wei Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=299fc8a0-39e4-1bd9-821b-4712a7f25028@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=thierry.reding@gmail.com \
    --cc=wni@nvidia.com \
    --subject='Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).