linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Wei Ni <wni@nvidia.com>,
	thierry.reding@gmail.com, linux-tegra@vger.kernel.org
Cc: rui.zhang@intel.com, edubezval@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails
Date: Wed, 21 Nov 2018 09:55:34 +0100	[thread overview]
Message-ID: <d212af68-fd18-74d4-d81c-ed8b3c0f136a@linaro.org> (raw)
In-Reply-To: <1542103567-5521-2-git-send-email-wni@nvidia.com>

On 13/11/2018 11:06, Wei Ni wrote:
> Don't bail when a sensor fails to register with the
> thermal zone and allow other sensors to register.
> This allows other sensors to register with thermal
> framework even if one sensor fails registration.

I'm not sure if ignoring the error is really safe. Can you describe the
real situation you want to overcome ? How do you differentiate critical
sensors ?

> Signed-off-by: Wei Ni <wni@nvidia.com>
> ---
>  drivers/thermal/tegra/soctherm.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
> index ed28110a3535..a824d2e63af3 100644
> --- a/drivers/thermal/tegra/soctherm.c
> +++ b/drivers/thermal/tegra/soctherm.c
> @@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
>  							 &tegra_of_thermal_ops);
>  		if (IS_ERR(z)) {
>  			err = PTR_ERR(z);
> -			dev_err(&pdev->dev, "failed to register sensor: %d\n",
> -				err);
> -			goto disable_clocks;
> +			dev_warn(&pdev->dev, "failed to register sensor %s: %d\n",
> +				 soc->ttgs[i]->name, err);
> +			continue;
>  		}
>  
>  		zone->tz = z;
> @@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
>  		struct thermal_zone_device *tz;
>  
>  		tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
> +		if (!tz)
> +			continue;
>  		err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
>  		if (err) {
>  			dev_err(&pdev->dev,
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  reply	other threads:[~2018-11-21  8:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 10:06 [PATCH v2 0/3] Fixes for Tegra soctherm Wei Ni
2018-11-13 10:06 ` [PATCH v2 1/3] thermal: tegra: continue if sensor register fails Wei Ni
2018-11-21  8:55   ` Daniel Lezcano [this message]
2018-11-21 10:23     ` Wei Ni
2018-11-21 12:51       ` Daniel Lezcano
2018-11-22  7:10         ` Wei Ni
2018-11-22 13:07           ` Daniel Lezcano
2018-11-23  6:15             ` Wei Ni
2018-11-23  6:51               ` Daniel Lezcano
2018-11-23  8:28                 ` Wei Ni
2018-11-13 10:06 ` [PATCH v2 2/3] thermal: tegra: remove unnecessary warnings Wei Ni
2018-11-13 10:06 ` [PATCH v2 3/3] thermal: tegra: fix memory allocation Wei Ni
2018-11-20  7:06 ` [PATCH v2 0/3] Fixes for Tegra soctherm Wei Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d212af68-fd18-74d4-d81c-ed8b3c0f136a@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=thierry.reding@gmail.com \
    --cc=wni@nvidia.com \
    --subject='Re: [PATCH v2 1/3] thermal: tegra: continue if sensor register fails' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).