From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/11] mmc: sdhci-of-esdhc: use of_property_read_bool
Date: Thu, 18 Aug 2016 10:36:39 +0300 [thread overview]
Message-ID: <29aae420-01ef-b355-2fd8-87860a5f34d0@intel.com> (raw)
In-Reply-To: <1470387411-15879-7-git-send-email-Julia.Lawall@lip6.fr>
On 05/08/16 11:56, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e1,e2;
> statement S2,S1;
> @@
> - if (of_get_property(e1,e2,NULL))
> + if (of_property_read_bool(e1,e2))
> S1 else S2
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
>
> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 239be2f..fb71c86 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -583,7 +583,7 @@ static int sdhci_esdhc_probe(struct platform_device *pdev)
>
> np = pdev->dev.of_node;
>
> - if (of_get_property(np, "little-endian", NULL))
> + if (of_property_read_bool(np, "little-endian"))
> host = sdhci_pltfm_init(pdev, &sdhci_esdhc_le_pdata,
> sizeof(struct sdhci_esdhc));
> else
>
>
next prev parent reply other threads:[~2016-08-18 7:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
2016-08-05 8:56 ` [PATCH 01/11] fsl/qe: " Julia Lawall
2016-08-05 8:56 ` [PATCH 02/11] usb: host: fsl-mph-dr-of: " Julia Lawall
2016-08-05 11:26 ` [PATCH 02/11 v2] " Julia Lawall
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
2016-08-05 11:26 ` [PATCH 03/11 v2] " Julia Lawall
2016-08-11 11:52 ` [PATCH 03/11] " Linus Walleij
2016-08-05 8:56 ` [PATCH 04/11] i2c: mpc: " Julia Lawall
2017-10-27 20:15 ` [04/11] " Wolfram Sang
2016-08-05 8:56 ` [PATCH 05/11] tty/serial: at91: " Julia Lawall
2016-08-05 8:56 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Julia Lawall
2016-08-18 7:36 ` Adrian Hunter [this message]
2016-08-22 13:39 ` Ulf Hansson
2016-08-05 8:56 ` [PATCH 07/11] phy: qcom-ufs: " Julia Lawall
2016-08-05 11:25 ` [PATCH 07/11 v2] " Julia Lawall
2016-08-12 10:02 ` Kishon Vijay Abraham I
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
2016-08-05 10:12 ` Johannes Berg
2016-08-05 10:14 ` Julia Lawall
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2016-08-05 11:38 ` Julia Lawall
2016-08-05 11:40 ` Sergei Shtylyov
2016-08-05 8:56 ` [PATCH 09/11] powerpc/mpic: " Julia Lawall
2016-08-08 6:37 ` Michael Ellerman
2016-08-05 8:56 ` [PATCH 10/11] soc: ti: knav_qmss_queue: " Julia Lawall
2016-08-05 12:47 ` Robin Murphy
2016-08-05 12:59 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 11/11] ASoC: " Julia Lawall
2016-08-05 12:09 ` Applied "ASoC: use of_property_read_bool" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29aae420-01ef-b355-2fd8-87860a5f34d0@intel.com \
--to=adrian.hunter@intel.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).