From: Julia Lawall <julia.lawall@lip6.fr>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool
Date: Fri, 5 Aug 2016 12:08:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1608051207510.2999@hadrien> (raw)
In-Reply-To: <1470389433.2977.31.camel@sipsolutions.net>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 800 bytes --]
On Fri, 5 Aug 2016, Johannes Berg wrote:
>
> > - if (of_get_property(pdev->dev.of_node,
> > - "little-endian", NULL))
> > + if (of_property_read_bool(pdev->dev.of_node, "little-
> > endian"))
> > priv->is_little_endian = true;
> > else
> > priv->is_little_endian = false;
> >
>
> Perhaps, while changing this, that'd be better as
>
> priv->is_little_endian = of_property_read_bool(...);
>
> Obviously that would've worked before, but now it'd be even easier to
> understand, it seems.
Can I do the same for:
if (of_property_read_bool(np, "phy-clk-valid"))
pdata->check_phy_clk_valid = 1;
else
pdata->check_phy_clk_valid = 0;
The type is not bool, but:
include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
thanks,
julia
next prev parent reply other threads:[~2016-08-05 10:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
2016-08-05 8:56 ` [PATCH 01/11] fsl/qe: " Julia Lawall
2016-08-05 8:56 ` [PATCH 02/11] usb: host: fsl-mph-dr-of: " Julia Lawall
2016-08-05 11:26 ` [PATCH 02/11 v2] " Julia Lawall
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
2016-08-05 11:26 ` [PATCH 03/11 v2] " Julia Lawall
2016-08-11 11:52 ` [PATCH 03/11] " Linus Walleij
2016-08-05 8:56 ` [PATCH 04/11] i2c: mpc: " Julia Lawall
2017-10-27 20:15 ` [04/11] " Wolfram Sang
2016-08-05 8:56 ` [PATCH 05/11] tty/serial: at91: " Julia Lawall
2016-08-05 8:56 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Julia Lawall
2016-08-18 7:36 ` Adrian Hunter
2016-08-22 13:39 ` Ulf Hansson
2016-08-05 8:56 ` [PATCH 07/11] phy: qcom-ufs: " Julia Lawall
2016-08-05 11:25 ` [PATCH 07/11 v2] " Julia Lawall
2016-08-12 10:02 ` Kishon Vijay Abraham I
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall [this message]
2016-08-05 10:12 ` Johannes Berg
2016-08-05 10:14 ` Julia Lawall
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2016-08-05 11:38 ` Julia Lawall
2016-08-05 11:40 ` Sergei Shtylyov
2016-08-05 8:56 ` [PATCH 09/11] powerpc/mpic: " Julia Lawall
2016-08-08 6:37 ` Michael Ellerman
2016-08-05 8:56 ` [PATCH 10/11] soc: ti: knav_qmss_queue: " Julia Lawall
2016-08-05 12:47 ` Robin Murphy
2016-08-05 12:59 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 11/11] ASoC: " Julia Lawall
2016-08-05 12:09 ` Applied "ASoC: use of_property_read_bool" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1608051207510.2999@hadrien \
--to=julia.lawall@lip6.fr \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).