From: Corey Minyard <minyard@acm.org>
To: Fabian Frederick <fabf@skynet.be>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH 08/14] ipmi: use atomic_dec_not_zero()
Date: Fri, 28 Jul 2017 09:44:58 -0500 [thread overview]
Message-ID: <29e3f415-bdf3-05b0-e443-af84155022c1@acm.org> (raw)
In-Reply-To: <b5ee1292-00ff-6579-7e51-ce5d9de21b58@acm.org>
On 07/28/2017 09:27 AM, Corey Minyard wrote:
> I missed this until now, and I see it hasn't been applied yet. It's
> queued for the next release.
>
Well, never mind, I see the main update didn't go in.
-corey
> Thanks,
>
> -corey
>
> On 01/30/2017 12:47 PM, Fabian Frederick wrote:
>> instead of atomic_add_unless(value, -1, 0)
>>
>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>> ---
>> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/ipmi/ipmi_msghandler.c
>> b/drivers/char/ipmi/ipmi_msghandler.c
>> index 9f69995..961d677 100644
>> --- a/drivers/char/ipmi/ipmi_msghandler.c
>> +++ b/drivers/char/ipmi/ipmi_msghandler.c
>> @@ -3851,7 +3851,7 @@ static void handle_new_recv_msgs(ipmi_smi_t intf)
>> * If the pretimout count is non-zero, decrement one from it and
>> * deliver pretimeouts to all the users.
>> */
>> - if (atomic_add_unless(&intf->watchdog_pretimeouts_to_deliver,
>> -1, 0)) {
>> + if (atomic_dec_not_zero(&intf->watchdog_pretimeouts_to_deliver)) {
>> ipmi_user_t user;
>> rcu_read_lock();
>
>
prev parent reply other threads:[~2017-07-28 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 18:47 [PATCH 08/14] ipmi: use atomic_dec_not_zero() Fabian Frederick
2017-07-28 14:27 ` Corey Minyard
2017-07-28 14:44 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e3f415-bdf3-05b0-e443-af84155022c1@acm.org \
--to=minyard@acm.org \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).