* [PATCH] arm64: dts: meson: misc fixups for w400 dtsi
@ 2020-07-18 5:29 Christian Hewitt
2020-07-20 22:24 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Christian Hewitt @ 2020-07-18 5:29 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Kevin Hilman, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt
Current devices using the W400 dtsi show mmc tuning errors:
[12483.917391] mmc0: tuning execution failed: -5
[30535.551221] mmc0: tuning execution failed: -5
[35359.953671] mmc0: tuning execution failed: -5
[35561.875332] mmc0: tuning execution failed: -5
[61733.348709] mmc0: tuning execution failed: -5
Removing "sd-uhs-sdr50" from the SDIO node prevents this. We also add
keep-power-in-suspend to the SDIO node and fix an indentation.
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
index 98b70d216a6f..2802ddbb83ac 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
@@ -336,9 +336,11 @@
bus-width = <4>;
cap-sd-highspeed;
- sd-uhs-sdr50;
max-frequency = <100000000>;
+ /* WiFi firmware requires power to be kept while in suspend */
+ keep-power-in-suspend;
+
non-removable;
disable-wp;
@@ -398,7 +400,7 @@
shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
max-speed = <2000000>;
clocks = <&wifi32k>;
- clock-names = "lpo";
+ clock-names = "lpo";
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: meson: misc fixups for w400 dtsi
2020-07-18 5:29 [PATCH] arm64: dts: meson: misc fixups for w400 dtsi Christian Hewitt
@ 2020-07-20 22:24 ` Kevin Hilman
2020-07-21 1:39 ` Christian Hewitt
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2020-07-20 22:24 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Mark Rutland, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Christian Hewitt
Christian Hewitt <christianshewitt@gmail.com> writes:
> Current devices using the W400 dtsi show mmc tuning errors:
>
> [12483.917391] mmc0: tuning execution failed: -5
> [30535.551221] mmc0: tuning execution failed: -5
> [35359.953671] mmc0: tuning execution failed: -5
> [35561.875332] mmc0: tuning execution failed: -5
> [61733.348709] mmc0: tuning execution failed: -5
>
> Removing "sd-uhs-sdr50" from the SDIO node prevents this. We also add
> keep-power-in-suspend to the SDIO node and fix an indentation.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
This could use a Fixes tag so it can be backported to stable
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: meson: misc fixups for w400 dtsi
2020-07-20 22:24 ` Kevin Hilman
@ 2020-07-21 1:39 ` Christian Hewitt
0 siblings, 0 replies; 3+ messages in thread
From: Christian Hewitt @ 2020-07-21 1:39 UTC (permalink / raw)
To: Kevin Hilman
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
linux-amlogic, linux-kernel
> On 21 Jul 2020, at 2:24 am, Kevin Hilman <khilman@baylibre.com> wrote:
>
> Christian Hewitt <christianshewitt@gmail.com> writes:
>
>> Current devices using the W400 dtsi show mmc tuning errors:
>>
>> [12483.917391] mmc0: tuning execution failed: -5
>> [30535.551221] mmc0: tuning execution failed: -5
>> [35359.953671] mmc0: tuning execution failed: -5
>> [35561.875332] mmc0: tuning execution failed: -5
>> [61733.348709] mmc0: tuning execution failed: -5
>>
>> Removing "sd-uhs-sdr50" from the SDIO node prevents this. We also add
>> keep-power-in-suspend to the SDIO node and fix an indentation.
>>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>
> This could use a Fixes tag so it can be backported to stable
>
> Kevin
Okay, I will send v2 with a fixes tag.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-21 1:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-18 5:29 [PATCH] arm64: dts: meson: misc fixups for w400 dtsi Christian Hewitt
2020-07-20 22:24 ` Kevin Hilman
2020-07-21 1:39 ` Christian Hewitt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).