From: John Youn <John.Youn@synopsys.com>
To: Doug Anderson <dianders@chromium.org>, Felipe Balbi <balbi@ti.com>
Cc: "John Youn" <John.Youn@synopsys.com>,
"Yunzhi Li" <lyz@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Julius Werner" <jwerner@chromium.org>,
"Herrero, Gregory" <gregory.herrero@intel.com>,
"Kaukab, Yousaf" <yousaf.kaukab@intel.com>,
"Dinh Nguyen" <dinguyen@opensource.altera.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them
Date: Thu, 19 Nov 2015 01:43:35 +0000 [thread overview]
Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC3D696B@US01WEMBX2.internal.synopsys.com> (raw)
In-Reply-To: CAD=FV=W-UWJnHZioChnVmPmJQXxMGGOUQiF81h0ZTA4invivVA@mail.gmail.com
On 11/16/2015 9:22 AM, Doug Anderson wrote:
> Felipe,
>
> On Mon, Nov 16, 2015 at 8:28 AM, Felipe Balbi <balbi@ti.com> wrote:
>>
>> Hi,
>>
>> Douglas Anderson <dianders@chromium.org> writes:
>>> In general it is wise to clear interrupts before processing them. If
>>> you don't do that, you can get:
>>> 1. Interrupt happens
>>> 2. You look at system state and process interrupt
>>> 3. A new interrupt happens
>>> 4. You clear interrupt without processing it.
>>>
>>> This patch was actually a first attempt to fix missing device insertions
>>> as described in (usb: dwc2: host: Fix missing device insertions) and it
>>> did solve some of the signal bouncing problems but not all of
>>> them (which is why I submitted the other patch). Specifically, this
>>> patch itself would sometimes change:
>>> 1. hardware sees connect
>>> 2. hardware sees disconnect
>>> 3. hardware sees connect
>>> 4. dwc2_port_intr() - clears connect interrupt
>>> 5. dwc2_handle_common_intr() - calls dwc2_hcd_disconnect()
>>>
>>> ...to:
>>> 1. hardware sees connect
>>> 2. hardware sees disconnect
>>> 3. dwc2_port_intr() - clears connect interrupt
>>> 4. hardware sees connect
>>> 5. dwc2_handle_common_intr() - calls dwc2_hcd_disconnect()
>>>
>>> ...but with different timing then sometimes we'd still miss cable
>>> insertions.
>>>
>>> In any case, though this patch doesn't fix any (known) problems, it
>>> still seems wise as a general policy to clear interrupt before handling
>>> them.
>>>
>>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
>>> ---
>>> Changes in v2: None
>>>
>>> drivers/usb/dwc2/core_intr.c | 55 ++++++++++++++++++++++----------------------
>>> drivers/usb/dwc2/hcd_intr.c | 16 ++++++-------
>>> 2 files changed, 35 insertions(+), 36 deletions(-)
>>>
>>> diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
>>> index 61601d16e233..2a166b7eec41 100644
>>> --- a/drivers/usb/dwc2/core_intr.c
>>> +++ b/drivers/usb/dwc2/core_intr.c
>>> @@ -80,15 +80,16 @@ static const char *dwc2_op_state_str(struct dwc2_hsotg *hsotg)
>>> */
>>> static void dwc2_handle_usb_port_intr(struct dwc2_hsotg *hsotg)
>>> {
>>> - u32 hprt0 = dwc2_readl(hsotg->regs + HPRT0);
>>> + u32 hprt0;
>>>
>>> + /* Clear interrupt */
>>> + dwc2_writel(GINTSTS_PRTINT, hsotg->regs + GINTSTS);
>>> +
>>> + hprt0 = dwc2_readl(hsotg->regs + HPRT0);
>>> if (hprt0 & HPRT0_ENACHG) {
>>> hprt0 &= ~HPRT0_ENA;
>>> dwc2_writel(hprt0, hsotg->regs + HPRT0);
>>> }
>>> -
>>> - /* Clear interrupt */
>>> - dwc2_writel(GINTSTS_PRTINT, hsotg->regs + GINTSTS);
>>
>> isn't this a regression ? You're first clearing the interrupts and only
>> then reading to check what's pending, however, what's pending has just
>> been cleared. Seems like this should be:
>>
>> hprt0 = dwc2_readl(HPRT0);
>> dwc2_writeal(PRTINT, GINTSTS);
>
> Actually, we could probably remove the setting of GINTSTS_PRTINT
> completely. The docs I have say that the GINTSTS_PRTINT is read only
> and that:
>
>> The core sets this bit to indicate a change in port status of one of the
>> DWC_otg core ports in Host mode. The application must read the
>> Host Port Control and Status (HPRT) register to determine the exact
>> event that caused this interrupt. The application must clear the
>> appropriate status bit in the Host Port Control and Status register to
>> clear this bit.
>
> ...so writing PRTINT is probably useless, but John can confirm.
>
Yup, it seems it can be removed.
John
next prev parent reply other threads:[~2015-11-19 1:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 20:30 [PATCH v2 1/2] usb: dwc2: host: Fix missing device insertions Douglas Anderson
2015-11-03 20:30 ` [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Douglas Anderson
2015-11-05 3:08 ` John Youn
2015-11-16 16:28 ` Felipe Balbi
2015-11-16 17:22 ` Doug Anderson
2015-11-19 1:43 ` John Youn [this message]
2015-11-19 16:37 ` Doug Anderson
2015-11-19 18:19 ` Felipe Balbi
2015-11-19 19:09 ` John Youn
2015-11-05 2:52 ` [PATCH v2 1/2] usb: dwc2: host: Fix missing device insertions John Youn
2015-11-16 17:44 ` Felipe Balbi
2015-11-16 18:13 ` Doug Anderson
2015-11-16 18:22 ` Felipe Balbi
2015-11-16 18:44 ` Doug Anderson
2015-11-16 19:09 ` Felipe Balbi
2015-11-16 19:31 ` Alan Stern
2015-11-16 19:46 ` Doug Anderson
2015-11-16 20:26 ` Julius Werner
2015-11-16 20:38 ` Alan Stern
2015-11-16 20:31 ` Alan Stern
2015-11-16 23:14 ` Doug Anderson
2015-11-17 1:53 ` John Youn
2015-11-17 2:37 ` Doug Anderson
2015-11-17 15:40 ` Alan Stern
2015-11-17 16:13 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2B3535C5ECE8B5419E3ECBE30077290901DC3D696B@US01WEMBX2.internal.synopsys.com \
--to=john.youn@synopsys.com \
--cc=balbi@ti.com \
--cc=dianders@chromium.org \
--cc=dinguyen@opensource.altera.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.herrero@intel.com \
--cc=heiko@sntech.de \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lyz@rock-chips.com \
--cc=yousaf.kaukab@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).