From: John Youn <John.Youn@synopsys.com>
To: Felipe Balbi <balbi@ti.com>,
Doug Anderson <dianders@chromium.org>,
"John Youn" <John.Youn@synopsys.com>
Cc: "Yunzhi Li" <lyz@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Julius Werner" <jwerner@chromium.org>,
"Herrero, Gregory" <gregory.herrero@intel.com>,
"Kaukab, Yousaf" <yousaf.kaukab@intel.com>,
"Dinh Nguyen" <dinguyen@opensource.altera.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them
Date: Thu, 19 Nov 2015 19:09:51 +0000 [thread overview]
Message-ID: <2B3535C5ECE8B5419E3ECBE30077290901DC3D79C8@US01WEMBX2.internal.synopsys.com> (raw)
In-Reply-To: 877fldg8d9.fsf@saruman.tx.rr.com
On 11/19/2015 10:19 AM, Felipe Balbi wrote:
>
> Hi,
>
> Doug Anderson <dianders@chromium.org> writes:
>>>>> isn't this a regression ? You're first clearing the interrupts and only
>>>>> then reading to check what's pending, however, what's pending has just
>>>>> been cleared. Seems like this should be:
>>>>>
>>>>> hprt0 = dwc2_readl(HPRT0);
>>>>> dwc2_writeal(PRTINT, GINTSTS);
>>>>
>>>> Actually, we could probably remove the setting of GINTSTS_PRTINT
>>>> completely. The docs I have say that the GINTSTS_PRTINT is read only
>>>> and that:
>>>>
>>>>> The core sets this bit to indicate a change in port status of one of the
>>>>> DWC_otg core ports in Host mode. The application must read the
>>>>> Host Port Control and Status (HPRT) register to determine the exact
>>>>> event that caused this interrupt. The application must clear the
>>>>> appropriate status bit in the Host Port Control and Status register to
>>>>> clear this bit.
>>>>
>>>> ...so writing PRTINT is probably useless, but John can confirm.
>>>>
>>>
>>> Yup, it seems it can be removed.
>>
>> How do you guys want this handled? Should I send up a new version of
>> this patch? ...or should I send a followon patch that does this
>> removal?
>
> I'll leave the final decision to John, but my opinion is that a new
> version of the patch would be preferrable.
>
Hi Doug,
Could you resend with the change?
Regards,
John
next prev parent reply other threads:[~2015-11-19 19:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 20:30 [PATCH v2 1/2] usb: dwc2: host: Fix missing device insertions Douglas Anderson
2015-11-03 20:30 ` [PATCH v2 2/2] usb: dwc2: host: Clear interrupts before handling them Douglas Anderson
2015-11-05 3:08 ` John Youn
2015-11-16 16:28 ` Felipe Balbi
2015-11-16 17:22 ` Doug Anderson
2015-11-19 1:43 ` John Youn
2015-11-19 16:37 ` Doug Anderson
2015-11-19 18:19 ` Felipe Balbi
2015-11-19 19:09 ` John Youn [this message]
2015-11-05 2:52 ` [PATCH v2 1/2] usb: dwc2: host: Fix missing device insertions John Youn
2015-11-16 17:44 ` Felipe Balbi
2015-11-16 18:13 ` Doug Anderson
2015-11-16 18:22 ` Felipe Balbi
2015-11-16 18:44 ` Doug Anderson
2015-11-16 19:09 ` Felipe Balbi
2015-11-16 19:31 ` Alan Stern
2015-11-16 19:46 ` Doug Anderson
2015-11-16 20:26 ` Julius Werner
2015-11-16 20:38 ` Alan Stern
2015-11-16 20:31 ` Alan Stern
2015-11-16 23:14 ` Doug Anderson
2015-11-17 1:53 ` John Youn
2015-11-17 2:37 ` Doug Anderson
2015-11-17 15:40 ` Alan Stern
2015-11-17 16:13 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2B3535C5ECE8B5419E3ECBE30077290901DC3D79C8@US01WEMBX2.internal.synopsys.com \
--to=john.youn@synopsys.com \
--cc=balbi@ti.com \
--cc=dianders@chromium.org \
--cc=dinguyen@opensource.altera.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.herrero@intel.com \
--cc=heiko@sntech.de \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lyz@rock-chips.com \
--cc=yousaf.kaukab@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).