From: "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com>
To: Xing Zheng <zhengxing@rock-chips.com>,
Steve Barber <smbarber@google.com>
Cc: "linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Douglas Anderson" <dianders@chromium.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Kumar Gala" <galak@codeaurora.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Heiko Stübner" <heiko@sntech.de>
Subject: RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards
Date: Thu, 16 Jun 2016 08:40:45 +0000 [thread overview]
Message-ID: <2E89032DDAA8B9408CB92943514A0337D4643174@SW-EX-MBX01.diasemi.com> (raw)
In-Reply-To: <5761FDAA.1070802@rock-chips.com>
On 16 June 2016 02:15, Xing Zheng wrote:
> >> + /* Enable Headset and 4 Buttons Jack detection */
> >> + ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
> >> + SND_JACK_HEADSET |
> > Should this also include SND_JACK_LINEOUT? da7219 differentiates
> > between the two so not including lineout means, for example, we can
> > miss jack insertion/removal events.
> >
> Hi Adam,
>
> Could you please confirm Steve says that about SND_JACK_LINEOUT?
>
> Thanks.
Hi Xing Zheng,
Yes, as Steve mentioned DA7219 does support SND_JACK_LINEOUT so we should really
include this here.
prev parent reply other threads:[~2016-06-16 8:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 8:42 [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Xing Zheng
2016-06-14 22:38 ` Rob Herring
2016-06-15 9:53 ` Mark Brown
2016-06-15 12:44 ` Rob Herring
2016-06-16 2:36 ` [alsa-devel] " Ben Zhang
2016-06-17 12:20 ` Mark Brown
2016-06-15 19:43 ` Steve Barber
2016-06-16 1:15 ` Xing Zheng
2016-06-16 8:40 ` Opensource [Adam Thomson] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E89032DDAA8B9408CB92943514A0337D4643174@SW-EX-MBX01.diasemi.com \
--to=adam.thomson.opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=smbarber@google.com \
--cc=tiwai@suse.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).