From: Rob Herring <robh@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Xing Zheng" <zhengxing@rock-chips.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Doug Anderson" <dianders@chromium.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards
Date: Wed, 15 Jun 2016 07:44:32 -0500 [thread overview]
Message-ID: <CAL_JsqKEDw14HmbW=78_4P03nFDfmT7kOn4RsTF-PrBi+jWr0g@mail.gmail.com> (raw)
In-Reply-To: <20160615095312.GY2282@sirena.org.uk>
On Wed, Jun 15, 2016 at 4:53 AM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Jun 14, 2016 at 05:38:10PM -0500, Rob Herring wrote:
>> On Mon, Jun 13, 2016 at 04:42:18PM +0800, Xing Zheng wrote:
>
>> > +sound {
>> > + compatible = "rockchip,rk3399-gru-sound";
>> > + rockchip,cpu = <&i2s0>;
>> > + rockchip,codec = <&max98357a &rt5514 &da7219>;
>
>> These seem fairly standard though a variety of versions in the bindings.
>> Can we use audio-codec and audio-cpu (or cpu or audio-dai) here? Mark?
>
> Well, the roles aren't actually that standard (the fact that there's
> multiple CODECs and one CPU DAI here is really odd and definitely needs
> a very system specific interpretation). If they were standard we
> already have the simple-card binding that things should be using.
> There's no point in standard property names if the interpretation has to
> be non-standard.
Okay, I agree with the system specific interpretation part. However, I
don't think using simple-card or not determines using common
properties.
> The vendor specific prefixes are there because all bindings are supposed
> to add prefixes to property names.
...unless they are common.
Rob
next prev parent reply other threads:[~2016-06-15 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 8:42 [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards Xing Zheng
2016-06-14 22:38 ` Rob Herring
2016-06-15 9:53 ` Mark Brown
2016-06-15 12:44 ` Rob Herring [this message]
2016-06-16 2:36 ` [alsa-devel] " Ben Zhang
2016-06-17 12:20 ` Mark Brown
2016-06-15 19:43 ` Steve Barber
2016-06-16 1:15 ` Xing Zheng
2016-06-16 8:40 ` Opensource [Adam Thomson]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKEDw14HmbW=78_4P03nFDfmT7kOn4RsTF-PrBi+jWr0g@mail.gmail.com' \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).