* [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls
@ 2021-11-12 16:49 Christophe JAILLET
2021-11-12 18:18 ` Cristian Marussi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Christophe JAILLET @ 2021-11-12 16:49 UTC (permalink / raw)
To: gilad, herbert, davem
Cc: linux-crypto, linux-kernel, kernel-janitors, Christophe JAILLET
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
This was generated with coccinelle:
@@
expression E;
@@
- flush_workqueue(E);
destroy_workqueue(E);
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/crypto/ccree/cc_request_mgr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/ccree/cc_request_mgr.c b/drivers/crypto/ccree/cc_request_mgr.c
index 33fb27745d52..887162df50f9 100644
--- a/drivers/crypto/ccree/cc_request_mgr.c
+++ b/drivers/crypto/ccree/cc_request_mgr.c
@@ -101,7 +101,6 @@ void cc_req_mgr_fini(struct cc_drvdata *drvdata)
dev_dbg(dev, "max_used_sw_slots=%d\n", req_mgr_h->max_used_sw_slots);
#ifdef COMP_IN_WQ
- flush_workqueue(req_mgr_h->workq);
destroy_workqueue(req_mgr_h->workq);
#else
/* Kill tasklet */
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls
2021-11-12 16:49 [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls Christophe JAILLET
@ 2021-11-12 18:18 ` Cristian Marussi
2021-11-16 7:42 ` Gilad Ben-Yossef
2021-11-20 4:32 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Cristian Marussi @ 2021-11-12 18:18 UTC (permalink / raw)
To: Christophe JAILLET
Cc: gilad, herbert, davem, linux-crypto, linux-kernel, kernel-janitors
On Fri, Nov 12, 2021 at 05:49:23PM +0100, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
Hi Cristophe,
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
> ---
> drivers/crypto/ccree/cc_request_mgr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/ccree/cc_request_mgr.c b/drivers/crypto/ccree/cc_request_mgr.c
> index 33fb27745d52..887162df50f9 100644
> --- a/drivers/crypto/ccree/cc_request_mgr.c
> +++ b/drivers/crypto/ccree/cc_request_mgr.c
> @@ -101,7 +101,6 @@ void cc_req_mgr_fini(struct cc_drvdata *drvdata)
> dev_dbg(dev, "max_used_sw_slots=%d\n", req_mgr_h->max_used_sw_slots);
>
> #ifdef COMP_IN_WQ
> - flush_workqueue(req_mgr_h->workq);
> destroy_workqueue(req_mgr_h->workq);
> #else
> /* Kill tasklet */
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls
2021-11-12 16:49 [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-11-12 18:18 ` Cristian Marussi
@ 2021-11-16 7:42 ` Gilad Ben-Yossef
2021-11-20 4:32 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Gilad Ben-Yossef @ 2021-11-16 7:42 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Herbert Xu, David Miller, Linux Crypto Mailing List,
Linux kernel mailing list, kernel-janitors
On Fri, Nov 12, 2021 at 6:49 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/crypto/ccree/cc_request_mgr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/ccree/cc_request_mgr.c b/drivers/crypto/ccree/cc_request_mgr.c
> index 33fb27745d52..887162df50f9 100644
> --- a/drivers/crypto/ccree/cc_request_mgr.c
> +++ b/drivers/crypto/ccree/cc_request_mgr.c
> @@ -101,7 +101,6 @@ void cc_req_mgr_fini(struct cc_drvdata *drvdata)
> dev_dbg(dev, "max_used_sw_slots=%d\n", req_mgr_h->max_used_sw_slots);
>
> #ifdef COMP_IN_WQ
> - flush_workqueue(req_mgr_h->workq);
> destroy_workqueue(req_mgr_h->workq);
> #else
> /* Kill tasklet */
> --
> 2.30.2
>
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
Thank you for finding ths.
Also, this triggers me to revisit why the workqueue code is there at
all. I think we don't actually use it, so double thanks.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
values of β will give rise to dom!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls
2021-11-12 16:49 [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-11-12 18:18 ` Cristian Marussi
2021-11-16 7:42 ` Gilad Ben-Yossef
@ 2021-11-20 4:32 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-11-20 4:32 UTC (permalink / raw)
To: Christophe JAILLET
Cc: gilad, davem, linux-crypto, linux-kernel, kernel-janitors
On Fri, Nov 12, 2021 at 05:49:23PM +0100, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/crypto/ccree/cc_request_mgr.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-20 4:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12 16:49 [PATCH] crypto: ccree - remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-11-12 18:18 ` Cristian Marussi
2021-11-16 7:42 ` Gilad Ben-Yossef
2021-11-20 4:32 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).