linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add support for Ayaneo Air Plus 7320u.
@ 2024-02-07  8:42 Sebastian Kranz
  2024-02-07 14:55 ` Guenter Roeck
  0 siblings, 1 reply; 7+ messages in thread
From: Sebastian Kranz @ 2024-02-07  8:42 UTC (permalink / raw)
  To: linux
  Cc: samsagax, derekjohn.clark, jdelvare, linux-hwmon, linux-kernel,
	Sebastian Kranz

---
 drivers/hwmon/oxp-sensors.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
index ea9602063eab..8d3b0f86cc57 100644
--- a/drivers/hwmon/oxp-sensors.c
+++ b/drivers/hwmon/oxp-sensors.c
@@ -43,6 +43,7 @@ enum oxp_board {
 	aok_zoe_a1 = 1,
 	aya_neo_2,
 	aya_neo_air,
+	aya_neo_air_plus_mendo,
 	aya_neo_air_pro,
 	aya_neo_geek,
 	oxp_mini_amd,
@@ -98,6 +99,13 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *)aya_neo_air,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AB05-Mendocino"),
+		},
+		.driver_data = (void *)aya_neo_air_plus_mendo,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
@@ -332,6 +340,7 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
 			switch (board) {
 			case aya_neo_2:
 			case aya_neo_air:
+			case aya_neo_air_plus_mendo:
 			case aya_neo_air_pro:
 			case aya_neo_geek:
 			case oxp_mini_amd:
@@ -374,6 +383,7 @@ static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type,
 			switch (board) {
 			case aya_neo_2:
 			case aya_neo_air:
+			case aya_neo_air_plus_mendo:
 			case aya_neo_air_pro:
 			case aya_neo_geek:
 			case oxp_mini_amd:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add support for Ayaneo Air Plus 7320u.
  2024-02-07  8:42 [PATCH] Add support for Ayaneo Air Plus 7320u Sebastian Kranz
@ 2024-02-07 14:55 ` Guenter Roeck
  2024-02-08 12:25   ` Sebastian Kranz
  0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2024-02-07 14:55 UTC (permalink / raw)
  To: Sebastian Kranz
  Cc: samsagax, derekjohn.clark, jdelvare, linux-hwmon, linux-kernel

On 2/7/24 00:42, Sebastian Kranz wrote:
> ---

Patch description missing.

>   drivers/hwmon/oxp-sensors.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
> index ea9602063eab..8d3b0f86cc57 100644
> --- a/drivers/hwmon/oxp-sensors.c
> +++ b/drivers/hwmon/oxp-sensors.c
> @@ -43,6 +43,7 @@ enum oxp_board {
>   	aok_zoe_a1 = 1,
>   	aya_neo_2,
>   	aya_neo_air,
> +	aya_neo_air_plus_mendo,
>   	aya_neo_air_pro,
>   	aya_neo_geek,
>   	oxp_mini_amd,
> @@ -98,6 +99,13 @@ static const struct dmi_system_id dmi_table[] = {
>   		},
>   		.driver_data = (void *)aya_neo_air,
>   	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AB05-Mendocino"),
> +		},
> +		.driver_data = (void *)aya_neo_air_plus_mendo,
> +	},
>   	{
>   		.matches = {
>   			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
> @@ -332,6 +340,7 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
>   			switch (board) {
>   			case aya_neo_2:
>   			case aya_neo_air:
> +			case aya_neo_air_plus_mendo:
>   			case aya_neo_air_pro:
>   			case aya_neo_geek:
>   			case oxp_mini_amd:
> @@ -374,6 +383,7 @@ static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type,
>   			switch (board) {
>   			case aya_neo_2:
>   			case aya_neo_air:
> +			case aya_neo_air_plus_mendo:
>   			case aya_neo_air_pro:
>   			case aya_neo_geek:
>   			case oxp_mini_amd:


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add support for Ayaneo Air Plus 7320u.
  2024-02-07 14:55 ` Guenter Roeck
@ 2024-02-08 12:25   ` Sebastian Kranz
  2024-02-08 14:14     ` Guenter Roeck
  0 siblings, 1 reply; 7+ messages in thread
From: Sebastian Kranz @ 2024-02-08 12:25 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: samsagax, derekjohn.clark, jdelvare, linux-hwmon, linux-kernel

Subject: [PATCH] hwmon: (oxp-sensors) Add Ayaneo Air Plus 7320u

Am 7. Februar 2024 15:55:39 MEZ schrieb Guenter Roeck <linux@roeck-us.net>:
>On 2/7/24 00:42, Sebastian Kranz wrote:
>> ---
>
>Patch description missing.
>
>>   drivers/hwmon/oxp-sensors.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>> 
>> diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
>> index ea9602063eab..8d3b0f86cc57 100644
>> --- a/drivers/hwmon/oxp-sensors.c
>> +++ b/drivers/hwmon/oxp-sensors.c
>> @@ -43,6 +43,7 @@ enum oxp_board {
>>   	aok_zoe_a1 = 1,
>>   	aya_neo_2,
>>   	aya_neo_air,
>> +	aya_neo_air_plus_mendo,
>>   	aya_neo_air_pro,
>>   	aya_neo_geek,
>>   	oxp_mini_amd,
>> @@ -98,6 +99,13 @@ static const struct dmi_system_id dmi_table[] = {
>>   		},
>>   		.driver_data = (void *)aya_neo_air,
>>   	},
>> +	{
>> +		.matches = {
>> +			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
>> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AB05-Mendocino"),
>> +		},
>> +		.driver_data = (void *)aya_neo_air_plus_mendo,
>> +	},
>>   	{
>>   		.matches = {
>>   			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
>> @@ -332,6 +340,7 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
>>   			switch (board) {
>>   			case aya_neo_2:
>>   			case aya_neo_air:
>> +			case aya_neo_air_plus_mendo:
>>   			case aya_neo_air_pro:
>>   			case aya_neo_geek:
>>   			case oxp_mini_amd:
>> @@ -374,6 +383,7 @@ static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type,
>>   			switch (board) {
>>   			case aya_neo_2:
>>   			case aya_neo_air:
>> +			case aya_neo_air_plus_mendo:
>>   			case aya_neo_air_pro:
>>   			case aya_neo_geek:
>>   			case oxp_mini_amd:
>

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Add support for Ayaneo Air Plus 7320u.
  2024-02-08 12:25   ` Sebastian Kranz
@ 2024-02-08 14:14     ` Guenter Roeck
  2024-02-09  9:01       ` [PATCH V2] hwmon: (oxp-sensors) " Sebastian Kranz
  0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2024-02-08 14:14 UTC (permalink / raw)
  To: Sebastian Kranz
  Cc: samsagax, derekjohn.clark, jdelvare, linux-hwmon, linux-kernel

On 2/8/24 04:25, Sebastian Kranz wrote:
> Subject: [PATCH] hwmon: (oxp-sensors) Add Ayaneo Air Plus 7320u
> 

Not sure I understand what you are trying to say here. Yes, obviously
your patch has a subject. It still needs a description. See
"Describe your changes" in Documentation/process/submitting-patches.rst.

Guenter


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH V2] hwmon: (oxp-sensors) Add support for Ayaneo Air Plus 7320u.
  2024-02-08 14:14     ` Guenter Roeck
@ 2024-02-09  9:01       ` Sebastian Kranz
  2024-02-09 15:01         ` Guenter Roeck
  0 siblings, 1 reply; 7+ messages in thread
From: Sebastian Kranz @ 2024-02-09  9:01 UTC (permalink / raw)
  To: linux
  Cc: samsagax, derekjohn.clark, jdelvare, linux-hwmon, linux-kernel,
	Sebastian Kranz

Add support for handheld AYANEO AIR Plus with the same EC registers to add proper fan control.

Functionality was tested successfully.

Signed-off-by: Sebastian Kranz <tklightforce@googlemail.com>
---
 Documentation/hwmon/oxp-sensors.rst |  1 +
 drivers/hwmon/oxp-sensors.c         | 10 ++++++++++
 2 files changed, 11 insertions(+)

diff --git a/Documentation/hwmon/oxp-sensors.rst b/Documentation/hwmon/oxp-sensors.rst
index 3adeb7406243..55b1ef61625e 100644
--- a/Documentation/hwmon/oxp-sensors.rst
+++ b/Documentation/hwmon/oxp-sensors.rst
@@ -33,6 +33,7 @@ Currently the driver supports the following handhelds:
  - AOK ZOE A1 PRO
  - Aya Neo 2
  - Aya Neo AIR
+ - Aya Neo AIR Plus (Mendocino)
  - Aya Neo AIR Pro
  - Aya Neo Geek
  - OneXPlayer AMD
diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c
index ea9602063eab..8d3b0f86cc57 100644
--- a/drivers/hwmon/oxp-sensors.c
+++ b/drivers/hwmon/oxp-sensors.c
@@ -43,6 +43,7 @@ enum oxp_board {
 	aok_zoe_a1 = 1,
 	aya_neo_2,
 	aya_neo_air,
+	aya_neo_air_plus_mendo,
 	aya_neo_air_pro,
 	aya_neo_geek,
 	oxp_mini_amd,
@@ -98,6 +99,13 @@ static const struct dmi_system_id dmi_table[] = {
 		},
 		.driver_data = (void *)aya_neo_air,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "AB05-Mendocino"),
+		},
+		.driver_data = (void *)aya_neo_air_plus_mendo,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
@@ -332,6 +340,7 @@ static int oxp_platform_read(struct device *dev, enum hwmon_sensor_types type,
 			switch (board) {
 			case aya_neo_2:
 			case aya_neo_air:
+			case aya_neo_air_plus_mendo:
 			case aya_neo_air_pro:
 			case aya_neo_geek:
 			case oxp_mini_amd:
@@ -374,6 +383,7 @@ static int oxp_platform_write(struct device *dev, enum hwmon_sensor_types type,
 			switch (board) {
 			case aya_neo_2:
 			case aya_neo_air:
+			case aya_neo_air_plus_mendo:
 			case aya_neo_air_pro:
 			case aya_neo_geek:
 			case oxp_mini_amd:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH V2] hwmon: (oxp-sensors) Add support for Ayaneo Air Plus 7320u.
  2024-02-09  9:01       ` [PATCH V2] hwmon: (oxp-sensors) " Sebastian Kranz
@ 2024-02-09 15:01         ` Guenter Roeck
  2024-02-09 19:51           ` Sebastian Kranz
  0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2024-02-09 15:01 UTC (permalink / raw)
  To: Sebastian Kranz
  Cc: samsagax, derekjohn.clark, jdelvare, linux-hwmon, linux-kernel

On Fri, Feb 09, 2024 at 10:01:23AM +0100, Sebastian Kranz wrote:
> Add support for handheld AYANEO AIR Plus with the same EC registers to add proper fan control.
> 

checkpatch:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)

Also, there is no change log.

I fixed up the commit message when applying the patch, so there is no need
to resend, but please keep that in mind for future submissions.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH V2] hwmon: (oxp-sensors) Add support for Ayaneo Air Plus 7320u.
  2024-02-09 15:01         ` Guenter Roeck
@ 2024-02-09 19:51           ` Sebastian Kranz
  0 siblings, 0 replies; 7+ messages in thread
From: Sebastian Kranz @ 2024-02-09 19:51 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: samsagax, derekjohn.clark, jdelvare, linux-hwmon, linux-kernel

Sorry for the inconvenience.
Thanks you for your time and patience.

Am 9. Februar 2024 16:01:37 MEZ schrieb Guenter Roeck <linux@roeck-us.net>:
>On Fri, Feb 09, 2024 at 10:01:23AM +0100, Sebastian Kranz wrote:
>> Add support for handheld AYANEO AIR Plus with the same EC registers to add proper fan control.
>> 
>
>checkpatch:
>
>WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
>
>Also, there is no change log.
>
>I fixed up the commit message when applying the patch, so there is no need
>to resend, but please keep that in mind for future submissions.
>
>Thanks,
>Guenter

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-02-09 19:51 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-07  8:42 [PATCH] Add support for Ayaneo Air Plus 7320u Sebastian Kranz
2024-02-07 14:55 ` Guenter Roeck
2024-02-08 12:25   ` Sebastian Kranz
2024-02-08 14:14     ` Guenter Roeck
2024-02-09  9:01       ` [PATCH V2] hwmon: (oxp-sensors) " Sebastian Kranz
2024-02-09 15:01         ` Guenter Roeck
2024-02-09 19:51           ` Sebastian Kranz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).