From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Finn Thain <fthain@telegraphics.com.au>,
"Andrey Jr. Melnikov" <temnota.am@gmail.com>,
Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] scsi: aacraid: resurrect correct arc ctrl checks for Series-6
Date: Wed, 10 Jul 2019 09:24:32 +0000 [thread overview]
Message-ID: <2a6f5cc2-40cb-647c-003d-aae594d05062@virtuozzo.com> (raw)
In-Reply-To: <alpine.LNX.2.21.1907080936090.10@nippy.intranet>
On 07/08/2019 02:49 AM, Finn Thain wrote:
> Andrey,
>
> It is helpful to send your review to the patch author. I've added
> Konstantin to the Cc list, as well as Raghava (who introduced the
> regression addressed by Konstantin's patch).
>
> If I'm not mistaken, your review misunderstands the patch description.
>
> FWIW, Konstantin's patch might have been easier to follow if it was a
> simple 'git revert'.
Hi Finn, Andrey,
Finn,
thank you for putting me back to the thread, appreciated.
And i agree with you, may be git revert followed by independent patch
which removes Series-9 mentions is easier to read, so sending the second
version - in that way.
Andrey,
please take a look at the new version patches, hope it's easier to understand.
And talking about the helper: i thought about leaving it, but we have several places which check for Series 7 and 8 only
and several places which check for Series 6,7,8, so either
- we need 2 helpers
- we have a helper to check for Series 7,8 only and in some places will have a check for Series 6 + helper
- introduce the helper with parameter
Honestly i don't like any of variants above, so just left the code without helper,
not that many checks and easier to read the code IMHO.
Thank you!
--
Best regards,
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
next prev parent reply other threads:[~2019-07-10 9:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 16:14 [PATCH 0/1] aacraid: Host adapter Adaptec 6405 constantly resets under high io load Konstantin Khorenko
2019-06-27 16:14 ` [PATCH 1/1] scsi: aacraid: resurrect correct arc ctrl checks for Series-6 Konstantin Khorenko
2019-07-07 10:09 ` Andrey Jr. Melnikov
2019-07-07 23:49 ` Finn Thain
2019-07-10 9:24 ` Konstantin Khorenko [this message]
2019-07-10 9:31 ` [PATCH v2 0/2] aacraid: Host adapter Adaptec 6405 constantly resets under high io load Konstantin Khorenko
2019-07-10 9:31 ` [PATCH v2 1/2] Revert "scsi: aacraid: Remove reference to Series-9" Konstantin Khorenko
2019-07-10 9:31 ` [PATCH v2 2/2] scsi: aacraid: Remove references to Series-9 (only) Konstantin Khorenko
2019-07-12 1:30 ` Martin K. Petersen
2019-08-19 16:35 ` [PATCH v3 0/1] aacraid: Host adapter Adaptec 6405 constantly resets under high io load Konstantin Khorenko
2019-08-19 16:35 ` [PATCH v3 1/1] scsi: aacraid: resurrect correct arc ctrl checks for Series-6 Konstantin Khorenko
2019-08-29 21:52 ` [PATCH v3 0/1] aacraid: Host adapter Adaptec 6405 constantly resets under high io load Martin K. Petersen
2021-05-06 22:22 ` James Hilliard
[not found] ` <ffdb2223-eed3-75b4-a003-4e4c96b49947@grossegger.com>
2022-02-23 2:41 ` Martin K. Petersen
2022-10-10 12:31 ` James Hilliard
2022-10-19 18:00 ` Konstantin Khorenko
2022-10-26 20:10 ` James Hilliard
[not found] ` <BYAPR11MB36066925274C38555F20FB17FA339@BYAPR11MB3606.namprd11.prod.outlook.com>
2022-11-13 18:42 ` James Hilliard
2022-11-15 14:05 ` Sagar.Biradar
2022-11-16 21:55 ` James Hilliard
2022-11-18 3:36 ` Sagar.Biradar
2022-12-03 23:55 ` James Hilliard
2022-12-06 5:59 ` Sagar.Biradar
2022-12-16 20:44 ` Sagar.Biradar
2022-12-20 1:12 ` James Hilliard
2022-12-20 19:44 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a6f5cc2-40cb-647c-003d-aae594d05062@virtuozzo.com \
--to=khorenko@virtuozzo.com \
--cc=RaghavaAditya.Renukunta@microsemi.com \
--cc=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=temnota.am@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).