linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Cc: Michael Cyr <mikecyr@linux.vnet.ibm.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs
Date: Thu, 8 Jun 2017 07:31:43 -0500	[thread overview]
Message-ID: <2a7a2937-9f0e-de01-1690-21cf92bb45f2@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170608081242.27061-3-gregkh@linuxfoundation.org>


> The class_attrs pointer is going away and it's not even being used in
> this driver, so just remove it entirely.
>
> Cc: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
> Cc: Michael Cyr <mikecyr@linux.vnet.ibm.com>
> Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: <linux-scsi@vger.kernel.org>
> Cc: <target-devel@vger.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> index d390325c99ec..b480878e3258 100644
> --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> @@ -3915,10 +3915,6 @@ static const struct target_core_fabric_ops ibmvscsis_ops = {
>
>   static void ibmvscsis_dev_release(struct device *dev) {};
>
> -static struct class_attribute ibmvscsis_class_attrs[] = {
> -	__ATTR_NULL,
> -};
> -
>   static struct device_attribute dev_attr_system_id =
>   	__ATTR(system_id, S_IRUGO, system_id_show, NULL);
>
> @@ -3938,7 +3934,6 @@ ATTRIBUTE_GROUPS(ibmvscsis_dev);
>   static struct class ibmvscsis_class = {
>   	.name		= "ibmvscsis",
>   	.dev_release	= ibmvscsis_dev_release,
> -	.class_attrs	= ibmvscsis_class_attrs,
>   	.dev_groups	= ibmvscsis_dev_groups,
>   };
>
Thanks Greg, ACK.

-Bryant

  reply	other threads:[~2017-06-08 12:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  8:12 [PATCH 0/7] Driver core: remove class_attrs from struct class Greg Kroah-Hartman
2017-06-08  8:12 ` [PATCH 1/7] uwb: use class_groups instead of class_attrs Greg Kroah-Hartman
2017-06-08  8:12 ` [PATCH 2/7] scsi: ibmvscsi_tgt: remove use " Greg Kroah-Hartman
2017-06-08 12:31   ` Bryant G. Ly [this message]
2017-06-08  8:12 ` [PATCH 3/7] mtd: use class_groups instead " Greg Kroah-Hartman
2017-06-08 10:23   ` Richard Weinberger
2017-06-08  8:12 ` [PATCH 4/7] zram: " Greg Kroah-Hartman
2017-06-09  5:39   ` Sergey Senozhatsky
2017-06-08  8:12 ` [PATCH 5/7] gpio: " Greg Kroah-Hartman
2017-06-08  8:23   ` Robert P. J. Day
2017-06-08 12:05   ` Linus Walleij
2017-06-08  8:12 ` [PATCH 6/7] pktcdvd: " Greg Kroah-Hartman
2017-06-08 14:05   ` Jens Axboe
2017-06-08  8:12 ` [PATCH 7/7] driver core: remove class_attrs from struct class Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a7a2937-9f0e-de01-1690-21cf92bb45f2@linux.vnet.ibm.com \
    --to=bryantly@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mikecyr@linux.vnet.ibm.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).