* [PATCH] rtw89: remove unneeded variable
@ 2021-11-10 12:11 cgel.zte
2021-11-11 5:19 ` Pkshih
2021-11-26 16:11 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2021-11-10 12:11 UTC (permalink / raw)
To: kvalo
Cc: davem, kuba, deng.changcheng, pkshih, linux-wireless, netdev,
linux-kernel, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Fix the following coccicheck review:
./drivers/net/wireless/realtek/rtw89/mac.c: 1096: 5-8: Unneeded variable
Remove unneeded variable used to store return value.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/net/wireless/realtek/rtw89/mac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
index 0171a5a7b1de..b93ac242b305 100644
--- a/drivers/net/wireless/realtek/rtw89/mac.c
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
@@ -1093,7 +1093,6 @@ static int cmac_func_en(struct rtw89_dev *rtwdev, u8 mac_idx, bool en)
static int dmac_func_en(struct rtw89_dev *rtwdev)
{
u32 val32;
- u32 ret = 0;
val32 = (B_AX_MAC_FUNC_EN | B_AX_DMAC_FUNC_EN | B_AX_MAC_SEC_EN |
B_AX_DISPATCHER_EN | B_AX_DLE_CPUIO_EN | B_AX_PKT_IN_EN |
@@ -1107,7 +1106,7 @@ static int dmac_func_en(struct rtw89_dev *rtwdev)
B_AX_WD_RLS_CLK_EN);
rtw89_write32(rtwdev, R_AX_DMAC_CLK_EN, val32);
- return ret;
+ return 0;
}
static int chip_func_en(struct rtw89_dev *rtwdev)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] rtw89: remove unneeded variable
2021-11-10 12:11 [PATCH] rtw89: remove unneeded variable cgel.zte
@ 2021-11-11 5:19 ` Pkshih
2021-11-26 16:11 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Pkshih @ 2021-11-11 5:19 UTC (permalink / raw)
To: cgel.zte, kvalo
Cc: davem, kuba, deng.changcheng, linux-wireless, netdev,
linux-kernel, Zeal Robot
> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Wednesday, November 10, 2021 8:12 PM
> To: kvalo@codeaurora.org
> Cc: davem@davemloft.net; kuba@kernel.org; deng.changcheng@zte.com.cn; Pkshih <pkshih@realtek.com>;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> <zealci@zte.com.cn>
> Subject: [PATCH] rtw89: remove unneeded variable
>
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/net/wireless/realtek/rtw89/mac.c: 1096: 5-8: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw89/mac.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index 0171a5a7b1de..b93ac242b305 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -1093,7 +1093,6 @@ static int cmac_func_en(struct rtw89_dev *rtwdev, u8 mac_idx, bool en)
> static int dmac_func_en(struct rtw89_dev *rtwdev)
> {
> u32 val32;
> - u32 ret = 0;
>
> val32 = (B_AX_MAC_FUNC_EN | B_AX_DMAC_FUNC_EN | B_AX_MAC_SEC_EN |
> B_AX_DISPATCHER_EN | B_AX_DLE_CPUIO_EN | B_AX_PKT_IN_EN |
> @@ -1107,7 +1106,7 @@ static int dmac_func_en(struct rtw89_dev *rtwdev)
> B_AX_WD_RLS_CLK_EN);
> rtw89_write32(rtwdev, R_AX_DMAC_CLK_EN, val32);
>
> - return ret;
> + return 0;
> }
>
> static int chip_func_en(struct rtw89_dev *rtwdev)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtw89: remove unneeded variable
2021-11-10 12:11 [PATCH] rtw89: remove unneeded variable cgel.zte
2021-11-11 5:19 ` Pkshih
@ 2021-11-26 16:11 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2021-11-26 16:11 UTC (permalink / raw)
To: cgel.zte
Cc: davem, kuba, deng.changcheng, pkshih, linux-wireless, netdev,
linux-kernel, Zeal Robot
cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/net/wireless/realtek/rtw89/mac.c: 1096: 5-8: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
43863efeada6 rtw89: remove unneeded variable
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211110121135.151187-1-deng.changcheng@zte.com.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-26 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 12:11 [PATCH] rtw89: remove unneeded variable cgel.zte
2021-11-11 5:19 ` Pkshih
2021-11-26 16:11 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).