* [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid
@ 2022-07-03 18:34 Krzysztof Kozlowski
2022-07-03 18:34 ` [PATCH v2 1/2] dt-bindings: hwinfo: group Chip ID-like devices Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-03 18:34 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Alim Akhtar, Nishanth Menon,
Vignesh Raghavendra, Tero Kristo, linux-renesas-soc, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski
Hi,
As suggested by Rob [1], I organized a bit bindings for SoC devices having
similar purpose - chip identification.
These sometimes are put under nvmem directory, although in that case the
purpose is usually broader than just chipid.
Best regards,
Krzysztof
Krzysztof Kozlowski (2):
dt-bindings: hwinfo: group Chip ID-like devices
dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID
.../{soc/renesas => hwinfo}/renesas,prr.yaml | 2 +-
.../samsung,exynos-chipid.yaml} | 2 +-
.../hwinfo/samsung,s5pv210-chipid.yaml | 30 +++++++++++++++++++
.../ti,k3-socinfo.yaml} | 2 +-
MAINTAINERS | 3 ++
5 files changed, 36 insertions(+), 3 deletions(-)
rename Documentation/devicetree/bindings/{soc/renesas => hwinfo}/renesas,prr.yaml (92%)
rename Documentation/devicetree/bindings/{soc/samsung/exynos-chipid.yaml => hwinfo/samsung,exynos-chipid.yaml} (92%)
create mode 100644 Documentation/devicetree/bindings/hwinfo/samsung,s5pv210-chipid.yaml
rename Documentation/devicetree/bindings/{soc/ti/k3-socinfo.yaml => hwinfo/ti,k3-socinfo.yaml} (92%)
--
2.34.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] dt-bindings: hwinfo: group Chip ID-like devices
2022-07-03 18:34 [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid Krzysztof Kozlowski
@ 2022-07-03 18:34 ` Krzysztof Kozlowski
2022-07-03 18:34 ` [PATCH v2 2/2] dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-03 18:34 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Alim Akhtar, Nishanth Menon,
Vignesh Raghavendra, Tero Kristo, linux-renesas-soc, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski
Group devices like Chip ID or SoC information under "hwinfo" directory.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. New patch
---
.../bindings/{soc/renesas => hwinfo}/renesas,prr.yaml | 2 +-
.../exynos-chipid.yaml => hwinfo/samsung,exynos-chipid.yaml} | 2 +-
.../{soc/ti/k3-socinfo.yaml => hwinfo/ti,k3-socinfo.yaml} | 2 +-
MAINTAINERS | 3 +++
4 files changed, 6 insertions(+), 3 deletions(-)
rename Documentation/devicetree/bindings/{soc/renesas => hwinfo}/renesas,prr.yaml (92%)
rename Documentation/devicetree/bindings/{soc/samsung/exynos-chipid.yaml => hwinfo/samsung,exynos-chipid.yaml} (92%)
rename Documentation/devicetree/bindings/{soc/ti/k3-socinfo.yaml => hwinfo/ti,k3-socinfo.yaml} (92%)
diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,prr.yaml b/Documentation/devicetree/bindings/hwinfo/renesas,prr.yaml
similarity index 92%
rename from Documentation/devicetree/bindings/soc/renesas/renesas,prr.yaml
rename to Documentation/devicetree/bindings/hwinfo/renesas,prr.yaml
index 654c96638e75..792f371cec03 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas,prr.yaml
+++ b/Documentation/devicetree/bindings/hwinfo/renesas,prr.yaml
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
-$id: http://devicetree.org/schemas/soc/renesas/renesas,prr.yaml#
+$id: http://devicetree.org/schemas/hwinfo/renesas,prr.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Renesas Product Register
diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
similarity index 92%
rename from Documentation/devicetree/bindings/soc/samsung/exynos-chipid.yaml
rename to Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
index 4bb8efb83ac1..95cbdcb56efe 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-chipid.yaml
+++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
%YAML 1.2
---
-$id: http://devicetree.org/schemas/soc/samsung/exynos-chipid.yaml#
+$id: http://devicetree.org/schemas/hwinfo/samsung,exynos-chipid.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Samsung Exynos SoC series Chipid driver
diff --git a/Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml b/Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml
similarity index 92%
rename from Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml
rename to Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml
index a1a8423b2e2e..dada28b47ea0 100644
--- a/Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml
+++ b/Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
-$id: http://devicetree.org/schemas/soc/ti/k3-socinfo.yaml#
+$id: http://devicetree.org/schemas/hwinfo/ti,k3-socinfo.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Texas Instruments K3 Multicore SoC platforms chipid module
diff --git a/MAINTAINERS b/MAINTAINERS
index 7c9187635801..cd7a6598436d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2629,6 +2629,7 @@ Q: http://patchwork.kernel.org/project/linux-renesas-soc/list/
C: irc://irc.libera.chat/renesas-soc
T: git git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git next
F: Documentation/devicetree/bindings/arm/renesas.yaml
+F: Documentation/devicetree/bindings/hwinfo/renesas,prr.yaml
F: arch/arm64/boot/dts/renesas/
F: drivers/soc/renesas/
F: include/linux/soc/renesas/
@@ -2679,6 +2680,7 @@ B: mailto:linux-samsung-soc@vger.kernel.org
T: git git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git
F: Documentation/arm/samsung/
F: Documentation/devicetree/bindings/arm/samsung/
+F: Documentation/devicetree/bindings/hwinfo/samsung,*
F: Documentation/devicetree/bindings/power/pd-samsung.yaml
F: Documentation/devicetree/bindings/soc/samsung/
F: arch/arm/boot/dts/exynos*
@@ -2912,6 +2914,7 @@ M: Tero Kristo <kristo@kernel.org>
L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
S: Supported
F: Documentation/devicetree/bindings/arm/ti/k3.yaml
+F: Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml
F: arch/arm64/boot/dts/ti/Makefile
F: arch/arm64/boot/dts/ti/k3-*
F: include/dt-bindings/pinctrl/k3.h
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID
2022-07-03 18:34 [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid Krzysztof Kozlowski
2022-07-03 18:34 ` [PATCH v2 1/2] dt-bindings: hwinfo: group Chip ID-like devices Krzysztof Kozlowski
@ 2022-07-03 18:34 ` Krzysztof Kozlowski
2022-07-03 18:36 ` [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid Krzysztof Kozlowski
2022-07-04 7:18 ` Geert Uytterhoeven
3 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-03 18:34 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Alim Akhtar, Nishanth Menon,
Vignesh Raghavendra, Tero Kristo, linux-renesas-soc, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski
Document already used S5PV210 ChipID block.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. Move to hwinfo and rename.
2. Mention that device is already used.
---
.../hwinfo/samsung,s5pv210-chipid.yaml | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwinfo/samsung,s5pv210-chipid.yaml
diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,s5pv210-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,s5pv210-chipid.yaml
new file mode 100644
index 000000000000..563ded4fca83
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwinfo/samsung,s5pv210-chipid.yaml
@@ -0,0 +1,30 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwinfo/samsung,s5pv210-chipid.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung S5PV210 SoC ChipID
+
+maintainers:
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+properties:
+ compatible:
+ const: samsung,s5pv210-chipid
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ chipid@e0000000 {
+ compatible = "samsung,s5pv210-chipid";
+ reg = <0xe0000000 0x1000>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid
2022-07-03 18:34 [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid Krzysztof Kozlowski
2022-07-03 18:34 ` [PATCH v2 1/2] dt-bindings: hwinfo: group Chip ID-like devices Krzysztof Kozlowski
2022-07-03 18:34 ` [PATCH v2 2/2] dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID Krzysztof Kozlowski
@ 2022-07-03 18:36 ` Krzysztof Kozlowski
2022-07-04 7:18 ` Geert Uytterhoeven
3 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-03 18:36 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Alim Akhtar, Nishanth Menon,
Vignesh Raghavendra, Tero Kristo, linux-renesas-soc, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
On 03/07/2022 20:34, Krzysztof Kozlowski wrote:
> Hi,
>
> As suggested by Rob [1], I organized a bit bindings for SoC devices having
> similar purpose - chip identification.
>
> These sometimes are put under nvmem directory, although in that case the
> purpose is usually broader than just chipid.
And the missing [1] link is:
https://lore.kernel.org/all/20220701173524.GA1185040-robh@kernel.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid
2022-07-03 18:34 [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-07-03 18:36 ` [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid Krzysztof Kozlowski
@ 2022-07-04 7:18 ` Geert Uytterhoeven
2022-07-04 7:21 ` Krzysztof Kozlowski
2022-07-05 14:51 ` Rob Herring
3 siblings, 2 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2022-07-04 7:18 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Linux ARM, linux-samsung-soc
Hi Krzysztof,
On Sun, Jul 3, 2022 at 8:35 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> As suggested by Rob [1], I organized a bit bindings for SoC devices having
> similar purpose - chip identification.
>
> These sometimes are put under nvmem directory, although in that case the
> purpose is usually broader than just chipid.
Thanks for your series!
> dt-bindings: hwinfo: group Chip ID-like devices
> dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID
So why not call it "chipid"?
"hwinfo" sounds too generic to me; aren't all DT bindings hardware
information?
>
> .../{soc/renesas => hwinfo}/renesas,prr.yaml | 2 +-
> .../samsung,exynos-chipid.yaml} | 2 +-
> .../hwinfo/samsung,s5pv210-chipid.yaml | 30 +++++++++++++++++++
> .../ti,k3-socinfo.yaml} | 2 +-
> MAINTAINERS | 3 ++
> 5 files changed, 36 insertions(+), 3 deletions(-)
> rename Documentation/devicetree/bindings/{soc/renesas => hwinfo}/renesas,prr.yaml (92%)
> rename Documentation/devicetree/bindings/{soc/samsung/exynos-chipid.yaml => hwinfo/samsung,exynos-chipid.yaml} (92%)
> create mode 100644 Documentation/devicetree/bindings/hwinfo/samsung,s5pv210-chipid.yaml
> rename Documentation/devicetree/bindings/{soc/ti/k3-socinfo.yaml => hwinfo/ti,k3-socinfo.yaml} (92%)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid
2022-07-04 7:18 ` Geert Uytterhoeven
@ 2022-07-04 7:21 ` Krzysztof Kozlowski
2022-07-05 14:51 ` Rob Herring
1 sibling, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-04 7:21 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
Nishanth Menon, Vignesh Raghavendra, Tero Kristo, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Linux ARM, linux-samsung-soc
On 04/07/2022 09:18, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Sun, Jul 3, 2022 at 8:35 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> As suggested by Rob [1], I organized a bit bindings for SoC devices having
>> similar purpose - chip identification.
>>
>> These sometimes are put under nvmem directory, although in that case the
>> purpose is usually broader than just chipid.
>
> Thanks for your series!
>
>> dt-bindings: hwinfo: group Chip ID-like devices
>> dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID
>
> So why not call it "chipid"?
> "hwinfo" sounds too generic to me; aren't all DT bindings hardware
> information?
If it is too specific, some other similar drivers won't perfectly match
thus they will be placed again under dt-bindings/soc.
I was thinking about name "socinfo", but on the other hand why limiting
to SoC? I think there are many more devices which provide some kind of
read-only hardware information (type, revision, product ID, model etc),
therefore - hwinfo.
Thanks for the feedback.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid
2022-07-04 7:18 ` Geert Uytterhoeven
2022-07-04 7:21 ` Krzysztof Kozlowski
@ 2022-07-05 14:51 ` Rob Herring
2022-07-05 15:43 ` Krzysztof Kozlowski
1 sibling, 1 reply; 8+ messages in thread
From: Rob Herring @ 2022-07-05 14:51 UTC (permalink / raw)
To: Geert Uytterhoeven, Krzysztof Kozlowski
Cc: Magnus Damm, Krzysztof Kozlowski, Alim Akhtar, Nishanth Menon,
Vignesh Raghavendra, Tero Kristo, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Linux ARM, linux-samsung-soc
On Mon, Jul 04, 2022 at 09:18:31AM +0200, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Sun, Jul 3, 2022 at 8:35 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > As suggested by Rob [1], I organized a bit bindings for SoC devices having
> > similar purpose - chip identification.
What's the base? It didn't apply for me.
> >
> > These sometimes are put under nvmem directory, although in that case the
> > purpose is usually broader than just chipid.
>
> Thanks for your series!
>
> > dt-bindings: hwinfo: group Chip ID-like devices
> > dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID
>
> So why not call it "chipid"?
> "hwinfo" sounds too generic to me; aren't all DT bindings hardware
> information?
I'm fine with hwinfo as the color of the shed. I don't think we should
encode where the information comes from.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid
2022-07-05 14:51 ` Rob Herring
@ 2022-07-05 15:43 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-05 15:43 UTC (permalink / raw)
To: Rob Herring, Geert Uytterhoeven
Cc: Magnus Damm, Krzysztof Kozlowski, Alim Akhtar, Nishanth Menon,
Vignesh Raghavendra, Tero Kristo, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Linux ARM, linux-samsung-soc
On 05/07/2022 16:51, Rob Herring wrote:
> On Mon, Jul 04, 2022 at 09:18:31AM +0200, Geert Uytterhoeven wrote:
>> Hi Krzysztof,
>>
>> On Sun, Jul 3, 2022 at 8:35 PM Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>> As suggested by Rob [1], I organized a bit bindings for SoC devices having
>>> similar purpose - chip identification.
>
> What's the base? It didn't apply for me.
The Renesas bits should go via Renesas tree. I'll split the series.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-05 15:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-03 18:34 [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid Krzysztof Kozlowski
2022-07-03 18:34 ` [PATCH v2 1/2] dt-bindings: hwinfo: group Chip ID-like devices Krzysztof Kozlowski
2022-07-03 18:34 ` [PATCH v2 2/2] dt-bindings: hwinfo: samsung,s5pv210-chipid: add S5PV210 ChipID Krzysztof Kozlowski
2022-07-03 18:36 ` [PATCH v2 0/2] dt-bindings: hwinfo: group devices and add s5pv210-chipid Krzysztof Kozlowski
2022-07-04 7:18 ` Geert Uytterhoeven
2022-07-04 7:21 ` Krzysztof Kozlowski
2022-07-05 14:51 ` Rob Herring
2022-07-05 15:43 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).