* [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer
@ 2023-03-19 17:30 Rob Herring
2023-03-20 15:28 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2023-03-19 17:30 UTC (permalink / raw)
To: Ulf Hansson, Krzysztof Kozlowski, Kunihiko Hayashi
Cc: linux-mmc, devicetree, linux-kernel
Add support for Socionext Synquacer SDHCI. This binding has been in use for
some time.
The interrupts were not documented. The driver only uses the first
interrupt, but the DT and example have 2 interrupts. The 2nd one is
unknown. "dma-coherent" was also not documented, but is used on Synquacer.
Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
- Rebase on conversion done by Kunihiko
---
.../bindings/mmc/fujitsu,sdhci-fujitsu.yaml | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
index 73d747e917f3..430b62899397 100644
--- a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
+++ b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
@@ -14,9 +14,13 @@ allOf:
properties:
compatible:
- enum:
- - fujitsu,mb86s70-sdhci-3.0
- - socionext,f-sdh30-e51-mmc
+ oneOf:
+ - items:
+ - const: socionext,synquacer-sdhci
+ - const: fujitsu,mb86s70-sdhci-3.0
+ - enum:
+ - fujitsu,mb86s70-sdhci-3.0
+ - socionext,f-sdh30-e51-mmc
reg:
maxItems: 1
@@ -29,6 +33,11 @@ properties:
- const: iface
- const: core
+ dma-coherent: true
+
+ interrupts:
+ maxItems: 2
+
resets:
maxItems: 1
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer
2023-03-19 17:30 [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer Rob Herring
@ 2023-03-20 15:28 ` Krzysztof Kozlowski
2023-03-22 2:27 ` Kunihiko Hayashi
2023-03-23 12:13 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-20 15:28 UTC (permalink / raw)
To: Rob Herring, Ulf Hansson, Krzysztof Kozlowski, Kunihiko Hayashi
Cc: linux-mmc, devicetree, linux-kernel
On 19/03/2023 18:30, Rob Herring wrote:
> Add support for Socionext Synquacer SDHCI. This binding has been in use for
> some time.
>
> The interrupts were not documented. The driver only uses the first
> interrupt, but the DT and example have 2 interrupts. The 2nd one is
> unknown. "dma-coherent" was also not documented, but is used on Synquacer.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer
2023-03-19 17:30 [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer Rob Herring
2023-03-20 15:28 ` Krzysztof Kozlowski
@ 2023-03-22 2:27 ` Kunihiko Hayashi
2023-03-23 12:13 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Kunihiko Hayashi @ 2023-03-22 2:27 UTC (permalink / raw)
To: Rob Herring, Ulf Hansson, Krzysztof Kozlowski
Cc: linux-mmc, devicetree, linux-kernel
Hi Rob,
On 2023/03/20 2:30, Rob Herring wrote:
> Add support for Socionext Synquacer SDHCI. This binding has been in use
> for
> some time.
>
> The interrupts were not documented. The driver only uses the first
> interrupt, but the DT and example have 2 interrupts. The 2nd one is
> unknown. "dma-coherent" was also not documented, but is used on Synquacer.
Surely "interrupts" is needed. The 2nd interrupt seems to come from
the card, though, the driver isn't supported it.
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Thank you,
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Rebase on conversion done by Kunihiko
> ---
> .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> index 73d747e917f3..430b62899397 100644
> --- a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> @@ -14,9 +14,13 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - fujitsu,mb86s70-sdhci-3.0
> - - socionext,f-sdh30-e51-mmc
> + oneOf:
> + - items:
> + - const: socionext,synquacer-sdhci
> + - const: fujitsu,mb86s70-sdhci-3.0
> + - enum:
> + - fujitsu,mb86s70-sdhci-3.0
> + - socionext,f-sdh30-e51-mmc
>
> reg:
> maxItems: 1
> @@ -29,6 +33,11 @@ properties:
> - const: iface
> - const: core
>
> + dma-coherent: true
> +
> + interrupts:
> + maxItems: 2
> +
> resets:
> maxItems: 1
>
---
Best Regards
Kunihiko Hayashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer
2023-03-19 17:30 [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer Rob Herring
2023-03-20 15:28 ` Krzysztof Kozlowski
2023-03-22 2:27 ` Kunihiko Hayashi
@ 2023-03-23 12:13 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2023-03-23 12:13 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Kunihiko Hayashi, linux-mmc, devicetree,
linux-kernel
On Sun, 19 Mar 2023 at 18:30, Rob Herring <robh@kernel.org> wrote:
>
> Add support for Socionext Synquacer SDHCI. This binding has been in use for
> some time.
>
> The interrupts were not documented. The driver only uses the first
> interrupt, but the DT and example have 2 interrupts. The 2nd one is
> unknown. "dma-coherent" was also not documented, but is used on Synquacer.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> v2:
> - Rebase on conversion done by Kunihiko
> ---
> .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> index 73d747e917f3..430b62899397 100644
> --- a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> @@ -14,9 +14,13 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - fujitsu,mb86s70-sdhci-3.0
> - - socionext,f-sdh30-e51-mmc
> + oneOf:
> + - items:
> + - const: socionext,synquacer-sdhci
> + - const: fujitsu,mb86s70-sdhci-3.0
> + - enum:
> + - fujitsu,mb86s70-sdhci-3.0
> + - socionext,f-sdh30-e51-mmc
>
> reg:
> maxItems: 1
> @@ -29,6 +33,11 @@ properties:
> - const: iface
> - const: core
>
> + dma-coherent: true
> +
> + interrupts:
> + maxItems: 2
> +
> resets:
> maxItems: 1
>
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-23 12:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-19 17:30 [PATCH v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer Rob Herring
2023-03-20 15:28 ` Krzysztof Kozlowski
2023-03-22 2:27 ` Kunihiko Hayashi
2023-03-23 12:13 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).