From: okaya@codeaurora.org
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"open list:EFIFB FRAMEBUFFER DRIVER"
<linux-fbdev@vger.kernel.org>, Timur Tabi <timur@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Peter Jones <pjones@redhat.com>,
"open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if translated by the bridge
Date: Wed, 13 Jun 2018 11:29:44 -0400 [thread overview]
Message-ID: <2be0216f218f9635595f39a8da3afad7@codeaurora.org> (raw)
In-Reply-To: <CAKv+Gu_ZRNvW9CeqRyUpQGnrkkoOi1Hh08re=_Gz=EGVTAvbsA@mail.gmail.com>
On 2018-06-13 11:22, Ard Biesheuvel wrote:
> On 13 June 2018 at 17:17, <okaya@codeaurora.org> wrote:
>> On 2018-06-13 11:06, Ard Biesheuvel wrote:
>>>
>>> On 13 June 2018 at 16:22, Sinan Kaya <okaya@codeaurora.org> wrote:
>>>>
>>>> Hi Ard,
>>>>
>>>> On 5/18/2018 10:17 AM, Sinan Kaya wrote:
>>>>>
>>>>> A host bridge is allowed to remap BAR addresses using _TRA
>>>>> attribute in
>>>>> _CRS windows.
>>>>>
>>>>> pci_bus 0000:00: root bus resource [mem 0x80100100000-0x8011fffffff
>>>>> window] (bus address [0x00100000-0x1fffffff])
>>>>> pci 0000:02:00.0: reg 0x10: [mem 0x8011e000000-0x8011effffff]
>>>>>
>>>>> When a VGA device is behind such a host bridge and the resource is
>>>>> translated efifb driver is trying to do ioremap against bus address
>>>>> rather than the resource address and is failing to probe.
>>>>>
>>>>> efifb: probing for efifb
>>>>> efifb: cannot reserve video memory at 0x1e000000
>>>>> efifb: framebuffer at 0x1e000000, using 1920k, total 1875k
>>>>> efifb: mode is 800x600x32, linelength=3200, pages=1
>>>>> efifb: scrolling: redraw
>>>>> efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
>>>>>
>>>>> Use the host bridge offset information to convert bus address to
>>>>> resource address in the fixup.
>>>>>
>>>>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>>>>> ---
>>>>
>>>>
>>>> I didn't see any messages about these getting picked up for 4.18.
>>>>
>>>> Are they queued on your own branch?
>>>>
>>>
>>> No, you never cc'ed me on them until now.
>>
>>
>> Ouch, I hoped that you would get it via get_maintainer script. Sorry
>> for
>> that.
>
> Actually, get_maintainer is right: this should go through the fbdev
> tree not the EFI tree
>
> Were you going to resend them? If not, I can find them in my archive
> and ack them, and we will ask Bartlomiej to take them for v4.19
I prefer ack rather than resend to be honest.
next prev parent reply other threads:[~2018-06-13 15:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 14:17 [PATCH V2 1/2] efi/fb: Simplify fixup code to prefer struct resource Sinan Kaya
2018-05-18 14:17 ` [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if translated by the bridge Sinan Kaya
2018-06-13 14:22 ` Sinan Kaya
2018-06-13 15:06 ` Ard Biesheuvel
2018-06-13 15:17 ` okaya
2018-06-13 15:22 ` Ard Biesheuvel
2018-06-13 15:29 ` okaya [this message]
2018-06-13 15:45 ` Ard Biesheuvel
2018-06-13 15:50 ` okaya
2018-06-13 16:08 ` Bartlomiej Zolnierkiewicz
2018-06-22 7:54 ` Ard Biesheuvel
[not found] ` <CGME20180622100749eucas1p2a47cfba3b4d3d5004e9a0068917d5616@eucas1p2.samsung.com>
2018-06-22 10:07 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20180622101111eucas1p119946679a7686911744b1296c2796b15@eucas1p1.samsung.com>
2018-06-22 10:11 ` Bartlomiej Zolnierkiewicz
2018-06-19 22:29 ` Bjorn Helgaas
2018-06-22 11:21 ` Ard Biesheuvel
2018-06-22 13:52 ` Sinan Kaya
2018-06-22 13:55 ` Ard Biesheuvel
2018-06-22 18:01 ` Ard Biesheuvel
2018-06-22 18:30 ` Sinan Kaya
2018-06-22 19:29 ` Ard Biesheuvel
2018-06-25 8:20 ` Ard Biesheuvel
2018-06-25 15:52 ` okaya
2018-06-25 17:28 ` Sinan Kaya
2018-06-25 17:29 ` Ard Biesheuvel
2018-06-25 17:31 ` Sinan Kaya
2018-06-13 15:42 ` [PATCH V2 1/2] efi/fb: Simplify fixup code to prefer struct resource Ard Biesheuvel
2018-06-22 10:11 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2be0216f218f9635595f39a8da3afad7@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=ard.biesheuvel@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).