linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block <linux-block@vger.kernel.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linus.walleij@linaro.org, bfq-iosched@googlegroups.com,
	oleksandr@natalenko.name
Subject: Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging
Date: Mon, 15 Jul 2019 12:49:30 +0200	[thread overview]
Message-ID: <2c15c4bc-145d-fb0d-ae5a-2a8ce36f977b@applied-asynchrony.com> (raw)
In-Reply-To: <B0406DB0-1003-4610-8A75-F3D7614C616E@linaro.org>

On 7/15/19 12:18 PM, Paolo Valente wrote:
> Didn't I simply move it forward in that commit?
> 
>> Il giorno 15 lug 2019, alle ore 12:16, Holger Hoffstätte <holger@applied-asynchrony.com> ha scritto:
>> Paolo,
>>
>> The function idling_needed_for_service_guarantees() was just removed in 5.3-commit
>> 3726112ec731 ("block, bfq: re-schedule empty queues if they deserve I/O plugging").

Argh, sorry - yes you did, it failed to apply because the asymmetric_scenario
variable was already gone. Fixing the patch to just return the expression so that
it matches 3726112ec731 worked.

All good!
Holger

  reply	other threads:[~2019-07-15 10:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15  9:31 [PATCH BUGFIX IMPROVEMENT 0/1] block, bfq: eliminate latency regression with fast drives Paolo Valente
2019-07-15  9:31 ` [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging Paolo Valente
2019-07-15 10:16   ` Holger Hoffstätte
2019-07-15 10:18     ` Paolo Valente
2019-07-15 10:49       ` Holger Hoffstätte [this message]
2019-07-15 10:53         ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c15c4bc-145d-fb0d-ae5a-2a8ce36f977b@applied-asynchrony.com \
    --to=holger@applied-asynchrony.com \
    --cc=axboe@kernel.dk \
    --cc=bfq-iosched@googlegroups.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    --cc=paolo.valente@linaro.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).