From: Paolo Valente <paolo.valente@linaro.org>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linus.walleij@linaro.org, bfq-iosched@googlegroups.com,
oleksandr@natalenko.name
Subject: Re: [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging
Date: Mon, 15 Jul 2019 12:53:38 +0200 [thread overview]
Message-ID: <B064EF63-B7F6-4BA3-BA0A-FF9579893971@linaro.org> (raw)
In-Reply-To: <2c15c4bc-145d-fb0d-ae5a-2a8ce36f977b@applied-asynchrony.com>
Ops, my fault of course. I submitted the patch I made on top of the dev version of bfq. Preparing a V2. Sorry.
> Il giorno 15 lug 2019, alle ore 12:49, Holger Hoffstätte <holger@applied-asynchrony.com> ha scritto:
>
> On 7/15/19 12:18 PM, Paolo Valente wrote:
>> Didn't I simply move it forward in that commit?
>>> Il giorno 15 lug 2019, alle ore 12:16, Holger Hoffstätte <holger@applied-asynchrony.com> ha scritto:
>>> Paolo,
>>>
>>> The function idling_needed_for_service_guarantees() was just removed in 5.3-commit
>>> 3726112ec731 ("block, bfq: re-schedule empty queues if they deserve I/O plugging").
>
> Argh, sorry - yes you did, it failed to apply because the asymmetric_scenario
> variable was already gone. Fixing the patch to just return the expression so that
> it matches 3726112ec731 worked.
>
> All good!
> Holger
prev parent reply other threads:[~2019-07-15 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 9:31 [PATCH BUGFIX IMPROVEMENT 0/1] block, bfq: eliminate latency regression with fast drives Paolo Valente
2019-07-15 9:31 ` [PATCH BUGFIX IMPROVEMENT 1/1] block, bfq: check also in-flight I/O in dispatch plugging Paolo Valente
2019-07-15 10:16 ` Holger Hoffstätte
2019-07-15 10:18 ` Paolo Valente
2019-07-15 10:49 ` Holger Hoffstätte
2019-07-15 10:53 ` Paolo Valente [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B064EF63-B7F6-4BA3-BA0A-FF9579893971@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=bfq-iosched@googlegroups.com \
--cc=holger@applied-asynchrony.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).