From: Jiada Wang <jiada_wang@mentor.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<apape@de.adit-jv.com>, <Mark_Craske@mentor.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus
Date: Thu, 1 Dec 2016 16:07:07 +0900 [thread overview]
Message-ID: <2c6bb9a2-89d8-f163-ec97-5d2feed858e9@mentor.com> (raw)
In-Reply-To: <s5hy4012vvf.wl-tiwai@suse.de>
Hi Takashi
On 11/30/2016 05:51 PM, Takashi Iwai wrote:
> On Wed, 30 Nov 2016 08:59:22 +0100,
> Jiada Wang wrote:
>>
>> From: Daniel Girnus <dgirnus@de.adit-jv.com>
>>
>> ALSA usually calls the prepare function twice before starting the playback:
>> 1. On hw_params call from userland and
>> 2. internally when starting the stream.
>> Some device are not able to manage this and they will stop playback
>> if the sample rate will be configured several times over USB protocol.
>>
>> Signed-off-by: Jens Lorenz <jlorenz@de.adit-jv.com>
>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
>
> The sign-off from Daniel seems missing?
>
> The code change looks OK, but it'd be nice to mention in the changelog
> that, after this patch, snd_usb_init_sample_rate() is still called
> properly whenever the parameter is changed since ep->need_setup_ep is
> set in snd_hsb_hw_params().
>
I will add missing sign-off and related information in changelog in v2
Thanks,
Jiada
>
> thanks,
>
> Takashi
>
>> ---
>> sound/usb/pcm.c | 21 +++++++++++----------
>> 1 file changed, 11 insertions(+), 10 deletions(-)
>>
>> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
>> index 44d178e..a522c9a 100644
>> --- a/sound/usb/pcm.c
>> +++ b/sound/usb/pcm.c
>> @@ -806,17 +806,18 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
>> if (ret < 0)
>> goto unlock;
>>
>> - iface = usb_ifnum_to_if(subs->dev, subs->cur_audiofmt->iface);
>> - alts = &iface->altsetting[subs->cur_audiofmt->altset_idx];
>> - ret = snd_usb_init_sample_rate(subs->stream->chip,
>> - subs->cur_audiofmt->iface,
>> - alts,
>> - subs->cur_audiofmt,
>> - subs->cur_rate);
>> - if (ret < 0)
>> - goto unlock;
>> -
>> if (subs->need_setup_ep) {
>> +
>> + iface = usb_ifnum_to_if(subs->dev, subs->cur_audiofmt->iface);
>> + alts = &iface->altsetting[subs->cur_audiofmt->altset_idx];
>> + ret = snd_usb_init_sample_rate(subs->stream->chip,
>> + subs->cur_audiofmt->iface,
>> + alts,
>> + subs->cur_audiofmt,
>> + subs->cur_rate);
>> + if (ret < 0)
>> + goto unlock;
>> +
>> ret = configure_endpoint(subs);
>> if (ret < 0)
>> goto unlock;
>> --
>> 2.9.3
>>
>>
next prev parent reply other threads:[~2016-12-01 7:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 7:59 [PATCH 0/3 v1] usb-misc fix Jiada Wang
2016-11-30 7:59 ` [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize Jiada Wang
2016-11-30 8:54 ` Takashi Iwai
2016-12-01 7:04 ` Jiada Wang
2016-12-01 7:41 ` [alsa-devel] " Clemens Ladisch
2016-12-01 8:58 ` Takashi Iwai
2016-12-01 11:16 ` Clemens Ladisch
2016-12-01 11:23 ` Takashi Iwai
2016-12-01 11:50 ` Clemens Ladisch
[not found] ` <58400B3A.7080806@mentor.com>
2016-12-01 12:15 ` Clemens Ladisch
2016-11-30 7:59 ` [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus Jiada Wang
2016-11-30 8:51 ` Takashi Iwai
2016-12-01 7:07 ` Jiada Wang [this message]
2016-11-30 10:45 ` Takashi Sakamoto
2016-11-30 22:19 ` Takashi Sakamoto
2016-12-05 7:32 ` Jiada Wang
2016-12-05 9:58 ` Takashi Sakamoto
2016-11-30 7:59 ` [PATCH 3/3 v3] ALSA: usb-audio: fix race in snd_usb_endpoint_stop Jiada Wang
2016-11-30 9:00 ` Takashi Iwai
2016-12-05 10:10 ` Jiada Wang
2016-12-05 10:30 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c6bb9a2-89d8-f163-ec97-5d2feed858e9@mentor.com \
--to=jiada_wang@mentor.com \
--cc=Mark_Craske@mentor.com \
--cc=alsa-devel@alsa-project.org \
--cc=apape@de.adit-jv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).