* [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter.
@ 2022-08-17 6:41 Duke Du
2022-08-17 12:28 ` Bagas Sanjaya
0 siblings, 1 reply; 4+ messages in thread
From: Duke Du @ 2022-08-17 6:41 UTC (permalink / raw)
To: jdelvare, linux, corbet, linux-hwmon, linux-doc, linux-kernel
Cc: fran.hsu, charles.hsu, george.hung, duke.du
make the PMBUS_VOUT_MODE return value 0x17,
VOUT returned value is linear11.
V2: Correct the tps546d24.rst format.
v1: Initial patchset.
Signed-off-by: Duke Du <Duke.Du@quantatw.com>
---
Documentation/hwmon/index.rst | 1 +
Documentation/hwmon/tps546d24.rst | 35 +++++++++++++++++++
MAINTAINERS | 7 ++++
drivers/hwmon/pmbus/Kconfig | 9 +++++
drivers/hwmon/pmbus/Makefile | 1 +
drivers/hwmon/pmbus/tps546d24.c | 73 +++++++++++++++++++++++++++++++++++++++
6 files changed, 126 insertions(+)
create mode 100644 Documentation/hwmon/tps546d24.rst
create mode 100644 drivers/hwmon/pmbus/tps546d24.c
diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
index f7113b0..d3eede4 100644
--- a/Documentation/hwmon/index.rst
+++ b/Documentation/hwmon/index.rst
@@ -205,6 +205,7 @@ Hardware Monitoring Kernel Drivers
tps23861
tps40422
tps53679
+ tps546d24
twl4030-madc-hwmon
ucd9000
ucd9200
diff --git a/Documentation/hwmon/tps546d24.rst b/Documentation/hwmon/tps546d24.rst
new file mode 100644
index 0000000..3061fd8
--- /dev/null
+++ b/Documentation/hwmon/tps546d24.rst
@@ -0,0 +1,35 @@
+.. SPDX-License-Identifier: GPL-2.0-only
+
+Kernel driver tps546d24
+======================
+
+Supported chips:
+
+ * TI TPS546D24
+
+ Prefix: 'tps546d24'
+
+ Addresses scanned: -
+
+ Datasheet: https://www.ti.com/lit/gpn/tps546d24
+
+Author: Duke Du <dukedu83@gmail.com>
+
+
+Description
+-----------
+
+The TPS546D24A is a highly integrated, non-isolated DC/DC converter capable
+of high frequency operation and 40-A current output from a 7-mm x 5-mm
+package.
+
+Two, three, and four TPS546D24A devices can be interconnected
+to provide up to 160 A on a single output. The device has an option to
+overdrive the internal 5-V LDO with an external 5-V supply via the VDD5
+pin to improve efficiency and reduce power dissipation of the converter.
+
+
+Platform data support
+---------------------
+
+The driver supports standard PMBus driver platform data.
diff --git a/MAINTAINERS b/MAINTAINERS
index 8a5012b..fa2d4fb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20583,6 +20583,13 @@ Q: https://patchwork.kernel.org/project/linux-integrity/list/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
F: drivers/char/tpm/
+TPS546D24 DRIVER
+M: Duke Du <dukedu83@gmail.com>
+L: linux-hwmon@vger.kernel.org
+S: Maintained
+F: Documentation/hwmon/tps546d24.rst
+F: drivers/hwmon/pmbus/tps546d24.c
+
TRACING
M: Steven Rostedt <rostedt@goodmis.org>
M: Ingo Molnar <mingo@redhat.com>
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index 951e4a9..89668af 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -397,6 +397,15 @@ config SENSORS_TPS53679
This driver can also be built as a module. If so, the module will
be called tps53679.
+config SENSORS_TPS546D24
+ tristate "TPS546D24"
+ help
+ If you say yes here you get hardware monitoring support for TEXAS
+ TPS546D24.
+
+ This driver can also be built as a module. If so, the module will
+ be called tps546d24
+
config SENSORS_UCD9000
tristate "TI UCD90120, UCD90124, UCD90160, UCD90320, UCD9090, UCD90910"
help
diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
index e2fe86f..0002dbe 100644
--- a/drivers/hwmon/pmbus/Makefile
+++ b/drivers/hwmon/pmbus/Makefile
@@ -41,6 +41,7 @@ obj-$(CONFIG_SENSORS_Q54SJ108A2) += q54sj108a2.o
obj-$(CONFIG_SENSORS_STPDDC60) += stpddc60.o
obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o
obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o
+obj-$(CONFIG_SENSORS_TPS546D24) += tps546d24.o
obj-$(CONFIG_SENSORS_UCD9000) += ucd9000.o
obj-$(CONFIG_SENSORS_UCD9200) += ucd9200.o
obj-$(CONFIG_SENSORS_XDPE122) += xdpe12284.o
diff --git a/drivers/hwmon/pmbus/tps546d24.c b/drivers/hwmon/pmbus/tps546d24.c
new file mode 100644
index 0000000..f6f79d3
--- /dev/null
+++ b/drivers/hwmon/pmbus/tps546d24.c
@@ -0,0 +1,73 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Hardware monitoring driver for TEXAS TPS546D24 buck converter
+ */
+
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/pmbus.h>
+#include "pmbus.h"
+
+static int tps546d24_read_byte_data(struct i2c_client *client, int page, int reg)
+{
+ int ret;
+
+ switch (reg) {
+ case PMBUS_VOUT_MODE:
+ ret = 0x17;
+ break;
+ default:
+ ret = -ENODATA;
+ break;
+ }
+ return ret;
+}
+
+static struct pmbus_driver_info tps546d24_info = {
+ .pages = 1,
+ .format[PSC_VOLTAGE_IN] = linear,
+ .format[PSC_VOLTAGE_OUT] = linear,
+ .format[PSC_TEMPERATURE] = linear,
+ .format[PSC_CURRENT_OUT] = linear,
+ .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN |
+ PMBUS_HAVE_IOUT | PMBUS_HAVE_VOUT |
+ PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_VOUT |
+ PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP,
+ .read_byte_data = tps546d24_read_byte_data,
+};
+
+static int tps546d24_probe(struct i2c_client *client)
+{
+ return pmbus_do_probe(client, &tps546d24_info);
+}
+
+static const struct i2c_device_id tps546d24_id[] = {
+ {"tps546d24", 0},
+ {}
+};
+MODULE_DEVICE_TABLE(i2c, tps546d24_id);
+
+static const struct of_device_id __maybe_unused tps546d24_of_match[] = {
+ {.compatible = "tps546d24"},
+ {}
+};
+
+/* This is the driver that will be inserted */
+static struct i2c_driver tps546d24_driver = {
+ .driver = {
+ .name = "tps546d24",
+ .of_match_table = of_match_ptr(tps546d24_of_match),
+ },
+ .probe_new = tps546d24_probe,
+ .id_table = tps546d24_id,
+};
+
+module_i2c_driver(tps546d24_driver);
+
+MODULE_AUTHOR("Duke Du <dukedu83@gmail.com>");
+MODULE_DESCRIPTION("PMBus driver for TI tps546d24");
+MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(PMBUS);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter.
2022-08-17 6:41 [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter Duke Du
@ 2022-08-17 12:28 ` Bagas Sanjaya
2022-08-17 12:47 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Bagas Sanjaya @ 2022-08-17 12:28 UTC (permalink / raw)
To: Duke Du, jdelvare, linux, corbet, linux-hwmon, linux-doc, linux-kernel
Cc: fran.hsu, charles.hsu, george.hung, duke.du
On 8/17/22 13:41, Duke Du wrote:
> make the PMBUS_VOUT_MODE return value 0x17,
> VOUT returned value is linear11.
>
> V2: Correct the tps546d24.rst format.
>
> v1: Initial patchset.
>
Seems like the patch description is just the changelog, which
should have been put between the dashes and diffstat. I would
like to see the proper description.
Thanks.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter.
2022-08-17 12:28 ` Bagas Sanjaya
@ 2022-08-17 12:47 ` Guenter Roeck
2022-08-17 12:53 ` Bagas Sanjaya
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2022-08-17 12:47 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Duke Du, jdelvare, corbet, linux-hwmon, linux-doc, linux-kernel,
fran.hsu, charles.hsu, george.hung, duke.du
On Wed, Aug 17, 2022 at 07:28:47PM +0700, Bagas Sanjaya wrote:
> On 8/17/22 13:41, Duke Du wrote:
> > make the PMBUS_VOUT_MODE return value 0x17,
> > VOUT returned value is linear11.
> >
> > V2: Correct the tps546d24.rst format.
> >
> > v1: Initial patchset.
> >
>
> Seems like the patch description is just the changelog, which
> should have been put between the dashes and diffstat. I would
> like to see the proper description.
>
Same here. The description doesn't mean anything, should
be a comment in the code, and, yes, the change log should
not be part of the description but follow after '---'.
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter.
2022-08-17 12:47 ` Guenter Roeck
@ 2022-08-17 12:53 ` Bagas Sanjaya
0 siblings, 0 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2022-08-17 12:53 UTC (permalink / raw)
To: Guenter Roeck
Cc: Duke Du, jdelvare, corbet, linux-hwmon, linux-doc, linux-kernel,
fran.hsu, charles.hsu, george.hung, duke.du
On 8/17/22 19:47, Guenter Roeck wrote:
>> Seems like the patch description is just the changelog, which
>> should have been put between the dashes and diffstat. I would
>> like to see the proper description.
>>
> Same here. The description doesn't mean anything, should
> be a comment in the code, and, yes, the change log should
> not be part of the description but follow after '---'.
>
I mean the patch description.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-17 12:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17 6:41 [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter Duke Du
2022-08-17 12:28 ` Bagas Sanjaya
2022-08-17 12:47 ` Guenter Roeck
2022-08-17 12:53 ` Bagas Sanjaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).