* [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
@ 2017-05-27 1:22 Murilo Opsfelder Araujo
2017-05-27 1:53 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Murilo Opsfelder Araujo @ 2017-05-27 1:22 UTC (permalink / raw)
To: linux-kernel
Cc: linux-watchdog, Guenter Roeck, Wim Van Sebroeck,
Michael Ellerman, Murilo Opsfelder Araujo
drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
setting CONFIG_PPC_RTAS throws the following errors:
ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
CONFIG_PPC_RTAS was not set. Logs are here:
http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
This patch fixes the issue by selecting CONFIG_PPC_RTAS when
CONFIG_WATCHDOG_RTAS is set.
Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 8b9049d..5d872145 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1689,6 +1689,7 @@ config MEN_A21_WDT
config WATCHDOG_RTAS
tristate "RTAS watchdog"
depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
+ select PPC_RTAS
help
This driver adds watchdog support for the RTAS watchdog.
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
2017-05-27 1:22 [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo
@ 2017-05-27 1:53 ` Guenter Roeck
2017-05-29 2:08 ` Michael Ellerman
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2017-05-27 1:53 UTC (permalink / raw)
To: Murilo Opsfelder Araujo, linux-kernel
Cc: linux-watchdog, Wim Van Sebroeck, Michael Ellerman
On 05/26/2017 06:22 PM, Murilo Opsfelder Araujo wrote:
> drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
> which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
> setting CONFIG_PPC_RTAS throws the following errors:
>
> ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
>
> This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
> CONFIG_PPC_RTAS was not set. Logs are here:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
>
> This patch fixes the issue by selecting CONFIG_PPC_RTAS when
> CONFIG_WATCHDOG_RTAS is set.
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 8b9049d..5d872145 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1689,6 +1689,7 @@ config MEN_A21_WDT
> config WATCHDOG_RTAS
> tristate "RTAS watchdog"
> depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
> + select PPC_RTAS
This can not at the same time depend on PPC_RTAS and select it.
Guess we'll have to drop COMPILE_TEST entirely.
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
2017-05-27 1:53 ` Guenter Roeck
@ 2017-05-29 2:08 ` Michael Ellerman
2017-05-29 13:30 ` Murilo Opsfelder Araújo
0 siblings, 1 reply; 4+ messages in thread
From: Michael Ellerman @ 2017-05-29 2:08 UTC (permalink / raw)
To: Guenter Roeck, Murilo Opsfelder Araujo, linux-kernel
Cc: linux-watchdog, Wim Van Sebroeck
Guenter Roeck <linux@roeck-us.net> writes:
> On 05/26/2017 06:22 PM, Murilo Opsfelder Araujo wrote:
>> drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
>> which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
>> setting CONFIG_PPC_RTAS throws the following errors:
>>
>> ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
>> ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
>> ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
>> ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
>> ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
>>
>> This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
>> CONFIG_PPC_RTAS was not set. Logs are here:
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
>>
>> This patch fixes the issue by selecting CONFIG_PPC_RTAS when
>> CONFIG_WATCHDOG_RTAS is set.
>>
>> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
>> ---
>> drivers/watchdog/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index 8b9049d..5d872145 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -1689,6 +1689,7 @@ config MEN_A21_WDT
>> config WATCHDOG_RTAS
>> tristate "RTAS watchdog"
>> depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
>> + select PPC_RTAS
>
> This can not at the same time depend on PPC_RTAS and select it.
> Guess we'll have to drop COMPILE_TEST entirely.
We could stub out the RTAS pieces it needs. But I don't think it buys us
much, for compile testing you may as well just build a config which has
PPC_RTAS enabled, there are several.
So I think it should just depend on PPC_RTAS.
Murilo can you send a v2?
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
2017-05-29 2:08 ` Michael Ellerman
@ 2017-05-29 13:30 ` Murilo Opsfelder Araújo
0 siblings, 0 replies; 4+ messages in thread
From: Murilo Opsfelder Araújo @ 2017-05-29 13:30 UTC (permalink / raw)
To: Michael Ellerman, Guenter Roeck, linux-kernel
Cc: linux-watchdog, Wim Van Sebroeck
On 05/28/2017 11:08 PM, Michael Ellerman wrote:
[...]
> We could stub out the RTAS pieces it needs. But I don't think it buys us
> much, for compile testing you may as well just build a config which has
> PPC_RTAS enabled, there are several.
>
> So I think it should just depend on PPC_RTAS.
>
> Murilo can you send a v2?
>
> cheers
Thanks, Guenter and Michael, for reviewing!
I sent out a v2.
--
Murilo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-29 13:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-27 1:22 [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo
2017-05-27 1:53 ` Guenter Roeck
2017-05-29 2:08 ` Michael Ellerman
2017-05-29 13:30 ` Murilo Opsfelder Araújo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).