From: Crestez Dan Leonard <leonard.crestez@intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-i2c@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
Octavian Purdila <octavian.purdila@intel.com>,
Jarkko Nikula <jarkko.nikula@intel.com>
Subject: Re: [PATCH 2/3] acpi i2c: Initialize info.type from of_compatible
Date: Fri, 17 Jun 2016 15:07:39 +0300 [thread overview]
Message-ID: <2ca8f355-bb28-8b68-7579-e26eaee3550a@intel.com> (raw)
In-Reply-To: <20160616081145.GU1740@lahna.fi.intel.com>
On 06/16/2016 11:11 AM, Mika Westerberg wrote:
> On Wed, Jun 15, 2016 at 09:30:28PM +0300, Crestez Dan Leonard wrote:
>> When using devicetree i2c_board_info.type is set to the compatible
>> string with the vendor prefix removed. For I2C devices described via
>> ACPI the i2c_board_info.type string is set to the ACPI device name. When
>> using ACPI and DT ids this string ends up something like "PRP0001:00".
>>
>> If the of_compatible property is present try to use that instead. This
>> makes it easier to instantiate i2c drivers through ACPI with DT ids.
>
> Adding Jarkko -- he was the original author of I2C/SPI device naming in
> ACPI. Since this only affects devices with PRP0001 in their _HID/_CID,
> it should not break anything.
It's possible to have something like this:
Name (_HID, "XXX1234")
Name (_CID, "PRP0001")
Name (_DSD, Package () {
ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
Package () {
Package () {"compatible", "vendor,x1234"},
}
})
With these patches the i2c device name changes from "XXX1234:00" to
"x1234". This would happen even if a driver matches the XXX1234 acpi ID.
It's not clear if anyone actually uses that or if this change would be
harmful.
It theory it would be possible to use of_compatible for naming only if
there are no other real IDs. I don't think it's worthwhile.
next prev parent reply other threads:[~2016-06-17 12:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 18:30 [PATCH 0/3] Init device ids from ACPI of_compatible Crestez Dan Leonard
2016-06-15 18:30 ` [PATCH 1/3] acpi: Export acpi_of_modalias equiv of of_modalias_node Crestez Dan Leonard
2016-06-16 8:04 ` Mika Westerberg
2016-06-15 18:30 ` [PATCH 2/3] acpi i2c: Initialize info.type from of_compatible Crestez Dan Leonard
2016-06-16 8:11 ` Mika Westerberg
2016-06-17 12:07 ` Crestez Dan Leonard [this message]
2016-06-17 12:19 ` Mika Westerberg
2016-06-15 18:30 ` [PATCH 3/3] acpi spi: Initialize modalias " Crestez Dan Leonard
2016-06-16 8:12 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ca8f355-bb28-8b68-7579-e26eaee3550a@intel.com \
--to=leonard.crestez@intel.com \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=octavian.purdila@intel.com \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).