From: James Clark <james.clark@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [RFC V1 10/11] perf: Expand perf_branch_entry.type
Date: Tue, 25 Jan 2022 16:58:20 +0000 [thread overview]
Message-ID: <2d7297b3-9a22-626b-9840-a4eaab4b94e8@arm.com> (raw)
In-Reply-To: <1642998653-21377-11-git-send-email-anshuman.khandual@arm.com>
On 24/01/2022 04:30, Anshuman Khandual wrote:
> Current perf_branch_entry.type is a 4 bits field just enough to accommodate
> 16 generic branch types. This is insufficient to accommodate platforms like
> arm64 which has much more branch types. Lets just expands this field into a
> 6 bits one, which can now hold 64 generic branch types. This also adds more
> generic branch types and updates the BRBE driver as required.
>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Will Deacon <will@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-perf-users@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> drivers/perf/arm_pmu_brbe.c | 7 ++++++-
> include/uapi/linux/perf_event.h | 10 ++++++++--
> tools/include/uapi/linux/perf_event.h | 10 ++++++++--
> tools/perf/util/branch.c | 8 +++++++-
> 4 files changed, 29 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/perf/arm_pmu_brbe.c b/drivers/perf/arm_pmu_brbe.c
> index 8d27ad868359..7cd1208c6c58 100644
> --- a/drivers/perf/arm_pmu_brbe.c
> +++ b/drivers/perf/arm_pmu_brbe.c
> @@ -253,12 +253,17 @@ static int brbe_fetch_perf_type(u64 brbinf)
> case BRBINF_TYPE_DEBUG_EXIT:
> return PERF_BR_DEBUG_EXIT;
> case BRBINF_TYPE_SERROR:
> + return PERF_BR_SERROR;
> case BRBINF_TYPE_INST_DEBUG:
> + return PERF_BR_DEBUG_INST;
> case BRBINF_TYPE_DATA_DEBUG:
> + return PERF_BR_DEBUG_DATA;
> case BRBINF_TYPE_ALGN_FAULT:
> + return PERF_BR_FAULT_ALGN;
> case BRBINF_TYPE_INST_FAULT:
> + return PERF_BR_FAULT_INST;
> case BRBINF_TYPE_DATA_FAULT:
> - return PERF_BR_UNKNOWN;
> + return PERF_BR_FAULT_DATA;
> default:
> pr_warn("unknown branch type captured\n");
> return PERF_BR_UNKNOWN;
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index b91d0f575d0c..361fdc6b87a0 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -256,6 +256,12 @@ enum {
> PERF_BR_FIQ = 13, /* fiq */
> PERF_BR_DEBUG_HALT = 14, /* debug halt */
> PERF_BR_DEBUG_EXIT = 15, /* debug exit */
> + PERF_BR_DEBUG_INST = 16, /* instruciton debug */
> + PERF_BR_DEBUG_DATA = 17, /* data debug */
> + PERF_BR_FAULT_ALGN = 18, /* alignment fault */
> + PERF_BR_FAULT_DATA = 19, /* data fault */
> + PERF_BR_FAULT_INST = 20, /* instruction fault */
> + PERF_BR_SERROR = 21, /* system error */
> PERF_BR_MAX,
> };
>
> @@ -1370,8 +1376,8 @@ struct perf_branch_entry {
> in_tx:1, /* in transaction */
> abort:1, /* transaction abort */
> cycles:16, /* cycle count to last branch */
> - type:4, /* branch type */
> - reserved:40;
> + type:6, /* branch type */
> + reserved:38;
> };
>
> union perf_sample_weight {
> diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h
> index 1882054e8684..9a82b8aaed93 100644
> --- a/tools/include/uapi/linux/perf_event.h
> +++ b/tools/include/uapi/linux/perf_event.h
> @@ -256,6 +256,12 @@ enum {
> PERF_BR_FIQ = 13, /* fiq */
> PERF_BR_DEBUG_HALT = 14, /* debug halt */
> PERF_BR_DEBUG_EXIT = 15, /* debug exit */
> + PERF_BR_DEBUG_INST = 16, /* instruciton debug */
> + PERF_BR_DEBUG_DATA = 17, /* data debug */
> + PERF_BR_FAULT_ALGN = 18, /* alignment fault */
> + PERF_BR_FAULT_DATA = 19, /* data fault */
> + PERF_BR_FAULT_INST = 20, /* instruction fault */
> + PERF_BR_SERROR = 21, /* system error */
> PERF_BR_MAX,
> };
>
> @@ -1370,8 +1376,8 @@ struct perf_branch_entry {
> in_tx:1, /* in transaction */
> abort:1, /* transaction abort */
> cycles:16, /* cycle count to last branch */
> - type:4, /* branch type */
> - reserved:40;
> + type:6, /* branch type */
> + reserved:38;
> };
There's another copy of this struct in branch.h that is used to access the same data in
perf which also needs updating:
struct branch_flags {
union {
u64 value;
struct {
u64 mispred:1;
u64 predicted:1;
u64 in_tx:1;
u64 abort:1;
u64 cycles:16;
u64 type:4;
u64 reserved:40;
};
};
};
It's never assigned directly but there is some casting stuff going on in
evsel__parse_sample() and it eventually ends up being used to access branch
records. Same applies to the privilege data change.
>
> union perf_sample_weight {
> diff --git a/tools/perf/util/branch.c b/tools/perf/util/branch.c
> index 74e5e67b1779..1e216ea2e2a8 100644
> --- a/tools/perf/util/branch.c
> +++ b/tools/perf/util/branch.c
> @@ -54,7 +54,13 @@ const char *branch_type_name(int type)
> "IRQ",
> "FIQ",
> "DEBUG_HALT",
> - "DEBUG_EXIT"
> + "DEBUG_EXIT",
> + "DEBUG_INST",
> + "DEBUG_DATA",
> + "FAULT_ALGN",
> + "FAULT_DATA",
> + "FAULT_INST",
> + "SERROR"
> };
>
> if (type >= 0 && type < PERF_BR_MAX)
>
next prev parent reply other threads:[~2022-01-25 17:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 4:30 [RFC V1 00/11] arm64/perf: Enable branch stack sampling Anshuman Khandual
2022-01-24 4:30 ` [RFC V1 01/11] perf: Consolidate branch sample filter helpers Anshuman Khandual
2022-01-24 4:30 ` [RFC V1 02/11] arm64/perf: Add register definitions for BRBE Anshuman Khandual
2022-01-24 14:05 ` Marc Zyngier
2022-01-25 5:04 ` Anshuman Khandual
2022-01-24 4:30 ` [RFC V1 03/11] arm64/perf: Update struct arm_pmu " Anshuman Khandual
2022-01-26 16:59 ` Rob Herring
2022-01-28 3:38 ` Anshuman Khandual
2022-01-24 4:30 ` [RFC V1 04/11] arm64/perf: Update struct pmu_hw_events " Anshuman Khandual
2022-01-24 4:30 ` [RFC V1 05/11] arm64/perf: Detect support " Anshuman Khandual
2022-01-26 17:18 ` Rob Herring
2022-01-28 3:27 ` Anshuman Khandual
2022-01-24 4:30 ` [RFC V1 06/11] arm64/perf: Drive BRBE from perf event states Anshuman Khandual
2022-01-26 17:07 ` Rob Herring
2022-01-27 12:20 ` Anshuman Khandual
2022-01-27 14:31 ` Rob Herring
2022-01-24 4:30 ` [RFC V1 07/11] arm64/perf: Add BRBE driver Anshuman Khandual
2022-01-24 18:11 ` James Clark
2022-01-24 18:15 ` James Clark
2022-01-24 4:30 ` [RFC V1 08/11] arm64/perf: Enable branch stack sampling Anshuman Khandual
2022-01-24 18:02 ` James Clark
2022-01-24 4:30 ` [RFC V1 09/11] perf: Add more generic branch types Anshuman Khandual
2022-01-24 4:30 ` [RFC V1 10/11] perf: Expand perf_branch_entry.type Anshuman Khandual
2022-01-25 16:58 ` James Clark [this message]
2022-01-28 4:14 ` Anshuman Khandual
2022-01-26 16:47 ` Rob Herring
2022-01-27 10:41 ` Anshuman Khandual
2022-01-24 4:30 ` [RFC V1 11/11] perf: Capture branch privilege information Anshuman Khandual
2022-01-25 15:39 ` James Clark
2022-02-02 11:11 ` Anshuman Khandual
2022-01-26 17:27 ` James Clark
2022-03-14 6:47 ` Anshuman Khandual
2022-01-25 16:25 ` [PATCH 0/1] perf test: Add branch stack sampling tests for ARM64 German Gomez
2022-01-25 16:25 ` [PATCH 1/1] " German Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d7297b3-9a22-626b-9840-a4eaab4b94e8@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).