* [PATCH] i2c: designware: Fix unused variable warning in i2c_dw_init_recovery_info
@ 2019-08-06 7:50 Gustavo A. R. Silva
2019-08-06 8:36 ` Jarkko Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-06 7:50 UTC (permalink / raw)
To: Jarkko Nikula, Andy Shevchenko, Mika Westerberg, Uwe Kleine-König
Cc: linux-i2c, linux-kernel, Gustavo A. R. Silva
Fix the following warning:
drivers/i2c/busses/i2c-designware-master.c: In function ‘i2c_dw_init_recovery_info’:
drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable ‘r’ [-Wunused-variable]
int r;
^
Fixes: 33eb09a02e8d ("i2c: designware: make use of devm_gpiod_get_optional")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/i2c/busses/i2c-designware-master.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index 867787dade43..e8b328242256 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -655,7 +655,6 @@ static int i2c_dw_init_recovery_info(struct dw_i2c_dev *dev)
struct i2c_bus_recovery_info *rinfo = &dev->rinfo;
struct i2c_adapter *adap = &dev->adapter;
struct gpio_desc *gpio;
- int r;
gpio = devm_gpiod_get_optional(dev->dev, "scl", GPIOD_OUT_HIGH);
if (IS_ERR_OR_NULL(gpio))
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: designware: Fix unused variable warning in i2c_dw_init_recovery_info
2019-08-06 7:50 [PATCH] i2c: designware: Fix unused variable warning in i2c_dw_init_recovery_info Gustavo A. R. Silva
@ 2019-08-06 8:36 ` Jarkko Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Nikula @ 2019-08-06 8:36 UTC (permalink / raw)
To: Gustavo A. R. Silva, Andy Shevchenko, Mika Westerberg,
Uwe Kleine-König
Cc: linux-i2c, linux-kernel
Hi
On 8/6/19 10:50 AM, Gustavo A. R. Silva wrote:
> Fix the following warning:
>
> drivers/i2c/busses/i2c-designware-master.c: In function ‘i2c_dw_init_recovery_info’:
> drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable ‘r’ [-Wunused-variable]
> int r;
> ^
>
> Fixes: 33eb09a02e8d ("i2c: designware: make use of devm_gpiod_get_optional")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
This was fixed yesterday, not applied yet though:
https://www.spinics.net/lists/linux-i2c/msg41651.html
--
Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-06 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06 7:50 [PATCH] i2c: designware: Fix unused variable warning in i2c_dw_init_recovery_info Gustavo A. R. Silva
2019-08-06 8:36 ` Jarkko Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).