[PATCH] scsi: remove useless acpi functions in the head file

[PATCH] scsi: remove useless acpi functions in the head file

[Hanjun Guo]

From: Hanjun Guo <hanjun.guo@linaro.org>

commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
but forgot to remove them in the head file, do it now.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
 include/scsi/scsi.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index 8ec7c30..a1e1930 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -29,16 +29,6 @@ enum scsi_timeouts {
  */
 #define SCAN_WILD_CARD	~0
 
-#ifdef CONFIG_ACPI
-struct acpi_bus_type;
-
-extern int
-scsi_register_acpi_bus_type(struct acpi_bus_type *bus);
-
-extern void
-scsi_unregister_acpi_bus_type(struct acpi_bus_type *bus);
-#endif
-
 /** scsi_status_is_good - check the status return.
  *
  * @status: the status passed up from the driver (including host and
-- 
1.7.12.4

Re: [PATCH] scsi: remove useless acpi functions in the head file

[John Garry]

On 10/01/2017 08:14, Hanjun Guo wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
>
> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
> but forgot to remove them in the head file, do it now.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
>  include/scsi/scsi.h | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
> index 8ec7c30..a1e1930 100644
> --- a/include/scsi/scsi.h
> +++ b/include/scsi/scsi.h
> @@ -29,16 +29,6 @@ enum scsi_timeouts {
>   */
>  #define SCAN_WILD_CARD	~0
>
> -#ifdef CONFIG_ACPI
> -struct acpi_bus_type;
> -
> -extern int
> -scsi_register_acpi_bus_type(struct acpi_bus_type *bus);
> -
> -extern void
> -scsi_unregister_acpi_bus_type(struct acpi_bus_type *bus);
> -#endif
> -
>  /** scsi_status_is_good - check the status return.
>   *
>   * @status: the status passed up from the driver (including host and
>

Looks ok,

Reviewed-by: John Garry <john.garry@huawei.com>

Re: [PATCH] scsi: remove useless acpi functions in the head file

[Johannes Thumshirn]

On Tue, Jan 10, 2017 at 04:14:04PM +0800, Hanjun Guo wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
> 
> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
> but forgot to remove them in the head file, do it now.
                                   ^
				   header?
> 
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---

Otherwise,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH] scsi: remove useless acpi functions in the head file

[Hanjun Guo]

On 2017/1/10 19:51, Johannes Thumshirn wrote:
> On Tue, Jan 10, 2017 at 04:14:04PM +0800, Hanjun Guo wrote:
>> From: Hanjun Guo <hanjun.guo@linaro.org>
>>
>> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
>> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
>> but forgot to remove them in the head file, do it now.
>                                    ^
> 				   header?

Yes, will update the patch.

>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> ---
> Otherwise,
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

Thanks!
Hanjun

Re: [PATCH] scsi: remove useless acpi functions in the head file

[Aaron Lu]

On 01/10/2017 07:44 PM, John Garry wrote:
> On 10/01/2017 08:14, Hanjun Guo wrote:
>> From: Hanjun Guo <hanjun.guo@linaro.org>
>>
>> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
>> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
>> but forgot to remove them in the head file, do it now.
>>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>

Reviewed-by: Aaron Lu <aaron.lu@intel.com>

Just out of curiosity, did you find this by some tool? If so, can you
please let me know the tool name so that I can avoid such problems in
the future? Thanks.

-Aaron

>> ---
>>  include/scsi/scsi.h | 10 ----------
>>  1 file changed, 10 deletions(-)
>>
>> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
>> index 8ec7c30..a1e1930 100644
>> --- a/include/scsi/scsi.h
>> +++ b/include/scsi/scsi.h
>> @@ -29,16 +29,6 @@ enum scsi_timeouts {
>>   */
>>  #define SCAN_WILD_CARD	~0
>>
>> -#ifdef CONFIG_ACPI
>> -struct acpi_bus_type;
>> -
>> -extern int
>> -scsi_register_acpi_bus_type(struct acpi_bus_type *bus);
>> -
>> -extern void
>> -scsi_unregister_acpi_bus_type(struct acpi_bus_type *bus);
>> -#endif
>> -
>>  /** scsi_status_is_good - check the status return.
>>   *
>>   * @status: the status passed up from the driver (including host and
>>
> 
> Looks ok,
> 
> Reviewed-by: John Garry <john.garry@huawei.com>
> 

Re: [PATCH] scsi: remove useless acpi functions in the head file

[Hanjun Guo]

On 2017/1/11 9:50, Aaron Lu wrote:
> On 01/10/2017 07:44 PM, John Garry wrote:
>> On 10/01/2017 08:14, Hanjun Guo wrote:
>>> From: Hanjun Guo <hanjun.guo@linaro.org>
>>>
>>> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
>>> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
>>> but forgot to remove them in the head file, do it now.
>>>
>>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> Reviewed-by: Aaron Lu <aaron.lu@intel.com>
>
> Just out of curiosity, did you find this by some tool? If so, can you
> please let me know the tool name so that I can avoid such problems in
> the future? Thanks.

No, not found by tool. I was working on a patch set which tried to
introduce a new acpi bus type [1], so I greped the usage of
"struct acpi_bus_type" then found this issue :)

[1]: https://lkml.org/lkml/2016/12/31/40

Thanks
Hanjun

Re: [PATCH] scsi: remove useless acpi functions in the head file

[Aaron Lu]

On 01/11/2017 10:15 AM, Hanjun Guo wrote:
> On 2017/1/11 9:50, Aaron Lu wrote:
>> On 01/10/2017 07:44 PM, John Garry wrote:
>>> On 10/01/2017 08:14, Hanjun Guo wrote:
>>>> From: Hanjun Guo <hanjun.guo@linaro.org>
>>>>
>>>> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
>>>> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
>>>> but forgot to remove them in the head file, do it now.
>>>>
>>>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> Reviewed-by: Aaron Lu <aaron.lu@intel.com>
>>
>> Just out of curiosity, did you find this by some tool? If so, can you
>> please let me know the tool name so that I can avoid such problems in
>> the future? Thanks.
> 
> No, not found by tool. I was working on a patch set which tried to
> introduce a new acpi bus type [1], so I greped the usage of
> "struct acpi_bus_type" then found this issue :)

I see, thanks for the cleanup.

Regards,
Aaron