From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan Brattlof <bb@ti.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Keerthy <j-keerthy@ti.com>,
Linux Thermal <linux-pm@vger.kernel.org>,
Linux Device Tree <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 06/11] dt-bindings: thermal: k3-j72xx: conditionally require efuse reg range
Date: Wed, 12 Oct 2022 09:38:26 -0400 [thread overview]
Message-ID: <2eaae603-9726-290e-7c9d-67b89256140c@linaro.org> (raw)
In-Reply-To: <20221011231727.8090-7-bb@ti.com>
On 11/10/2022 19:17, Bryan Brattlof wrote:
> Only some of TI's J721E SoCs will need a eFuse register range mapped to
> determine if they're affected by TI's i2128 erratum. All other SoC will
> not need this eFuse range to be mapped to function properly
>
> Update the bindings for the k3_j72xx_bandgap thermal driver so other
> devices will only need to define two register ranges
>
> Signed-off-by: Bryan Brattlof <bb@ti.com>
> ---
> .../bindings/thermal/ti,j72xx-thermal.yaml | 34 +++++++++++++------
> 1 file changed, 24 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> index 0b6a6fa07a532..387628ab35959 100644
> --- a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> @@ -33,16 +33,6 @@ properties:
> - ti,j721e-vtm
> - ti,j7200-vtm
>
> - reg:
No, keep entire part here.
with minItems:2
> - items:
> - - description: VTM cfg1 register space
> - - description: VTM cfg2 register space
> - - description: |
> - A software trimming method must be applied to some Jacinto
> - devices to function properly. This eFuse region provides
> - the information needed for these SoCs to report
> - temperatures accurately.
> -
> power-domains:
> description: |
> Should contain the phandle to a power management (PM) domain
> @@ -52,6 +42,30 @@ properties:
> "#thermal-sensor-cells":
> const: 1
>
> +if:
Put it under allOf.
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,j721e-vtm
> +then:
> + properties:
> + reg:
> + items:
> + - description: VTM cfg1 register space
> + - description: VTM cfg2 register space
> + - description: |
> + A software trimming method must be applied to some Jacinto
> + devices to function properly. This eFuse region provides
> + the information needed for these SoCs to report
> + temperatures accurately.
Instead:
minItems: 3
> +else:
> + properties:
> + reg:
> + items:
> + - description: VTM cfg1 register space
> + - description: VTM cfg2 register space
Instead:
maxItems: 2
> +
> required:
> - compatible
> - reg
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-12 13:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 23:17 [PATCH 00/11] enable VTM node of all TI's K3 SoCs Bryan Brattlof
2022-10-11 23:17 ` [PATCH 01/11] thermal: k3_j72xx_bandgap: simplify k3_thermal_get_temp() function Bryan Brattlof
2022-10-11 23:17 ` [PATCH 02/11] thermal: k3_j72xx_bandgap: use bool for i2128 erratum flag Bryan Brattlof
2022-10-11 23:17 ` [PATCH 03/11] thermal: k3_j72xx_bandgap: remove fuse_base from structure Bryan Brattlof
2022-10-11 23:17 ` [PATCH 04/11] thermal: k3_j72xx_bandgap: map fuse_base only for erratum workaround Bryan Brattlof
2022-10-11 23:17 ` [PATCH 05/11] dt-bindings: thermal: k3-j72xx: elaborate on binding descriptions Bryan Brattlof
2022-10-12 13:36 ` Krzysztof Kozlowski
2022-10-12 18:19 ` Bryan Brattlof
2022-10-13 23:30 ` Krzysztof Kozlowski
2022-10-11 23:17 ` [PATCH 06/11] dt-bindings: thermal: k3-j72xx: conditionally require efuse reg range Bryan Brattlof
2022-10-12 13:19 ` Rob Herring
2022-10-12 13:38 ` Krzysztof Kozlowski [this message]
2022-10-12 18:15 ` Bryan Brattlof
2022-10-12 13:39 ` Krzysztof Kozlowski
2022-10-11 23:17 ` [PATCH 07/11] arm64: dts: ti: k3-am64-main: add VTM node Bryan Brattlof
2022-10-11 23:17 ` [PATCH 08/11] arm64: dts: ti: k3-am62-wakeup: " Bryan Brattlof
2022-10-11 23:17 ` [PATCH 09/11] arm64: dts: ti: k3-j721e-mcu-wakeup: " Bryan Brattlof
2022-10-11 23:17 ` [PATCH 10/11] arm64: dts: ti: k3-j721s2-mcu-wakeup: " Bryan Brattlof
2022-10-11 23:17 ` [PATCH 11/11] arm64: dts: ti: k3-j7200-mcu-wakeup: " Bryan Brattlof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eaae603-9726-290e-7c9d-67b89256140c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amitk@kernel.org \
--cc=bb@ti.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).