* Re: [PATCH] mailbox: armada-37xx-rwtm: Remove duplicate error messages in armada_37xx_mbox_probe()
@ 2020-04-03 19:45 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-04-03 19:45 UTC (permalink / raw)
To: Tang Bin, Jassi Brar; +Cc: linux-kernel, kernel-janitors
> In this function,we don't need dev_err() message because when something
> goes wrong,platform_get_irq() and devm_platform_ioremap_resource() have
> print an error message itself, so we should remove duplicate dev_err().
I suggest further fine-tuning also for this commit message.
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-03 19:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 19:45 [PATCH] mailbox: armada-37xx-rwtm: Remove duplicate error messages in armada_37xx_mbox_probe() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).