From: stefan.mavrodiev@gmail.com
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Stefan Mavrodiev <stefan.mavrodiev@gmail.com>,
dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino
Date: Wed, 27 Jul 2016 08:12:29 +0300 [thread overview]
Message-ID: <30014119.IrjfP0xFry@linux-cigu> (raw)
In-Reply-To: <20160726153352.GH7190@lukather>
On Tuesday, July 26, 2016 5:33:52 PM EEST Maxime Ripard wrote:
> Hi Stefan,
>
> On Mon, Jul 25, 2016 at 03:37:23PM +0300, Stefan Mavrodiev wrote:
> > A33-OLinuXino is A33 development board designed by Olimex LTD.
> >
> > It has AXP233 PMU, 1GB DRAM, a micro SD card, one USB-OTG connector,
> > headphone and mic jacks, connector for LiPo battery and optional
> > 4GB NAND Flash.
> >
> > It has two 40-pin headers. One for LCD panel, and one for
> > additional modules. Also there is CSI/DSI connector.
> >
> > Signed-off-by: Stefan Mavrodiev <stefan.mavrodiev@gmail.com>
>
> It looks mostly good, a few comments though.
>
> > +&pio {
> > + led_pin_olinuxino: led_pins@0 {
> > + allwinner,pins = "PB7";
> > + allwinner,function = "gpio_out";
>
> This line is not properly indented.
>
> > + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> > + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> > + };
>
> And this one too.
>
> > +®_dc1sw {
> > + regulator-name = "vcc-lcd";
> > +};
>
> No constraints on this one?
>
> > +®_dcdc1 {
> > + regulator-always-on;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "vcc-dsi";
> > +};
>
> What is it used for? Is it really necessary to keep it on at all time?
I think so.
This is the supply for the MMC.
>
> Thanks,
> Maxime
Best regards,
Stefan Mavrodiev
next prev parent reply other threads:[~2016-07-27 5:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 12:37 [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino Stefan Mavrodiev
2016-07-26 15:33 ` Maxime Ripard
2016-07-27 5:12 ` stefan.mavrodiev [this message]
2016-07-27 6:21 ` Maxime Ripard
2016-07-27 10:02 ` stefan.mavrodiev
2016-07-28 17:53 ` Maxime Ripard
2016-08-15 7:36 ` [PATCH v5] " Stefan Mavrodiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30014119.IrjfP0xFry@linux-cigu \
--to=stefan.mavrodiev@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dt@kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).