From: stefan.mavrodiev@gmail.com
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: stefan.mavrodiev@gmail.com, dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@armlinux.org.uk, wens@csie.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino
Date: Wed, 27 Jul 2016 13:02:41 +0300 [thread overview]
Message-ID: <1604486.mrBvLz4HRZ@linux-cigu> (raw)
In-Reply-To: <20160727062146.GA6560@lukather>
On Wednesday, July 27, 2016 8:21:46 AM EEST Maxime Ripard wrote:
> On Wed, Jul 27, 2016 at 08:12:29AM +0300, stefan.mavrodiev@gmail.com wrote:
> > > > +®_dcdc1 {
> > > > + regulator-always-on;
> > > > + regulator-min-microvolt = <3300000>;
> > > > + regulator-max-microvolt = <3300000>;
> > > > + regulator-name = "vcc-dsi";
> > > > +};
> > >
> > > What is it used for? Is it really necessary to keep it on at all time?
> >
> > I think so.
> > This is the supply for the MMC.
>
> Then it's poorly named, and you should tie it to the MMC, and remove
> the always-on if it's only used by the mmc. always-on is supposed to
> be for regulators that shouldn't but turned off for the system to stay
> running. Some MMC regulator doesn't fit that description.
>
It's named upon the A33 power pin - "VCC-DSI".
If I remove "always-on" the board still will work, since dcdc1 is tied to
mmc0.
vmmc-supply = <®_dcdc1>;
We assume this voltage will be always present and there are some pullups that
are tied to it (on i2c0 and i2c1 bus). In this case should I remove "always-
on" from the regulator node?
> Maxime
Best regards,
Stefan Mavrodiev
next prev parent reply other threads:[~2016-07-27 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 12:37 [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino Stefan Mavrodiev
2016-07-26 15:33 ` Maxime Ripard
2016-07-27 5:12 ` stefan.mavrodiev
2016-07-27 6:21 ` Maxime Ripard
2016-07-27 10:02 ` stefan.mavrodiev [this message]
2016-07-28 17:53 ` Maxime Ripard
2016-08-15 7:36 ` [PATCH v5] " Stefan Mavrodiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604486.mrBvLz4HRZ@linux-cigu \
--to=stefan.mavrodiev@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dt@kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).