[PATCH] ARM: socfpga_defconfig: enable support for large block devices

[PATCH] ARM: socfpga_defconfig: enable support for large block devices

[Andrey Zhizhikin]

Enable CONFIG_LBDAF, which is required by ext4 fs. This option could
hanle both ext3 and ext4, and ex4 requires this option to be enabled,
otherwise the filesystem is mounted RO mode.

Signed-off-by: Andrey Zhizhikin <andrey.z@gmail.com>
---
 arch/arm/configs/socfpga_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
index 08d1b3e11d68..b4b387486cd9 100644
--- a/arch/arm/configs/socfpga_defconfig
+++ b/arch/arm/configs/socfpga_defconfig
@@ -21,7 +21,7 @@ CONFIG_NEON=y
 CONFIG_OPROFILE=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
-# CONFIG_LBDAF is not set
+CONFIG_LBDAF=y
 # CONFIG_BLK_DEV_BSG is not set
 CONFIG_NET=y
 CONFIG_PACKET=y
-- 
2.17.1

Re: [PATCH] ARM: socfpga_defconfig: enable support for large block devices

[Dinh Nguyen]

Hi Andrey,

On 2/22/19 6:21 AM, Andrey Zhizhikin wrote:
> Enable CONFIG_LBDAF, which is required by ext4 fs. This option could
> hanle both ext3 and ext4, and ex4 requires this option to be enabled,
> otherwise the filesystem is mounted RO mode.
> 
> Signed-off-by: Andrey Zhizhikin <andrey.z@gmail.com>
> ---
>  arch/arm/configs/socfpga_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
> index 08d1b3e11d68..b4b387486cd9 100644
> --- a/arch/arm/configs/socfpga_defconfig
> +++ b/arch/arm/configs/socfpga_defconfig
> @@ -21,7 +21,7 @@ CONFIG_NEON=y
>  CONFIG_OPROFILE=y
>  CONFIG_MODULES=y
>  CONFIG_MODULE_UNLOAD=y
> -# CONFIG_LBDAF is not set

CONFIG_LDBAF is turned on by default for 32-bit. So all you have to do
is remove this line.

Thanks,
Dinh

Re: [PATCH] ARM: socfpga_defconfig: enable support for large block devices

[Andrey Zhizhikin]

Hello Dinh,

On Mon, Feb 25, 2019 at 5:35 PM Dinh Nguyen <dinguyen@kernel.org> wrote:
>
> Hi Andrey,
>
> On 2/22/19 6:21 AM, Andrey Zhizhikin wrote:
> > Enable CONFIG_LBDAF, which is required by ext4 fs. This option could
> > hanle both ext3 and ext4, and ex4 requires this option to be enabled,
> > otherwise the filesystem is mounted RO mode.
> >
> > Signed-off-by: Andrey Zhizhikin <andrey.z@gmail.com>
> > ---
> >  arch/arm/configs/socfpga_defconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
> > index 08d1b3e11d68..b4b387486cd9 100644
> > --- a/arch/arm/configs/socfpga_defconfig
> > +++ b/arch/arm/configs/socfpga_defconfig
> > @@ -21,7 +21,7 @@ CONFIG_NEON=y
> >  CONFIG_OPROFILE=y
> >  CONFIG_MODULES=y
> >  CONFIG_MODULE_UNLOAD=y
> > -# CONFIG_LBDAF is not set
>
> CONFIG_LDBAF is turned on by default for 32-bit. So all you have to do
> is remove this line.

Thanks a lot for clarifications here! I suspected that it was the
case, just needed a confirmation here.
Is it possible we would have this config option enabled for
socfpga_defconfig? If you would agree, then I prepare a separate patch
to have the "CONFIG_LBDAF is not set" removed.

>
> Thanks,
> Dinh

Thanks a lot!

--
Andrey.

Re: [PATCH] ARM: socfpga_defconfig: enable support for large block devices

[Dinh Nguyen]

On 2/25/19 12:55 PM, Andrey Zhizhikin wrote:
> Hello Dinh,
> 
> On Mon, Feb 25, 2019 at 5:35 PM Dinh Nguyen <dinguyen@kernel.org> wrote:
>>
>> Hi Andrey,
>>
>> On 2/22/19 6:21 AM, Andrey Zhizhikin wrote:
>>> Enable CONFIG_LBDAF, which is required by ext4 fs. This option could
>>> hanle both ext3 and ext4, and ex4 requires this option to be enabled,
>>> otherwise the filesystem is mounted RO mode.
>>>
>>> Signed-off-by: Andrey Zhizhikin <andrey.z@gmail.com>
>>> ---
>>>  arch/arm/configs/socfpga_defconfig | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
>>> index 08d1b3e11d68..b4b387486cd9 100644
>>> --- a/arch/arm/configs/socfpga_defconfig
>>> +++ b/arch/arm/configs/socfpga_defconfig
>>> @@ -21,7 +21,7 @@ CONFIG_NEON=y
>>>  CONFIG_OPROFILE=y
>>>  CONFIG_MODULES=y
>>>  CONFIG_MODULE_UNLOAD=y
>>> -# CONFIG_LBDAF is not set
>>
>> CONFIG_LDBAF is turned on by default for 32-bit. So all you have to do
>> is remove this line.
> 
> Thanks a lot for clarifications here! I suspected that it was the
> case, just needed a confirmation here.
> Is it possible we would have this config option enabled for
> socfpga_defconfig? If you would agree, then I prepare a separate patch
> to have the "CONFIG_LBDAF is not set" removed.

Yes, that's what I was alluding to.

Dinh