From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: dhowells@redhat.com, willy@infradead.org,
trond.myklebust@primarydata.com, darrick.wong@oracle.com,
jlayton@kernel.org, sfrench@samba.org,
torvalds@linux-foundation.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: Make swap_readpage() for SWP_FS_OPS use ->direct_IO() not ->readpage()
Date: Thu, 12 Aug 2021 13:57:05 +0100 [thread overview]
Message-ID: <3085432.1628773025@warthog.procyon.org.uk> (raw)
In-Reply-To: <20210812122104.GB18532@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
> On Thu, Aug 12, 2021 at 12:57:58PM +0100, David Howells wrote:
> > Make swap_readpage(), when accessing a swap file (SWP_FS_OPS) use
> > the ->direct_IO() method on the filesystem rather then ->readpage().
>
> ->direct_IO is just a helper for ->read_iter and ->write_iter, so please
> don't call it directly. It actually is slowly on its way out, with at
> at least all of the iomap implementations not using it, as well as various
> other file systems.
[Note that __swap_writepage() uses ->direct_IO().]
Calling ->write_iter is probably a bad idea here. Imagine that it goes
through, say, generic_file_write_iter(), then __generic_file_write_iter() and
then generic_file_direct_write(). It adds a number of delays into the system,
including:
- Taking the inode lock
- Removing file privs
- Cranking mtime, ctime, file version
- Doing mnt_want_write
- Setting the inode dirty
- Waiting on pages in the range that are being written
- Walking over the pagecache to invalidate the range
- Redoing the invalidation (can't be skipped since page 0 is pinned)
that we might want to skip as they'll end up being done for every page swapped
out.
> > + ki = kzalloc(sizeof(*ki), GFP_KERNEL);
> > + if (!ki)
> > + return -ENOMEM;
>
> for the synchronous case we could avoid this allocation and just use
> arguments on stack.
True.
David
next prev parent reply other threads:[~2021-08-12 12:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 11:57 [PATCH 0/2] mm: Fix NFS swapfiles and use DIO read for swapfiles David Howells
2021-08-12 11:57 ` [PATCH 1/2] nfs: Fix write to swapfile failure due to generic_write_checks() David Howells
2021-08-12 11:57 ` [PATCH 2/2] mm: Make swap_readpage() for SWP_FS_OPS use ->direct_IO() not ->readpage() David Howells
2021-08-12 12:21 ` Christoph Hellwig
2021-08-12 12:57 ` David Howells [this message]
2021-08-12 15:39 ` Matthew Wilcox
2021-08-12 17:02 ` Christoph Hellwig
2021-08-12 17:48 ` Darrick J. Wong
2021-08-12 18:14 ` Matthew Wilcox
2021-08-12 20:13 ` Theodore Ts'o
2021-08-13 6:54 ` Christoph Hellwig
2021-08-12 13:00 ` Matthew Wilcox
2021-08-12 13:23 ` David Howells
2021-08-12 13:37 ` David Howells
2021-08-12 13:50 ` Matthew Wilcox
2021-08-12 14:16 ` David Howells
2021-08-12 12:18 ` [PATCH 0/2] mm: Fix NFS swapfiles and use DIO read for swapfiles Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3085432.1628773025@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@primarydata.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).