From: "Theodore Ts'o" <tytso@mit.edu>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>,
David Howells <dhowells@redhat.com>,
trond.myklebust@primarydata.com, darrick.wong@oracle.com,
jlayton@kernel.org, sfrench@samba.org,
torvalds@linux-foundation.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: Make swap_readpage() for SWP_FS_OPS use ->direct_IO() not ->readpage()
Date: Thu, 12 Aug 2021 16:13:06 -0400 [thread overview]
Message-ID: <YRWA0tJy457V4/HO@mit.edu> (raw)
In-Reply-To: <YRVlDZRIm8zTjDIh@casper.infradead.org>
On Thu, Aug 12, 2021 at 07:14:37PM +0100, Matthew Wilcox wrote:
>
> Well ... this would actually allow the filesystem to break COWs and
> allocate new blocks for holes. Maybe you don't want to be doing that
> in a low-memory situation though ;-)
I'm not sure the benefits are worth the costs. You'd have to handle
ENOSPC errors, and it would require some kind of metadata journal
transaction, which could potentially block for any number of reasons
(not just due to memory allocations, but because you're waiting for a
journal commit to complete). As you say, doing that in a low-memory
situation seems to be unneeded complexity.
- Ted
next prev parent reply other threads:[~2021-08-12 20:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 11:57 [PATCH 0/2] mm: Fix NFS swapfiles and use DIO read for swapfiles David Howells
2021-08-12 11:57 ` [PATCH 1/2] nfs: Fix write to swapfile failure due to generic_write_checks() David Howells
2021-08-12 11:57 ` [PATCH 2/2] mm: Make swap_readpage() for SWP_FS_OPS use ->direct_IO() not ->readpage() David Howells
2021-08-12 12:21 ` Christoph Hellwig
2021-08-12 12:57 ` David Howells
2021-08-12 15:39 ` Matthew Wilcox
2021-08-12 17:02 ` Christoph Hellwig
2021-08-12 17:48 ` Darrick J. Wong
2021-08-12 18:14 ` Matthew Wilcox
2021-08-12 20:13 ` Theodore Ts'o [this message]
2021-08-13 6:54 ` Christoph Hellwig
2021-08-12 13:00 ` Matthew Wilcox
2021-08-12 13:23 ` David Howells
2021-08-12 13:37 ` David Howells
2021-08-12 13:50 ` Matthew Wilcox
2021-08-12 14:16 ` David Howells
2021-08-12 12:18 ` [PATCH 0/2] mm: Fix NFS swapfiles and use DIO read for swapfiles Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRWA0tJy457V4/HO@mit.edu \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@primarydata.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).