From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, dianders@chromium.org
Cc: Robin Murphy <robin.murphy@arm.com>,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 3/4] dt-bindings: arm: fix Rockchip rk3399-evb bindings
Date: Sun, 01 Mar 2020 01:02:06 +0100 [thread overview]
Message-ID: <3089122.gegXmbq47i@phil> (raw)
In-Reply-To: <229c3511-d99d-8bac-6241-0088c5fc13ef@gmail.com>
Hi Johan,
Am Freitag, 28. Februar 2020, 14:28:36 CET schrieb Johan Jonker:
> Hi Robin,
>
> When I look at the review process of rk3399-evb.dts
> it is mentioned here:
>
> https://lore.kernel.org/patchwork/patch/672327/
>
> >> + model = "Rockchip RK3399 Evaluation Board";
> >> + compatible = "rockchip,rk3399-evb", "rockchip,rk3399",
> >> + "google,rk3399evb-rev2", google,rk3399evb-rev1",
> >> + "google,rk3399evb-rev0" ;
> >
> > can you check against which compatibles that coreboot really matches?
> >
> > As we said that the evb changed between rev1 and rev2, I would expect the
> > compatible to be something like
> >
> > compatible = "rockchip,rk3399-evb", "google,rk3399evb-rev2",
> > "rockchip,rk3399";
> >
> > leaving out the rev1 and rev0
>
> The consensus in version 4 ends in what is shown in the dts file, so I
> changed it in rockchip.yaml. Things from the past maybe can better be
> explained by Heiko. Please advise if this patch needs to change and in
> what file.
Just get rid of the "google,rk3399evb-rev2" from the .dts please :-) .
(1) "rockchip,rk3399-evb", "rockchip,rk3399", "google,rk3399evb-rev2";
is just wrong for the reasons Robin explained, I guess that slipped
through review at the time.
(2) "google,rk3399evb-rev2" was a specific variant for Google I'm pretty
sure they'll have scraped all these boards directly after they had the
first actual rk3399-gru development devices
So I'm pretty sure the only rk3399-evbs in existence are the general ones.
Heiko
next prev parent reply other threads:[~2020-03-01 0:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 6:14 [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings Johan Jonker
2020-02-28 6:14 ` [PATCH 2/4] dt-bindings: arm: add Rockchip rk3036-evb board Johan Jonker
2020-02-28 6:14 ` [PATCH 3/4] dt-bindings: arm: fix Rockchip rk3399-evb bindings Johan Jonker
2020-02-28 12:42 ` Robin Murphy
2020-02-28 13:28 ` Johan Jonker
2020-03-01 0:02 ` Heiko Stuebner [this message]
2020-02-28 6:14 ` [PATCH 4/4] arm64: dts: rockchip: fix compatible property for Radxa ROCK Pi N10 Johan Jonker
2020-03-01 0:04 ` Heiko Stuebner
2020-02-28 12:35 ` [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings Robin Murphy
2020-02-28 12:50 ` Johan Jonker
2020-02-29 23:55 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3089122.gegXmbq47i@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).