From: Robin Murphy <robin.murphy@arm.com>
To: Johan Jonker <jbx6244@gmail.com>, heiko@sntech.de
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 3/4] dt-bindings: arm: fix Rockchip rk3399-evb bindings
Date: Fri, 28 Feb 2020 12:42:55 +0000 [thread overview]
Message-ID: <78b8b53f-2e2a-3804-41fb-bb2610947ca2@arm.com> (raw)
In-Reply-To: <20200228061436.13506-3-jbx6244@gmail.com>
On 28/02/2020 6:14 am, Johan Jonker wrote:
> A test with the command below gives this error:
>
> arch/arm64/boot/dts/rockchip/rk3399-evb.dt.yaml: /: compatible:
> ['rockchip,rk3399-evb', 'rockchip,rk3399', 'google,rk3399evb-rev2']
> is not valid under any of the given schemas
>
> Fix this error by adding 'google,rk3399evb-rev2' to the compatible
> property in rockchip.yaml
>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index d303790f5..6c6e8273e 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -509,6 +509,7 @@ properties:
> items:
> - const: rockchip,rk3399-evb
> - const: rockchip,rk3399
> + - const: google,rk3399evb-rev2
This looks wrong - the board can't reasonably be a *more* general match
than the SoC. If this is supposed to represent a specific variant of the
basic EVB design then it should come before "rockchip,rk3399-evb" (and
possibly be optional if other variants also exist).
Robin.
>
> - description: Rockchip RK3399 Sapphire standalone
> items:
>
next prev parent reply other threads:[~2020-02-28 12:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 6:14 [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings Johan Jonker
2020-02-28 6:14 ` [PATCH 2/4] dt-bindings: arm: add Rockchip rk3036-evb board Johan Jonker
2020-02-28 6:14 ` [PATCH 3/4] dt-bindings: arm: fix Rockchip rk3399-evb bindings Johan Jonker
2020-02-28 12:42 ` Robin Murphy [this message]
2020-02-28 13:28 ` Johan Jonker
2020-03-01 0:02 ` Heiko Stuebner
2020-02-28 6:14 ` [PATCH 4/4] arm64: dts: rockchip: fix compatible property for Radxa ROCK Pi N10 Johan Jonker
2020-03-01 0:04 ` Heiko Stuebner
2020-02-28 12:35 ` [PATCH 1/4] dt-bindings: arm: fix Rockchip Kylin board bindings Robin Murphy
2020-02-28 12:50 ` Johan Jonker
2020-02-29 23:55 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78b8b53f-2e2a-3804-41fb-bb2610947ca2@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).